Skip to content

Add ./x.py check src/{libstd,libtest,librustc} - #47460

Merged
bors merged 2 commits into
rust-lang:masterfrom
Mark-Simulacrum:bootstrap-check
Jan 26, 2018
Merged

Add ./x.py check src/{libstd,libtest,librustc}#47460
bors merged 2 commits into
rust-lang:masterfrom
Mark-Simulacrum:bootstrap-check

Conversation

@Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum commented Jan 15, 2018

Copy link
Copy Markdown
Member

This currently only supports a limited subset of the full compilation,
but is likely 90% of what people will want and is possible without
building a full compiler (and also building LLVM). In theory, this means
that contributors who don't want to build LLVM now have an easy way to
compile locally, though running tests won't work.

@Mark-Simulacrum

Copy link
Copy Markdown
MemberAuthor

cc @rust-lang/compiler

r? @alexcrichton

@Mark-SimulacrumMark-Simulacrum changed the title Add ./x.py check {libstd,libtest,librustc}.Add ./x.py check src/{libstd,libtest,librustc}Jan 15, 2018
Comment threadsrc/bootstrap/flags.rs Outdated

@kennytmkennytmJan 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking in non-stage-0 may still be useful if we want to check libstd after some new semantic is implemented:

./x.py build --stage 0 src/librustc
./x.py check --keep-stage 1 --stage 1 src/libstd
# edit
./x.py check --keep-stage 1 --stage 1 src/libstd
# edit
./x.py check --keep-stage 1 --stage 1 src/libstd

@michaelwoerister

Copy link
Copy Markdown
Member

What exactly do these do?

@Mark-Simulacrum

Copy link
Copy Markdown
MemberAuthor

This runs cargo check instead of cargo build which nets much faster builds. Currently only works with stage 0, though we could technically expand it to work with any stage.

@michaelwoerister

Copy link
Copy Markdown
Member

OK, that's great!

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2018
@bors

bors commented Jan 18, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #47528) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton

Copy link
Copy Markdown
Member

Oops sorry about that, looks great to me!

r=me

@Mark-Simulacrum

Copy link
Copy Markdown
MemberAuthor

@bors r=alexcrichton

@bors

bors commented Jan 19, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 7319232 has been approved by alexcrichton

@matklad

Copy link
Copy Markdown
Contributor

@Mark-Simulacrum

Copy link
Copy Markdown
MemberAuthor

Probably, yes. I'll open an issue.

@bors

bors commented Jan 23, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #47678) made this pull request unmergeable. Please resolve the merge conflicts.

This currently only supports a limited subset of the full compilation,
but is likely 90% of what people will want and is possible without
building a full compiler (i.e., running LLVM). In theory, this means
that contributors who don't want to build LLVM now have an easy way to
compile locally, though running tests won't work.
@Mark-Simulacrum

Copy link
Copy Markdown
MemberAuthor

@bors r=alexcrichton

@bors

bors commented Jan 24, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 6aeb1cf has been approved by alexcrichton

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 25, 2018
…alexcrichton
Add ./x.py check src/{libstd,libtest,librustc}
This currently only supports a limited subset of the full compilation,
but is likely 90% of what people will want and is possible without
building a full compiler (and also building LLVM). In theory, this means
that contributors who don't want to build LLVM now have an easy way to
compile locally, though running tests won't work.
bors added a commit that referenced this pull request Jan 26, 2018
@bors
bors merged commit 6aeb1cf into rust-lang:masterJan 26, 2018
@emilyalbiniemilyalbini mentioned this pull request Jan 30, 2018
@Mark-Simulacrum
Mark-Simulacrum deleted the bootstrap-check branch June 8, 2019 13:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Mark-Simulacrum@michaelwoerister@bors@alexcrichton@matklad@kennytm