Uh oh!
There was an error while loading. Please reload this page.
Add ./x.py check src/{libstd,libtest,librustc} - #47460
Conversation
Mark-Simulacrum
commented
Jan 15, 2018
cc @rust-lang/compiler |
206c1c4 to
cc8717fCompareThere was a problem hiding this comment.
Checking in non-stage-0 may still be useful if we want to check libstd after some new semantic is implemented:
./x.py build --stage 0 src/librustc
./x.py check --keep-stage 1 --stage 1 src/libstd
# edit
./x.py check --keep-stage 1 --stage 1 src/libstd
# edit
./x.py check --keep-stage 1 --stage 1 src/libstdmichaelwoerister
commented
Jan 16, 2018
What exactly do these do? |
Mark-Simulacrum
commented
Jan 16, 2018
This runs |
michaelwoerister
commented
Jan 16, 2018
OK, that's great! |
bors
commented
Jan 18, 2018
☔ The latest upstream changes (presumably #47528) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
commented
Jan 19, 2018
Oops sorry about that, looks great to me! r=me |
cc8717f to
7319232CompareMark-Simulacrum
commented
Jan 19, 2018
@bors r=alexcrichton |
bors
commented
Jan 19, 2018
📌 Commit 7319232 has been approved by |
matklad
commented
Jan 21, 2018
Should this option be mentioned in https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#the-build-system? |
Mark-Simulacrum
commented
Jan 21, 2018
Probably, yes. I'll open an issue. |
bors
commented
Jan 23, 2018
☔ The latest upstream changes (presumably #47678) made this pull request unmergeable. Please resolve the merge conflicts. |
This currently only supports a limited subset of the full compilation, but is likely 90% of what people will want and is possible without building a full compiler (i.e., running LLVM). In theory, this means that contributors who don't want to build LLVM now have an easy way to compile locally, though running tests won't work.
7319232 to
6aeb1cfCompareMark-Simulacrum
commented
Jan 24, 2018
@bors r=alexcrichton |
bors
commented
Jan 24, 2018
📌 Commit 6aeb1cf has been approved by |
…alexcrichton
Add ./x.py check src/{libstd,libtest,librustc}
This currently only supports a limited subset of the full compilation,
but is likely 90% of what people will want and is possible without
building a full compiler (and also building LLVM). In theory, this means
that contributors who don't want to build LLVM now have an easy way to
compile locally, though running tests won't work.
This currently only supports a limited subset of the full compilation,
but is likely 90% of what people will want and is possible without
building a full compiler (and also building LLVM). In theory, this means
that contributors who don't want to build LLVM now have an easy way to
compile locally, though running tests won't work.