Skip to content

[perf] Use std based dedup in projection - #47656

Merged
bors merged 2 commits into
rust-lang:masterfrom
ishitatsuyuki:patch-1
Jan 26, 2018
Merged

[perf] Use std based dedup in projection#47656
bors merged 2 commits into
rust-lang:masterfrom
ishitatsuyuki:patch-1

Conversation

@ishitatsuyuki

@ishitatsuyukiishitatsuyuki commented Jan 22, 2018

Copy link
Copy Markdown
Contributor

Unstable sort was added recently, and the code that is being modified is 3 years old. As quicksort doesn't allocate it will likely perform as well as, or better than linear search.

I didn't benchmark. Have a perf run.

@ishitatsuyuki
Use std based dedup in projection
0bbc422
Unstable sort was added recently, and the code that is being modified is 3 years old. As quicksort doesn't allocate it will likely perform as well as, or better than linear search.
@rust-highfive

rust-highfive commented Jan 22, 2018

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@ishitatsuyukiishitatsuyuki changed the title [perf] Use std based dedup in projection[wip][perf] Use std based dedup in projectionJan 22, 2018
@ishitatsuyuki

ishitatsuyuki commented Jan 22, 2018

Copy link
Copy Markdown
ContributorAuthor

Hmm, so basically sorting fails because most types do not implement Ord. Is it a good idea to add derivation of them in this PR?

@kennytm

kennytm commented Jan 22, 2018

Copy link
Copy Markdown
Member

@ishitatsuyuki Let's add it, we need a perf check anyway. If it's unacceptable we could use sort_unstable_by_key.

@kennytmkennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 22, 2018
@nikomatsakis

nikomatsakis commented Jan 22, 2018

Copy link
Copy Markdown
Contributor

Seems fine. I'd like to see some perf results, for sure -- even a local run on some non-trivial test case might be of interest.

@ishitatsuyuki
ishitatsuyukiforce-pushed the patch-1 branch 2 times, most recently from b89ebbb to 732ee67CompareJanuary 22, 2018 23:41
@ishitatsuyukiishitatsuyuki changed the title [wip][perf] Use std based dedup in projection[perf] Use std based dedup in projectionJan 23, 2018
@ishitatsuyuki

ishitatsuyuki commented Jan 23, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Unwipped. Please perform a try and/or perf.

@Zoxc

Zoxc commented Jan 23, 2018

Copy link
Copy Markdown
Contributor

@bors try

@bors

bors commented Jan 23, 2018

Copy link
Copy Markdown
Collaborator

⌛ Trying commit c6772b4 with merge 77de396b7685c2d4870314ad7ca865ad7b6feb5c...

@bors

bors commented Jan 23, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-travis
State: approved= try=True

@ishitatsuyuki

ishitatsuyuki commented Jan 23, 2018

Copy link
Copy Markdown
ContributorAuthor

@Mark-Simulacrum please perform a perf run.

@kennytmkennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 23, 2018
@Mark-Simulacrum

Mark-Simulacrum commented Jan 23, 2018

Copy link
Copy Markdown
Member

Perf queued.

@ishitatsuyuki

ishitatsuyuki commented Jan 24, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

http://perf.rust-lang.org/compare.html?start=47a8eb7c4e24b61a8a9ab4eaff60ef65291aaa56&end=77de396b7685c2d4870314ad7ca865ad7b6feb5c&stat=instructions%3Au

... and well, surprisingly no noticable time change except one (see below). To sum up, the code is now cleaner and resistant to quadratic blowup, but some Ord implementations are added.

The case where quicksort probably shines:

| clean incremental-opt | 251066587932.00 | 206164489487.00 | -17.9% |

EDIT: this time is quite fluctuating and should not be used as a metric.

@nikomatsakis

nikomatsakis commented Jan 25, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 25, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit c6772b4 has been approved by nikomatsakis

@nikomatsakisnikomatsakis added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2018
@alexcrichtonalexcrichton mentioned this pull request Jan 25, 2018
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 25, 2018
@alexcrichton
Rollup merge ofrust-lang#47656- ishitatsuyuki:patch-1, r=nikomatsakis
014931b
[perf] Use std based dedup in projection
Unstable sort was added recently, and the code that is being modified is 3 years old. As quicksort doesn't allocate it will likely perform as well as, or better than linear search.
I didn't benchmark. Have a perf run.
bors added a commit that referenced this pull request Jan 26, 2018
@bors
Auto merge of#47748- alexcrichton:rollup, r=alexcrichton
bacb5c5
Rollup of 19 pull requests
- Successful merges: #47415, #47437, #47439, #47453, #47460, #47502, #47529, #47600, #47607, #47618, #47626, #47656, #47668, #47696, #47701, #47705, #47710, #47711, #47719
- Failed merges: #47455, #47521
@bors
bors merged commit c6772b4 into rust-lang:masterJan 26, 2018
This was referenced Feb 17, 2018
Merged
Closed
@ishitatsuyuki
ishitatsuyuki deleted the patch-1 branch July 15, 2018 13:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ishitatsuyuki@rust-highfive@kennytm@nikomatsakis@Zoxc@bors@Mark-Simulacrum