Uh oh!
There was an error while loading. Please reload this page.
Issue 4635 - #4748
Conversation
brson
commented
Feb 5, 2013
maybe @nikomatsakis can help. I am not familiar with this code. |
sanxiyn
commented
Feb 12, 2013
Rebased. |
nikomatsakis
commented
Feb 13, 2013
Note: r- on 2875079 pending more tests being added / tests being re-enabled. Also, a question to @sanxiyn : Did you try setting up pat_vec like so: pat_vec(before_pats, slice_pat, after_pats) rather than using an index? That would have been my first guess. I'm not sure if the code would wind up cleaner, messier, or more of the same, but it seems potentially cleaner to me overall, since the role that these patterns play is quite different. But the current setup is also ok if you think it works out better this way. |
catamorphism
commented
Feb 17, 2013
I'm closing this due to lack of reply to @nikomatsakis 's questions -- but, @sanxiyn , please open a new pull request when you have time to address these issues! Thanks! |
Incorporated @nikomatsakis's comments from #4748. Fix#4635.
fix empty stack in deadlock error message
4729: Hover actions r=matklad a=vsrs This PR adds a `hoverActions` LSP extension and a `Go to Implementations` action as an example:  4748: Add an `ImportMap` and use it to resolve item paths in `find_path` r=matklad a=jonas-schievink Removes the "go faster" queries I added in rust-lang/rust-analyzer#4501 and rust-lang/rust-analyzer#4506. I've checked this PR on the rustc code base and the assists are still fast. This should fixrust-lang/rust-analyzer#4515. Note that this does introduce a change in behavior: We now always refer to items defined in external crates using paths through the external crate. Previously we could also use a local path (if for example the extern crate was reexported locally), as seen in the changed test. If that is undesired I can fix that, but the test didn't say why the previous behavior would be preferable. Co-authored-by: vsrs <vit@conrlab.com> Co-authored-by: Jonas Schievink <jonasschievink@gmail.com> Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Fix for #4635.
check_match.rsneeds to be updated, but I couldn't figure out how. Tests are xfailed.Code generation seems to work. Added a test
vec-matching-fold.rs.First commit is pure rename, since
tailis no more appropriate.pat_vec(~[@pat], Option<@pat>)was changed topat_vec(~[@pat], Option<uint>).Before:
[a]parses topat_vec(~[a], None)[a, ..b]parses topat_vec(~[a], Some(b))After:
[a]parses topat_vec(~[a], None)[a, ..b]parses topat_vec(~[a, b], Some(1))[..a, b]parses topat_vec(~[a, b], Some(0))[a, ..b, c]parses topat_vec(~[a, b, c], Some(1))