Skip to content

Vector destructuring from tail, take 2 - #5122

Closed
sanxiyn wants to merge 2 commits into
rust-lang:incomingfrom
sanxiyn:vec-match-tail-2
Closed

Vector destructuring from tail, take 2#5122
sanxiyn wants to merge 2 commits into
rust-lang:incomingfrom
sanxiyn:vec-match-tail-2

Conversation

@sanxiyn

Copy link
Copy Markdown
Contributor

Incorporated @nikomatsakis's comments from #4748.

Fix#4635.

@sanxiyn

Copy link
Copy Markdown
ContributorAuthor

core::util::unreachable() failed on Windows, so changed to ::core::util::unreachable(). By the way, does anyone know why?

@graydon

Copy link
Copy Markdown
Contributor

No, that sounds deeply strange. Can you open a bug?

@nikomatsakis

Copy link
Copy Markdown
Contributor

@sanxiyn I'd like to see this patch land, is it possible for you to rebase and add in the suggestions?

@sanxiyn

Copy link
Copy Markdown
ContributorAuthor

Rebased, fixed a copy, added a test.

bors added a commit that referenced this pull request Mar 11, 2013
@borsbors closed this Mar 11, 2013
@graydon

Copy link
Copy Markdown
Contributor

Excellent, thanks!

U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
5122: Fix "Run | Debug" lens for examples r=matklad a=vsrs
Fixesrust-lang#4974
Co-authored-by: vsrs <vit@conrlab.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sanxiyn@graydon@nikomatsakis@bors