Uh oh!
There was an error while loading. Please reload this page.
add Rust By Example to the bookshelf - #47508
Merged
Merged
Conversation
rust-highfive
commented
Jan 17, 2018
Contributor
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
frewsxcv
commented
Jan 17, 2018
Contributor
Is this waiting on anything ? If not r=me |
QuietMisdreavus
commented
Jan 17, 2018
ContributorAuthor
I don't think this is waiting on anything administrative. RBE is already being rendered and included with the official docs - https://doc.rust-lang.org/nightly/rust-by-example/ exists right now. Travis had an issue where they had issues with builds getting backed up yesterday, so it never ran on this PR. I just restarted it, so it looks like we can wait for linkchecker if you want. |
steveklabnik
approved these changes
Jan 17, 2018
steveklabnik
commented
Jan 17, 2018
Contributor
@bors: r+ rollup |
bors
commented
Jan 17, 2018
Collaborator
📌 Commit 0e1ecbe has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 19, 2018
…eveklabnik add Rust By Example to the bookshelf cc rust-lang#46194 With rust-lang#46196 freshly merged, we should add a link to the main docs distribution so people can find it! We discussed this at the docs team meeting today and decided to go ahead with adding it to the bookshelf.
bors added a commit
that referenced
this pull request
Jan 19, 2018
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 20, 2018
…eveklabnik add Rust By Example to the bookshelf cc rust-lang#46194 With rust-lang#46196 freshly merged, we should add a link to the main docs distribution so people can find it! We discussed this at the docs team meeting today and decided to go ahead with adding it to the bookshelf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #46194
With #46196 freshly merged, we should add a link to the main docs distribution so people can find it! We discussed this at the docs team meeting today and decided to go ahead with adding it to the bookshelf.