Skip to content

Add E0659 for ambiguous names - #47512

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:e0659
Jan 22, 2018
Merged

Add E0659 for ambiguous names#47512
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:e0659

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Jan 17, 2018

Copy link
Copy Markdown
Member

Still on the tracks of the "no error without error code" road.

@rust-highfive

rust-highfive commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

petrochenkov commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 17, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit e207b0b has been approved by petrochenkov

@kennytmkennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 17, 2018
@kennytm

kennytm commented Jan 17, 2018•
edited
Loading

Copy link
Copy Markdown
Member

@bors r-

Travis failed. Please check if the examples will really emit E0659

Details
[01:28:44] failures:
[01:28:44] [01:28:44] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0659 (line 11858) stdout ----
[01:28:44] error[E0432]: unresolved import `moon`
[01:28:44] --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:11868:13
[01:28:44] |
[01:28:44] 12 | pub use moon::*;
[01:28:44] | ^^^^ Maybe a missing `extern crate moon;`?
[01:28:44] [01:28:44] error[E0432]: unresolved import `earth`
[01:28:44] --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:11869:13
[01:28:44] |
[01:28:44] 13 | pub use earth::*;
[01:28:44] | ^^^^^ Maybe a missing `extern crate earth;`?
[01:28:44] [01:28:44] error[E0425]: cannot find function `foo` in module `collider`
[01:28:44] --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:11872:11
[01:28:44] |
[01:28:44] 16 | collider::foo(); // ERROR: `foo` is ambiguous
[01:28:44] | ^^^ not found in `collider`
[01:28:44] [01:28:44] thread 'rustc' panicked at 'Some expected error codes were not found: ["E0659"]', librustdoc/test.rs:294:9
[01:28:44] [01:28:44] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0659 (line 11884) stdout ----
[01:28:44] error[E0432]: unresolved import `moon`
[01:28:44] --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:11894:13
[01:28:44] |
[01:28:44] 12 | pub use moon;
[01:28:44] | ^^^^ no `moon` in the root
[01:28:44] [01:28:44] error[E0432]: unresolved import `earth`
[01:28:44] --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:11895:13
[01:28:44] |
[01:28:44] 13 | pub use earth;
[01:28:44] | ^^^^^ no `earth` in the root
[01:28:44] [01:28:44] thread 'rustc' panicked at 'couldn't compile the test', librustdoc/test.rs:289:13
[01:28:44] [01:28:44] [01:28:44] failures:
[01:28:44] /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0659 (line 11858)
[01:28:44] /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0659 (line 11884)
[01:28:44] [01:28:44] test result: FAILED. 662 passed; 2 failed; 22 ignored; 0 measured; 0 filtered out

@kennytmkennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 17, 2018
@GuillaumeGomez

GuillaumeGomez commented Jan 17, 2018

Copy link
Copy Markdown
MemberAuthor

I need to add a main function I think so rustdoc won't wrap them.

@kennytm

kennytm commented Jan 17, 2018

Copy link
Copy Markdown
Member

The pub use moon::*; one is fixed, but the pub use moon; one is still failing with other errors.

Details
[01:38:35] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0659 (line 11886) stdout ----
[01:38:35] error[E0365]: `moon` is private, and cannot be reexported
[01:38:35] --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:11896:13
[01:38:35] |
[01:38:35] 11 | pub use moon;
[01:38:35] | ^^^^ reexport of private `moon`
[01:38:35] |
[01:38:35] = note: consider declaring type or module `moon` with `pub`
[01:38:35] [01:38:35] error[E0365]: `earth` is private, and cannot be reexported
[01:38:35] --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:11897:13
[01:38:35] |
[01:38:35] 12 | pub use earth;
[01:38:35] | ^^^^^ reexport of private `earth`
[01:38:35] |
[01:38:35] = note: consider declaring type or module `earth` with `pub`
[01:38:35] [01:38:35] thread 'rustc' panicked at 'couldn't compile the test', librustdoc/test.rs:289:13

theotherphil
theotherphil reviewed Jan 18, 2018
View reviewed changes
Comment threadsrc/librustc_resolve/diagnostics.rs Outdated

@theotherphiltheotherphilJan 18, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar nits: "are imported in a same module" is incorrect. "are imported into a module" is better. "In here" should just be "Here".

@petrochenkov

petrochenkov commented Jan 18, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 18, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f66e711 has been approved by petrochenkov

@petrochenkovpetrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 18, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 19, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#47512- GuillaumeGomez:e0659, r=petrochenkov
223b474
Add E0659 for ambiguous names
Still on the tracks of the "no error without error code" road.
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 19, 2018
Closed
bors added a commit that referenced this pull request Jan 19, 2018
@bors
Auto merge of#47572- GuillaumeGomez:rollup, r=GuillaumeGomez
a7b8622
Rollup of 8 pull requests
- Successful merges: #46938, #47334, #47420, #47508, #47510, #47512, #47535, #47559
- Failed merges:
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 21, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 21, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#47512- GuillaumeGomez:e0659, r=petrochenkov
a1c3449
Add E0659 for ambiguous names
Still on the tracks of the "no error without error code" road.
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 21, 2018
Merged
bors added a commit that referenced this pull request Jan 21, 2018
@bors
Auto merge of#47644- GuillaumeGomez:rollup, r=GuillaumeGomez
ff2a7c8
Rollup of 9 pull requests
- Successful merges: #47247, #47334, #47512, #47582, #47595, #47625, #47632, #47633, #47637
- Failed merges:
@bors
bors merged commit f66e711 into rust-lang:masterJan 22, 2018
@GuillaumeGomez
GuillaumeGomez deleted the e0659 branch January 22, 2018 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@theotherphiltheotherphiltheotherphil left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-highfive@petrochenkov@bors@kennytm@theotherphil