Skip to content

Punctuation and clarity fixes. - #47515

Merged
bors merged 1 commit into
rust-lang:masterfrom
jimmantooth:patch-1
Jan 30, 2018
Merged

Punctuation and clarity fixes.#47515
bors merged 1 commit into
rust-lang:masterfrom
jimmantooth:patch-1

Conversation

@jimmantooth

@jimmantoothjimmantooth commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytmkennytm added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jan 17, 2018
@aidanhs

aidanhs commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

Thanks for the PR! We'll check in now and again to make sure @steveklabnik or another reviewer gets to this soon.

@aidanhsaidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2018
@carols10cents

carols10cents commented Jan 22, 2018

Copy link
Copy Markdown
Member

review ping for you @steveklabnik !

@shepmaster

shepmaster commented Jan 26, 2018

Copy link
Copy Markdown
Member

No comment from @steveklabnik in over a week; picking new reviewer from @rust-lang/docs:

r? @QuietMisdreavus

@QuietMisdreavus

QuietMisdreavus commented Jan 26, 2018

Copy link
Copy Markdown
Contributor

@bors r+ rollup

Sorry this fell through the cracks! Thanks so much!

@bors

bors commented Jan 26, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit c2e2612 has been approved by QuietMisdreavus

@bors

bors commented Jan 29, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c2e2612 with merge bcd0546...

bors added a commit that referenced this pull request Jan 29, 2018
@bors
Auto merge of#47515- jimmantooth:patch-1, r=QuietMisdreavus
bcd0546
Punctuation and clarity fixes.
@bors

bors commented Jan 29, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@kennytm

kennytm commented Jan 29, 2018

Copy link
Copy Markdown
Member

@bors retry #46903

kennytm added a commit to kennytm/rust that referenced this pull request Jan 29, 2018
@kennytm
Rollup merge ofrust-lang#47515- jimmantooth:patch-1, r=QuietMisdreavus
525c8d0
Punctuation and clarity fixes.
@kennytmkennytm mentioned this pull request Jan 29, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Jan 30, 2018
@kennytm
Rollup merge ofrust-lang#47515- jimmantooth:patch-1, r=QuietMisdreavus
19aac09
Punctuation and clarity fixes.
@kennytmkennytm mentioned this pull request Jan 30, 2018
Merged
bors added a commit that referenced this pull request Jan 30, 2018
@bors
Auto merge of#47870- kennytm:rollup, r=kennytm
def3269
Rollup of 12 pull requests
- Successful merges: #47515, #47603, #47718, #47732, #47760, #47780, #47822, #47826, #47836, #47839, #47853, #47855
- Failed merges:
@bors
bors merged commit c2e2612 into rust-lang:masterJan 30, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@QuietMisdreavusQuietMisdreavus

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jimmantooth@rust-highfive@aidanhs@carols10cents@shepmaster@QuietMisdreavus@bors@kennytm@steveklabnik