Skip to content

Increase test coverage of use_nested_groups - #47853

Merged
bors merged 1 commit into
masterfrom
increase-nested-groups-test-coverage
Jan 30, 2018
Merged

Increase test coverage of use_nested_groups#47853
bors merged 1 commit into
masterfrom
increase-nested-groups-test-coverage

Conversation

@emilyalbini

@emilyalbiniemilyalbini commented Jan 29, 2018

Copy link
Copy Markdown
Member

@rust-highfive

rust-highfive commented Jan 29, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@emilyalbini

emilyalbini commented Jan 29, 2018

Copy link
Copy Markdown
MemberAuthor

cc #44494

@nikomatsakis

nikomatsakis commented Jan 29, 2018

Copy link
Copy Markdown
Contributor

Awesome! Thanks.

@bors r+

@bors

bors commented Jan 29, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 8389b66 has been approved by nikomatsakis

@kennytm

kennytm commented Jan 29, 2018

Copy link
Copy Markdown
Member

@bors rollup

@nikomatsakisnikomatsakis added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 29, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jan 29, 2018
@kennytm
Rollup merge ofrust-lang#47853- rust-lang:increase-nested-groups-te…
667f6df
…st-coverage, r=nikomatsakis
Increase test coverage of use_nested_groups
r? @nikomatsakis
@kennytmkennytm mentioned this pull request Jan 29, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Jan 30, 2018
@kennytm
Rollup merge ofrust-lang#47853- rust-lang:increase-nested-groups-te…
b83fb0f
…st-coverage, r=nikomatsakis
Increase test coverage of use_nested_groups
r? @nikomatsakis
@kennytmkennytm mentioned this pull request Jan 30, 2018
Merged
bors added a commit that referenced this pull request Jan 30, 2018
@bors
Auto merge of#47870- kennytm:rollup, r=kennytm
def3269
Rollup of 12 pull requests
- Successful merges: #47515, #47603, #47718, #47732, #47760, #47780, #47822, #47826, #47836, #47839, #47853, #47855
- Failed merges:
@bors
bors merged commit 8389b66 into masterJan 30, 2018
@emilyalbini
emilyalbini deleted the increase-nested-groups-test-coverage branch January 30, 2018 15:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emilyalbini@rust-highfive@nikomatsakis@bors@kennytm