Uh oh!
There was an error while loading. Please reload this page.
NLL test for mutating &mut references - #47609
Conversation
rust-highfive
commented
Jan 20, 2018
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
alexcrichton
commented
Jan 20, 2018
matthewjasper
commented
Jan 20, 2018
Should this be replacing this test? |
nikomatsakis
commented
Jan 22, 2018
Hmm, yes, a good point! Maybe we already had the test? I like how this test actually runs the result, though. @ritiek care to merge the two tests? |
ritiek
commented
Jan 23, 2018
Sure! Where should we keep the merged test though? |
nikomatsakis
commented
Jan 23, 2018
@ritiek I prefer the |
44b6f0e to
06d123dCompareritiek
commented
Jan 23, 2018
OK. So now we have the merged test in |
nikomatsakis
commented
Jan 23, 2018
bors
commented
Jan 23, 2018
📌 Commit 06d123d has been approved by |
nikomatsakis
commented
Jan 23, 2018
@bors rollup |
…nikomatsakis NLL test for mutating &mut references As mentioned in rust-lang#46361. cc @nikomatsakis?
…nikomatsakis NLL test for mutating &mut references As mentioned in rust-lang#46361. cc @nikomatsakis?
As mentioned in #46361.
cc @nikomatsakis?