Skip to content

fix for documentation error issue 47716 - #47717

Merged
bors merged 1 commit into
rust-lang:masterfrom
evelynmitchell:47716-doc-fix
Jan 25, 2018
Merged

fix for documentation error issue 47716#47717
bors merged 1 commit into
rust-lang:masterfrom
evelynmitchell:47716-doc-fix

Conversation

@evelynmitchell

@evelynmitchellevelynmitchell commented Jan 24, 2018•
edited by kennytm
Loading

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez

GuillaumeGomez commented Jan 24, 2018

Copy link
Copy Markdown
Member

r? @steveklabnik

cc @rust-lang/docs

@kennytmkennytm added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2018
@steveklabnik

steveklabnik commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

Thanks!

@bors: r+ rollup

@bors

bors commented Jan 24, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 05652d2 has been approved by steveklabnik

@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 25, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 25, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#47717- evelynmitchell:47716-doc-fix, r=ste…
f72d441
…veklabnik
fix for documentation error issue 47716
Fixrust-lang#47716
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 25, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#47717- evelynmitchell:47716-doc-fix, r=ste…
f769b9d
…veklabnik
fix for documentation error issue 47716
Fixrust-lang#47716
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 25, 2018
Merged
bors added a commit that referenced this pull request Jan 25, 2018
@bors
Auto merge of#47740- GuillaumeGomez:rollup, r=GuillaumeGomez
9fd7da9
Rollup of 10 pull requests
- Successful merges: #47534, #47609, #47679, #47691, #47700, #47702, #47717, #47721, #47726, #47729
- Failed merges:
@bors
bors merged commit 05652d2 into rust-lang:masterJan 25, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@steveklabniksteveklabniksteveklabnik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@steveklabniksteveklabnik

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@evelynmitchell@rust-highfive@GuillaumeGomez@steveklabnik@bors@kennytm