Skip to content

Mark doc examples w/ extern blocks as ignore. - #48325

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:frewxcv-ignore
Feb 22, 2018
Merged

Mark doc examples w/ extern blocks as ignore.#48325
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:frewxcv-ignore

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Feb 18, 2018

Copy link
Copy Markdown
Contributor

Fixes#48218.

@rust-highfive

rust-highfive commented Feb 18, 2018

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2018
@frewsxcv

frewsxcv commented Feb 18, 2018

Copy link
Copy Markdown
ContributorAuthor

r? @steveklabnik

@kennytm

kennytm commented Feb 18, 2018

Copy link
Copy Markdown
Member

Could we hide the “run” button, or insert a #![crate_type="lib"] when sending to playground when a code block is marked as ```no_run, instead of ignoring the tests?

@steveklabnik

steveklabnik commented Feb 20, 2018

Copy link
Copy Markdown
Contributor

Could we hide the “run” button, or insert a #![crate_type="lib"] when sending to playground when a code block is marked as ```no_run, instead of ignoring the tests?

This sounds like a separate request; we do hide the run button for ignore already... maybe open an issue?

@steveklabnik

steveklabnik commented Feb 20, 2018

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

thanks!

@bors

bors commented Feb 20, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 872c782 has been approved by steveklabnik

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 21, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#48325- frewsxcv:frewxcv-ignore, r=stevekla…
27c6ff5
…bnik
Mark doc examples w/ `extern` blocks as `ignore`.
Fixesrust-lang#48218.
@GuillaumeGomezGuillaumeGomez mentioned this pull request Feb 21, 2018
Merged
bors added a commit that referenced this pull request Feb 22, 2018
@bors
Auto merge of#48399- GuillaumeGomez:rollup, r=GuillaumeGomez
b1f8e6f
Rollup of 12 pull requests
- Successful merges: #47379, #47833, #48106, #48198, #48314, #48325, #48335, #48352, #48354, #48360, #48382, #48397
- Failed merges:
@bors
bors merged commit 872c782 into rust-lang:masterFeb 22, 2018
@frewsxcv
frewsxcv deleted the frewxcv-ignore branch May 13, 2018 20:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@steveklabniksteveklabniksteveklabnik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frewsxcv@rust-highfive@kennytm@steveklabnik@bors