Uh oh!
There was an error while loading. Please reload this page.
Fix rustdoc test ICE - #48382
Merged
Merged
Conversation
estebank
commented
Feb 20, 2018
Contributor
r=me once travis passes Shouldn't this provide a warning? |
GuillaumeGomez
commented
Feb 20, 2018
MemberAuthor
bors
commented
Feb 20, 2018
Collaborator
📌 Commit 5cbf9ae has been approved by |
QuietMisdreavus
commented
Feb 20, 2018
Contributor
What's the process for nominating for beta backport? This ICE is currently in beta as well. |
estebank
commented
Feb 20, 2018
Contributor
QuietMisdreavus
commented
Feb 21, 2018
Contributor
@estebank Thanks! Nominating for beta backport. The included test ICEs on |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 21, 2018
…ic, r=estebank Fix rustdoc test ICE Fixesrust-lang#48377. r? @QuietMisdreavus
nikomatsakis
commented
Feb 22, 2018
Contributor
Accepting for backport, though I'm not sure which team is responsible. cc @rust-lang/docs |
frewsxcv
commented
Feb 23, 2018
Contributor
beta backport pr: #48454 |
bors added a commit
that referenced
this pull request
Feb 27, 2018
[beta] Backport "Fix rustdoc test ICE" #48382
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Mar 21, 2018
…tart, r=QuietMisdreavus Add warning for invalid start of code blocks in rustdoc Follow up of rust-lang#48382. Still two things to consider: 1. Adding test for rustdoc output (but where? In UI or in rustdoc tests?). 2. Try to fix the span issue. r? @QuietMisdreavus
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Mar 22, 2018
…tart, r=QuietMisdreavus Add warning for invalid start of code blocks in rustdoc Follow up of rust-lang#48382. Still two things to consider: 1. Adding test for rustdoc output (but where? In UI or in rustdoc tests?). 2. Try to fix the span issue. r? @QuietMisdreavus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#48377.
r? @QuietMisdreavus