Skip to content

Add nonstandard_style alias for bad_style. - #48386

Merged
bors merged 4 commits into
rust-lang:masterfrom
withoutboats:nonstandard-style
Feb 25, 2018
Merged

Add nonstandard_style alias for bad_style.#48386
bors merged 4 commits into
rust-lang:masterfrom
withoutboats:nonstandard-style

Conversation

@withoutboats

@withoutboatswithoutboats commented Feb 20, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Feb 20, 2018

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@withoutboats

withoutboats commented Feb 20, 2018

Copy link
Copy Markdown
ContributorAuthor

r? @Manishearth

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2018
@Manishearth

Manishearth commented Feb 20, 2018

Copy link
Copy Markdown
Member

This isn't enough, right now the bad_style lint group will still be shown in the rustc -W help output.

What needs to be done is to rename the lint group and add a silent alias for backwards compatibility.

(also the interaction of overlapping lint groups is kinda iffy)

r=me for landing this as is though.

@withoutboats

withoutboats commented Feb 20, 2018

Copy link
Copy Markdown
ContributorAuthor

Changed the comment to not close the tracking issue, this can be a good first step.

@Manishearth

Manishearth commented Feb 20, 2018

Copy link
Copy Markdown
Member

@bors r+

A simple slightly-hacky way to do this would be to simply treat it as a different name when parsing lint group names.

@bors

bors commented Feb 20, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 6fe5f42 has been approved by Manishearth

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2018
sgrif
sgrif reviewed Feb 20, 2018
View reviewed changes
Comment threadsrc/test/ui/lint/lint-group-nonstandard-style.rs
mod bad {
fn CamelCase() {} //~ ERROR should have a snake

static bad: isize = 1; //~ ERROR should have an upper

@sgrifsgrifFeb 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a downer.

@kennytm

kennytm commented Feb 21, 2018

Copy link
Copy Markdown
Member

@bors r=Manishearth

@bors

bors commented Feb 21, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 5949d8b has been approved by Manishearth

@mark-i-m

mark-i-m commented Feb 22, 2018

Copy link
Copy Markdown
Contributor

Lol, why? I'm not sure I understand the motivation for this...

@steveklabnik

steveklabnik commented Feb 22, 2018

Copy link
Copy Markdown
Contributor

@mark-i-m#41646

@mark-i-m

mark-i-m commented Feb 22, 2018

Copy link
Copy Markdown
Contributor

Oh, it seems I missed quite an epic thread. It's good to know decisions like that are not made lightly, even though I don't fully agree with the change :)

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2018
@Manishearth
Rollup merge ofrust-lang#48386- withoutboats:nonstandard-style, r=M…
d45c4a6
…anishearth
Add nonstandard_style alias for bad_style.
@ManishearthManishearth mentioned this pull request Feb 24, 2018
Merged
bors added a commit that referenced this pull request Feb 25, 2018
@bors
Auto merge of#48520- Manishearth:rollup, r=Manishearth
026339e
Rollup of 15 pull requests
- Successful merges: #47689, #48110, #48197, #48296, #48386, #48392, #48404, #48415, #48441, #48448, #48452, #48481, #48490, #48499, #48503
- Failed merges:
@bors
bors merged commit 5949d8b into rust-lang:masterFeb 25, 2018
@ManishearthManishearth mentioned this pull request Aug 29, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sgrifsgrifsgrif left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ManishearthManishearth

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@withoutboats@rust-highfive@Manishearth@bors@kennytm@mark-i-m@steveklabnik@sgrif@nikomatsakis