Skip to content

Handle custom diagnostic for &str + String - #48392

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:string
Feb 25, 2018
Merged

Handle custom diagnostic for &str + String#48392
bors merged 1 commit into
rust-lang:masterfrom
estebank:string

Conversation

@estebank

@estebankestebank commented Feb 21, 2018

Copy link
Copy Markdown
Contributor

Now all of &str + &str, &str + String and String + String have relevant diagnostic output.

@rust-highfive

rust-highfive commented Feb 21, 2018

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2018
@petrochenkov

petrochenkov commented Feb 21, 2018

Copy link
Copy Markdown
Contributor

Sigh, I'd rather make them all legal (as far as coherence allow it).
@bors r+

@bors

bors commented Feb 21, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 20bc72e has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2018
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2018
@Manishearth
Rollup merge ofrust-lang#48392- estebank:string, r=petrochenkov
7738eb4
Handle custom diagnostic for `&str + String`
Now all of `&str + &str`, `&str + String` and `String + String` have relevant diagnostic output.
@ManishearthManishearth mentioned this pull request Feb 24, 2018
Merged
bors added a commit that referenced this pull request Feb 25, 2018
@bors
Auto merge of#48520- Manishearth:rollup, r=Manishearth
026339e
Rollup of 15 pull requests
- Successful merges: #47689, #48110, #48197, #48296, #48386, #48392, #48404, #48415, #48441, #48448, #48452, #48481, #48490, #48499, #48503
- Failed merges:
@bors
bors merged commit 20bc72e into rust-lang:masterFeb 25, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@estebank@rust-highfive@petrochenkov@bors