Skip to content

Stabilize [T]::rotate_{left,right} - #48450

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:frewsxcxv-stabilize-slice-rotatee
Feb 28, 2018
Merged

Stabilize [T]::rotate_{left,right}#48450
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:frewsxcxv-stabilize-slice-rotatee

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Feb 23, 2018

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Feb 23, 2018

Copy link
Copy Markdown
Contributor

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2018
@frewsxcvfrewsxcv mentioned this pull request Feb 23, 2018
Closed
@frewsxcv

frewsxcv commented Feb 23, 2018

Copy link
Copy Markdown
ContributorAuthor

r? @rust-lang/libs

scottmcm
scottmcm reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/liballoc/slice.rs Outdated

@scottmcmscottmcmFeb 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be since = "1.26.0", not issue?

@frewsxcvfrewsxcvFeb 23, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! good catch

@frewsxcv
frewsxcvforce-pushed the frewsxcxv-stabilize-slice-rotatee branch from da0fc93 to b1a6c8bCompareFebruary 23, 2018 01:12
@frewsxcvfrewsxcv added the T-libs-api [DEPRECATED; DO NOT USE] label Feb 23, 2018
@alexcrichton

alexcrichton commented Feb 24, 2018

Copy link
Copy Markdown
Member

Despite having only been added very recently (the rotate_{left,right} methods) we've had a method rotate for quite some time now. I think that the left/right-taking name seems much better and would be comfortable stabilizing this even though these specific apis only landed recently. Curious what others think tough!

@rfcbot fcp merge

@rfcbot

rfcbot commented Feb 24, 2018•
edited by sfackler
Loading

Copy link
Copy Markdown

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbotrfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Feb 24, 2018
@sfackler

sfackler commented Feb 26, 2018

Copy link
Copy Markdown
Member

Yep, I'm happy with the left/right rename.

@rfcbot

rfcbot commented Feb 26, 2018

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbotrfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 26, 2018
@alexcrichton

alexcrichton commented Feb 26, 2018

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Feb 26, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit b1a6c8b has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018
@alexcrichtonalexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 26, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 27, 2018
@kennytm
Rollup merge ofrust-lang#48450- frewsxcv:frewsxcxv-stabilize-slice-…
b106016
…rotatee, r=alexcrichton
Stabilize [T]::rotate_{left,right}
rust-lang#41891
@kennytmkennytm mentioned this pull request Feb 27, 2018
Closed
@alexcrichton

alexcrichton commented Feb 27, 2018

Copy link
Copy Markdown
Member

@bors: rollup

@kennytmkennytm mentioned this pull request Feb 27, 2018
Closed
kennytm added a commit to kennytm/compiletest-rs that referenced this pull request Feb 27, 2018
@kennytm
Call rotate_left instead of rotate.
aede9af
The `rotate` method has been deprecated in favor of `rotate_left` and `rotate_right` since rust-lang/rust#46777, and will be deleted in rust-lang/rust#48450.
@kennytmkennytm mentioned this pull request Feb 27, 2018
Merged
laumann pushed a commit to Manishearth/compiletest-rs that referenced this pull request Feb 27, 2018
@kennytmThomas Bracht Laumann Jespersen
Call rotate_left instead of rotate.
5c48e01
The `rotate` method has been deprecated in favor of `rotate_left` and `rotate_right` since rust-lang/rust#46777, and will be deleted in rust-lang/rust#48450.
kennytm added a commit to kennytm/rust that referenced this pull request Feb 28, 2018
@kennytm
Rollup merge ofrust-lang#48450- frewsxcv:frewsxcxv-stabilize-slice-…
ef44e63
…rotatee, r=alexcrichton
Stabilize [T]::rotate_{left,right}
rust-lang#41891
@kennytmkennytm mentioned this pull request Feb 28, 2018
Merged
bors added a commit that referenced this pull request Feb 28, 2018
@bors
Auto merge of#48608- kennytm:rollup, r=kennytm
0ff9872
Rollup of 15 pull requests
- Successful merges: #48266, #48321, #48365, #48381, #48450, #48473, #48479, #48484, #48488, #48497, #48541, #48548, #48558, #48560, #48565
- Failed merges:
@bors
bors merged commit b1a6c8b into rust-lang:masterFeb 28, 2018
@frewsxcv
frewsxcv deleted the frewsxcxv-stabilize-slice-rotatee branch February 28, 2018 15:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottmcmscottmcmscottmcm approved these changes

Assignees

No one assigned

Labels

final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@frewsxcv@rust-highfive@alexcrichton@rfcbot@sfackler@bors@scottmcm@withoutboats