Uh oh!
There was an error while loading. Please reload this page.
Handle gdb command failure gracefully in compiletest - #48488
Merged
Conversation
Previously, if the gdb command was available, but threw an error, compiletest would panic. This is obviously not good. Now, gdb is treated as missing if calling `gdb --version` does not output anything on stdout.
rust-highfive
commented
Feb 23, 2018
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
michaelwoerister
commented
Feb 26, 2018
Member
bors
commented
Feb 26, 2018
Collaborator
📌 Commit 70db41c has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Feb 27, 2018
…, r=michaelwoerister Handle gdb command failure gracefully in compiletest Previously, if the gdb command was available, but threw an error, compiletest would panic. This is obviously not good. Now, gdb is treated as missing if calling `gdb --version` does not output anything on stdout.
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Feb 28, 2018
…, r=michaelwoerister Handle gdb command failure gracefully in compiletest Previously, if the gdb command was available, but threw an error, compiletest would panic. This is obviously not good. Now, gdb is treated as missing if calling `gdb --version` does not output anything on stdout.
bors added a commit
that referenced
this pull request
Feb 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the gdb command was available, but threw an error, compiletest would panic. This is obviously not good. Now, gdb is treated as missing if calling
gdb --versiondoes not output anything on stdout.