Clarify interfaction between File::set_len and file cursor by jethrogb · Pull Request #48480 · rust-lang/rust

jethrogb · 2018-02-23T20:17:56Z

No description provided.

rust-highfive · 2018-02-23T20:18:01Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @bluss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

retep998 · 2018-02-24T02:38:38Z

Has this behavior been verified on both Linux and Windows?

jethrogb · 2018-02-24T02:44:20Z

I did look at the documentation of SetFileInformationByHandle but it isn't clear about how setting FileEndOfFileInfo affects the file position.

shepmaster · 2018-03-02T23:02:39Z

Ping from triage, @bluss!

retep998 · 2018-03-03T03:47:34Z

Confirmed with local testing on Windows that changing the length of the file does not update the cursor, even when it causes the cursor to be past the end.

emilyalbini · 2018-03-12T10:44:15Z

Ping from triage! This PR has yet to be reviewed, can someone from @rust-lang/libs do it?

alexcrichton · 2018-03-12T13:57:48Z

@bors: r+

bors · 2018-03-12T13:57:49Z

📌 Commit cfad25e has been approved by alexcrichton

bors · 2018-03-12T15:52:35Z

⌛ Testing commit cfad25e with merge 327f43edf82d38752a076ea97c7930471e7cfa1f...

kennytm · 2018-03-12T16:53:47Z

@bors rollup

bors · 2018-03-12T18:53:25Z

💔 Test failed - status-appveyor

kennytm · 2018-03-12T19:11:30Z

@bors retry #46903.

52 minutes to compile stage1-rustc, which is ridiculous.

Timing breakdown

make-prepare 76.97
stage0-tidy 91.38
bootstrap 20.30
stage0-rustc 1783.10
llvm 986.29
stage0-trans-llvm 212.96
stage1-std 183.77
stage1-test 46.29
stage1-rustc 3124.49
stage1-trans-llvm 272.56
stage0-compiletest 207.94
test/ui 234.20
test/parse-fail 11.71
test/run-fail 48.28
test/run-pass-valgrind 7.56
test/mir-opt 48.77
test/codegen 7.99
test/codegen-units 6.70
test/incremental 43.56
test/ui-fulldeps 100.09
test/run-pass-fulldeps 667.10
test/run-fail-fulldeps 10.65
test/compile-fail-fulldeps 198.52
test/incremental-fulldeps 5.77
stage2-rustdoc 392.27
test/rustdoc 236.26
test/run-make 140.30
stage1-test-term 11.54
test/libtest 16.37
stage1-test-test 21.34
test/libtest 25.23
stage1-test-alloc 126.45
test/libstd 288.66

/proc/cpuinfo of this build (Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHz)

[00:17:58] processor	: 0
[00:17:58] vendor_id	: GenuineIntel
[00:17:58] cpu family	: 6
[00:17:58] model : 63
[00:17:58] model name	: Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHz
[00:17:58] stepping	: 2
[00:17:58] cpu MHz : 2397.000
[00:17:58] cache size	: 256 KB
[00:17:58] physical id	: 0
[00:17:58] siblings	: 2
[00:17:58] core id : 0
[00:17:58] cpu cores	: 2
[00:17:58] apicid : 0
[00:17:58] initial apicid	: 0
[00:17:58] fpu : yes
[00:17:58] fpu_exception	: yes
[00:17:58] cpuid level	: 15
[00:17:58] wp : yes
[00:17:58] flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht pni ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave osxsave avx f16c rdrand hypervisor lahf_lm xsaveopt fsgsbase bmi1 avx2 smep bmi2 erms invpcid
[00:17:58] clflush size	: 64
[00:17:58] cache_alignment	: 64
[00:17:58] address sizes	: 44 bits physical, 48 bits virtual
[00:17:58] power management:
[00:17:58] [00:17:58] processor	: 1
[00:17:58] vendor_id	: GenuineIntel
[00:17:58] cpu family	: 6
[00:17:58] model : 63
[00:17:58] model name	: Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHz
[00:17:58] stepping	: 2
[00:17:58] cpu MHz : 2397.000
[00:17:58] cache size	: 256 KB
[00:17:58] physical id	: 0
[00:17:58] siblings	: 2
[00:17:58] core id : 1
[00:17:58] cpu cores	: 2
[00:17:58] apicid : 1
[00:17:58] initial apicid	: 1
[00:17:58] fpu : yes
[00:17:58] fpu_exception	: yes
[00:17:58] cpuid level	: 15
[00:17:58] wp : yes
[00:17:58] flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht pni ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave osxsave avx f16c rdrand hypervisor lahf_lm xsaveopt fsgsbase bmi1 avx2 smep bmi2 erms invpcid
[00:17:58] clflush size	: 64
[00:17:58] cache_alignment	: 64
[00:17:58] address sizes	: 44 bits physical, 48 bits virtual
[00:17:58] power management:

/proc/cpuinfo of the previous build (Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz)

[00:13:24] processor	: 0
[00:13:24] vendor_id	: GenuineIntel
[00:13:24] cpu family	: 6
[00:13:24] model : 63
[00:13:24] model name	: Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz
[00:13:24] stepping	: 2
[00:13:24] cpu MHz : 2497.000
[00:13:24] cache size	: 256 KB
[00:13:24] physical id	: 0
[00:13:24] siblings	: 2
[00:13:24] core id : 0
[00:13:24] cpu cores	: 2
[00:13:24] apicid : 0
[00:13:24] initial apicid	: 0
[00:13:24] fpu : yes
[00:13:24] fpu_exception	: yes
[00:13:24] cpuid level	: 15
[00:13:24] wp : yes
[00:13:24] flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht pni ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave osxsave avx f16c rdrand hypervisor lahf_lm xsaveopt fsgsbase bmi1 avx2 smep bmi2 erms invpcid
[00:13:24] clflush size	: 64
[00:13:24] cache_alignment	: 64
[00:13:24] address sizes	: 44 bits physical, 48 bits virtual
[00:13:24] power management:
[00:13:24] [00:13:24] processor	: 1
[00:13:24] vendor_id	: GenuineIntel
[00:13:24] cpu family	: 6
[00:13:24] model : 63
[00:13:24] model name	: Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz
[00:13:24] stepping	: 2
[00:13:24] cpu MHz : 2497.000
[00:13:24] cache size	: 256 KB
[00:13:24] physical id	: 0
[00:13:24] siblings	: 2
[00:13:24] core id : 1
[00:13:24] cpu cores	: 2
[00:13:24] apicid : 1
[00:13:24] initial apicid	: 1
[00:13:24] fpu : yes
[00:13:24] fpu_exception	: yes
[00:13:24] cpuid level	: 15
[00:13:24] wp : yes
[00:13:24] flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht pni ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave osxsave avx f16c rdrand hypervisor lahf_lm xsaveopt fsgsbase bmi1 avx2 smep bmi2 erms invpcid
[00:13:24] clflush size	: 64
[00:13:24] cache_alignment	: 64
[00:13:24] address sizes	: 44 bits physical, 48 bits virtual
[00:13:24] power management:

/proc/meminfo of this build (1.8 GiB total)

[00:17:58] MemTotal: 1901592 kB
[00:17:58] MemFree: 848456 kB
[00:17:58] HighTotal: 0 kB
[00:17:58] HighFree: 0 kB
[00:17:58] LowTotal: 1901592 kB
[00:17:58] LowFree: 848456 kB
[00:17:58] SwapTotal: 458752 kB
[00:17:58] SwapFree: 413320 kB

/proc/meminfo of previous build (1.7 GiB total)

[00:13:24] MemTotal: 1764376 kB
[00:13:24] MemFree: 627900 kB
[00:13:24] HighTotal: 0 kB
[00:13:24] HighFree: 0 kB
[00:13:24] LowTotal: 1764376 kB
[00:13:24] LowFree: 627900 kB
[00:13:24] SwapTotal: 458752 kB
[00:13:24] SwapFree: 396692 kB

Clarify interfaction between File::set_len and file cursor

Rollup of 13 pull requests - Successful merges: #48201, #48705, #48725, #48824, #48877, #48880, #48887, #48928, #48934, #48480, #48631, #48898, #48954 - Failed merges:

Clarify interfaction between File::set_len and file cursor
cfad25e

rust-highfive assigned bluss Feb 23, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2018

bors mentioned this pull request Mar 12, 2018
introduce canonical queries, use for normalization and dropck-outlives #48411
Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2018

This was referenced Mar 12, 2018
Collect CPU utilization statistics of CI builders #48828
Closed
Rollup of 13 pull requests #48955
Merged

kennytm added a commit to kennytm/rust that referenced this pull request Mar 12, 2018
Rollup merge ofrust-lang#48480- jethrogb:patch-5, r=alexcrichton
684c6d1
Clarify interfaction between File::set_len and file cursor

bors added a commit that referenced this pull request Mar 12, 2018
Auto merge of#48955- kennytm:rollup, r=kennytm
c7cbe14
Rollup of 13 pull requests - Successful merges: #48201, #48705, #48725, #48824, #48877, #48880, #48887, #48928, #48934, #48480, #48631, #48898, #48954 - Failed merges:

bors merged commit cfad25e into rust-lang:masterMar 13, 2018

Navigation Menu

Uh oh!

Uh oh!

Clarify interfaction between File::set_len and file cursor - #48480

Clarify interfaction between File::set_len and file cursor#48480
bors merged 1 commit into
rust-lang:masterfrom
jethrogb:patch-5

jethrogb commented Feb 23, 2018

Uh oh!

rust-highfive commented Feb 23, 2018

Uh oh!

retep998 commented Feb 24, 2018

Uh oh!

jethrogb commented Feb 24, 2018

Uh oh!

shepmaster commented Mar 2, 2018

Uh oh!

retep998 commented Mar 3, 2018

Uh oh!

emilyalbini commented Mar 12, 2018

Uh oh!

alexcrichton commented Mar 12, 2018

Uh oh!

bors commented Mar 12, 2018

Uh oh!

bors commented Mar 12, 2018

Uh oh!

kennytm commented Mar 12, 2018

Uh oh!

bors commented Mar 12, 2018

Uh oh!

kennytm commented Mar 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Uh oh!

Conversation

jethrogb commented Feb 23, 2018

Uh oh!

rust-highfive commented Feb 23, 2018

Uh oh!

retep998 commented Feb 24, 2018

Uh oh!

jethrogb commented Feb 24, 2018

Uh oh!

shepmaster commented Mar 2, 2018

Uh oh!

retep998 commented Mar 3, 2018

Uh oh!

emilyalbini commented Mar 12, 2018

Uh oh!

alexcrichton commented Mar 12, 2018

Uh oh!

bors commented Mar 12, 2018

Uh oh!

bors commented Mar 12, 2018

Uh oh!

kennytm commented Mar 12, 2018

Uh oh!

bors commented Mar 12, 2018

Uh oh!

kennytm commented Mar 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants