Skip to content

Update L4Re target specification - #48725

Merged
bors merged 2 commits into
rust-lang:masterfrom
humenda:master
Mar 13, 2018
Merged

Update L4Re target specification#48725
bors merged 2 commits into
rust-lang:masterfrom
humenda:master

Conversation

@humenda

@humendahumenda commented Mar 4, 2018

Copy link
Copy Markdown
Contributor

Due to the dynamically generated linker arguments of the L4Re build system, it is not a good idea to hard-code them in Rust. This PR undoes this step. It also adds an empty implementation to retrieve the number of CPUs.

@rust-highfive

rust-highfive commented Mar 4, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@emilyalbiniemilyalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2018
@nikomatsakis

nikomatsakis commented Mar 5, 2018

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 5, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 75e9e71 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2018
@nikomatsakis

nikomatsakis commented Mar 5, 2018

Copy link
Copy Markdown
Contributor

@bors r-

tidy failures

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2018
@humenda
remove linker arguments from L4Re target
9334175
These change from release to release and are impossible to get right,
since they are generated by Make magic.
@humenda
add stub for retrieving number of CPUs
9fd941e
@humenda

humenda commented Mar 11, 2018 via email

Copy link
Copy Markdown
ContributorAuthor

@nikomatsakis

nikomatsakis commented Mar 12, 2018

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 12, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 9fd941e has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 12, 2018
@kennytm
Rollup merge ofrust-lang#48725- humenda:master, r=nikomatsakis
f84cab4
Update L4Re target specification
Due to the dynamically generated linker arguments of the L4Re build system, it is not a good idea to hard-code them in Rust. This PR undoes this step. It also adds an empty implementation to retrieve the number of CPUs.
@kennytmkennytm mentioned this pull request Mar 12, 2018
Merged
bors added a commit that referenced this pull request Mar 12, 2018
@bors
Auto merge of#48955- kennytm:rollup, r=kennytm
c7cbe14
Rollup of 13 pull requests
- Successful merges: #48201, #48705, #48725, #48824, #48877, #48880, #48887, #48928, #48934, #48480, #48631, #48898, #48954
- Failed merges:
@bors
bors merged commit 9fd941e into rust-lang:masterMar 13, 2018
@davidtwcodavidtwco mentioned this pull request Sep 20, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@humenda@rust-highfive@nikomatsakis@bors@emilyalbini