Skip to content

Use an uninitialized buffer in GenericRadix::fmt_int, like in Display::fmt for numeric types - #49103

Merged
bors merged 1 commit into
rust-lang:masterfrom
glandium:uninitialized
Mar 26, 2018
Merged

Use an uninitialized buffer in GenericRadix::fmt_int, like in Display::fmt for numeric types#49103
bors merged 1 commit into
rust-lang:masterfrom
glandium:uninitialized

Conversation

@glandium

@glandiumglandium commented Mar 17, 2018•
edited by shepmaster
Loading

Copy link
Copy Markdown
Contributor

The code using a slice of that buffer is only ever going to use
bytes that are subsequently initialized.

@glandium
Use an uninitialized buffer in GenericRadix::fmt_int, like in Display…
38cbdcd
…::fmt for numeric types
The code using a slice of that buffer is only ever going to use
bytes that are subsequently initialized.
@rust-highfive

rust-highfive commented Mar 17, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2018
@shepmastershepmaster changed the title Use an uninitialized buffer in GenericRadix::fmt_int, like in Display…Use an uninitialized buffer in GenericRadix::fmt_int, like in Display::fmt for numeric typesMar 23, 2018
@shepmaster

shepmaster commented Mar 23, 2018

Copy link
Copy Markdown
Member

As a drive-by comment, have you performed any profiling to see that this change has any benefit?

@shepmastershepmaster added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 23, 2018
@shepmaster

shepmaster commented Mar 23, 2018

Copy link
Copy Markdown
Member

Ping from triage, @cramertj — will you have time to review this soon?

@cramertj

cramertj commented Mar 25, 2018

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Mar 25, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 38cbdcd has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 26, 2018
@kennytm
Rollup merge ofrust-lang#49103- glandium:uninitialized, r=cramertj
abd08d9
Use an uninitialized buffer in GenericRadix::fmt_int, like in Display::fmt for numeric types
The code using a slice of that buffer is only ever going to use
bytes that are subsequently initialized.
@kennytmkennytm mentioned this pull request Mar 26, 2018
Closed
TimNN added a commit to TimNN/rust that referenced this pull request Mar 26, 2018
@TimNN
Rollup merge ofrust-lang#49103- glandium:uninitialized, r=cramertj
fc9dfda
Use an uninitialized buffer in GenericRadix::fmt_int, like in Display::fmt for numeric types
The code using a slice of that buffer is only ever going to use
bytes that are subsequently initialized.
@TimNNTimNN mentioned this pull request Mar 26, 2018
Merged
bors added a commit that referenced this pull request Mar 26, 2018
@bors
Auto merge of#49379- TimNN:rollup, r=TimNN
ab8b961
Rollup of 7 pull requests
- Successful merges: #48693, #48932, #49103, #49170, #49187, #49346, #49353
- Failed merges:
@bors
bors merged commit 38cbdcd into rust-lang:masterMar 26, 2018
@glandium

glandium commented Mar 26, 2018

Copy link
Copy Markdown
ContributorAuthor

As a drive-by comment, have you performed any profiling to see that this change has any benefit?

FWIW, it didn't make a significant difference in my use cases, but I suspect it can for some embedded platforms.

@glandium
glandium deleted the uninitialized branch March 26, 2018 23:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cramertjcramertj

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@glandium@rust-highfive@shepmaster@cramertj@bors