Skip to content

Implement get_key_value for HashMap, BTreeMap - #49346

Merged
bors merged 1 commit into
rust-lang:masterfrom
Diggsey:hashmap-get-pair
Mar 26, 2018
Merged

Implement get_key_value for HashMap, BTreeMap#49346
bors merged 1 commit into
rust-lang:masterfrom
Diggsey:hashmap-get-pair

Conversation

@Diggsey

@DiggseyDiggsey commented Mar 24, 2018

Copy link
Copy Markdown
Contributor

Fixes#43143

Follow up from #46992

@rust-highfive

rust-highfive commented Mar 24, 2018

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2018
@DiggseyDiggsey mentioned this pull request Mar 24, 2018
Closed
Mark-Simulacrum
Mark-Simulacrum reviewed Mar 25, 2018
View reviewed changes
Comment threadsrc/liballoc/btree/map.rs Outdated

@Mark-SimulacrumMark-SimulacrumMar 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, it returns a pair which consists of references to the key and value - not sure if that's an important distinction, but we should remove " a " since it's not grammatically correct I think.

@DiggseyDiggseyMar 25, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - removed the part about references as that's included in the type signature anyway.

@Diggsey
Diggseyforce-pushed the hashmap-get-pair branch 3 times, most recently from 799af44 to 1434e26CompareMarch 25, 2018 03:03
Mark-Simulacrum
Mark-Simulacrum requested changes Mar 25, 2018
View reviewed changes

@Mark-SimulacrumMark-Simulacrum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we unmark these as #[inline]? Unless there's some reason to do so I'd prefer to avoid it. Otherwise r=me.

@Diggsey

Diggsey commented Mar 25, 2018

Copy link
Copy Markdown
ContributorAuthor

Removed

@bors r=Mark-Simulacrum

@bors

bors commented Mar 25, 2018

Copy link
Copy Markdown
Collaborator

@Diggsey: 🔑 Insufficient privileges: Not in reviewers

@Mark-Simulacrum

Mark-Simulacrum commented Mar 25, 2018

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Mar 25, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit fbec3ec has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 26, 2018
@kennytm
Rollup merge ofrust-lang#49346- Diggsey:hashmap-get-pair, r=Mark-Si…
ca521d3
…mulacrum
Implement get_key_value for HashMap, BTreeMap
Fixesrust-lang#43143
Follow up from rust-lang#46992
@kennytmkennytm mentioned this pull request Mar 26, 2018
Closed
TimNN added a commit to TimNN/rust that referenced this pull request Mar 26, 2018
@TimNN
Rollup merge ofrust-lang#49346- Diggsey:hashmap-get-pair, r=Mark-Si…
d601e74
…mulacrum
Implement get_key_value for HashMap, BTreeMap
Fixesrust-lang#43143
Follow up from rust-lang#46992
@TimNNTimNN mentioned this pull request Mar 26, 2018
Merged
bors added a commit that referenced this pull request Mar 26, 2018
@bors
Auto merge of#49379- TimNN:rollup, r=TimNN
ab8b961
Rollup of 7 pull requests
- Successful merges: #48693, #48932, #49103, #49170, #49187, #49346, #49353
- Failed merges:
@bors
bors merged commit fbec3ec into rust-lang:masterMar 26, 2018
@nnethercotennethercote mentioned this pull request Nov 13, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum requested changes

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Diggsey@rust-highfive@bors@Mark-Simulacrum