Introduce trait engine by csmoe · Pull Request #49202 · rust-lang/rust

csmoe · 2018-03-20T10:02:33Z

address #48895 step 1: introduce trait engine

rust-highfive · 2018-03-20T10:02:45Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

nikomatsakis · 2018-03-20T17:14:53Z

This needs to be:
impl<'a, 'gcx, 'tcx> dyn TraitEngine<'tcx> + 'tcx { .. }
Whenever you create a trait object type dyn Trait, if that trait object may close over references, then the lifetime of those references needs to be part of its bound. In this case, FulfillmentContext closes over data of type with lifetime 'tcx, so we need dyn TraitEngine<'tcx> + 'tcx.

nikomatsakis · 2018-03-22T09:15:22Z

Travis is grumpy.

nikomatsakis · 2018-03-22T09:16:47Z

This needs to be Box<Self> or Box<dyn TraitEngine<'tcx> +'tcx>
Here, Self = dyn TraitEngine<'tcx> + tcx (that is a single type). It might be mildly clearer formatted like so dyn (TraitEngine<'tcx> + tcx). That is, it is a dynamic type (not statically known) that implements TraitEngine<'tcx> and which outlives 'tcx (i.e., meets the bound TraitEngine<'tcx> + 'tcx).

csmoe · 2018-03-22T12:12:29Z

@nikomatsakis
Box<Self> or dyn TraitEngine<'tcx> + 'tcx works in librustc/traits indeed(you had suggested me to this on gitter about a week ago), but when introduce TraitiEngine into type_ck, compiler keeps complaining lifetime mismatching:

error[E0495]: cannot infer an appropriate lifetime for lifetime parameter `'gcx` due to conflicting requirements [62/861]
--> librustc_typeck/check/mod.rs:629:17
|
629 | tcx.mk_region(ty::ReScope(region::Scope::CallSite(body.value.hir_id.local_id)))
| ^^^^^^^^^
|
note: first, the lifetime cannot outlive the lifetime 'gcx as defined on the impl at 622:1...
--> librustc_typeck/check/mod.rs:622:1
|
622 | impl<'a, 'gcx, 'tcx> Inherited<'a, 'gcx, 'tcx> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: ...so that the types are compatible:
expected rustc::ty::TyCtxt<'_, '_, '_>
found rustc::ty::TyCtxt<'_, 'gcx, 'tcx>
= note: but, the lifetime must be valid for the static lifetime...
= note: ...so that the expression is assignable:
expected std::boxed::Box<rustc::traits::TraitEngine<'_> + 'static>
found std::boxed::Box<rustc::traits::TraitEngine<'_>>
error[E0495]: cannot infer an appropriate lifetime for lifetime parameter `'a` due to conflicting requirements
--> librustc_typeck/coherence/builtin.rs:211:9
|
211 | tcx.infer_ctxt().enter(|infcx| {
| ^^^^^^^^^^
|
note: first, the lifetime cannot outlive the lifetime 'a as defined on the function body at 175:1...
--> librustc_typeck/coherence/builtin.rs:175:1
|
175 | / pub fn coerce_unsized_info<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>,
176 | | impl_did: DefId)
177 | | -> CoerceUnsizedInfo {
178 | | debug!("compute_coerce_unsized_info(impl_did={:?})", impl_did); [31/861]
... |
404 | | })
405 | | }
| |_^
= note: ...so that the types are compatible:
expected rustc::ty::TyCtxt<'_, '_, '_>
found rustc::ty::TyCtxt<'a, 'tcx, 'tcx>
note: but, the lifetime must be valid for the anonymous lifetime #2 defined on the body at 211:28...
--> librustc_typeck/coherence/builtin.rs:211:28
|
211 | tcx.infer_ctxt().enter(|infcx| {
| ____________________________^
212 | | let cause = ObligationCause::misc(span, impl_node_id);
213 | | let check_mutbl = |mt_a: ty::TypeAndMut<'tcx>,
214 | | mt_b: ty::TypeAndMut<'tcx>,
... |
403 | | }
404 | | })
| |_____^
note: ...so that the declared lifetime parameter bounds are satisfied
--> librustc_typeck/coherence/builtin.rs:228:17
|
228 | check_mutbl(mt_a, mt_b, &|ty| tcx.mk_imm_ref(r_b, ty))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The main code modification was already done a week ago, but I have been being trapped here. I have tried many ways to resolve the lifetime, but they never works.

nikomatsakis · 2018-03-22T16:24:23Z

@csmoe ok that was trickier than I thought :) I pushed various commits. cargo check, at least, passes for me locally.

nikomatsakis · 2018-03-22T16:24:34Z

Let's see what travis thinks.

bors · 2018-03-22T20:04:06Z

☔ The latest upstream changes (presumably #49264) made this pull request unmergeable. Please resolve the merge conflicts.

This way, we don't have to repeat it.

The use of tcx/gcx in this function is subtle.

This helps to make clear where *global* lifetimes are needed in `coerce_unsized_info`

nikomatsakis · 2018-03-26T15:17:57Z

@bors r+

bors · 2018-03-26T15:17:58Z

📌 Commit 39712e5 has been approved by nikomatsakis

nikomatsakis · 2018-03-26T15:18:05Z

Sorry for the delay, was waiting until travis was happy =)

bors · 2018-03-27T01:45:18Z

⌛ Testing commit 39712e5 with merge 6b50e0fc7ac915609d9821865cb191aea128e9ac...

bors · 2018-03-27T04:46:29Z

💔 Test failed - status-travis

kennytm · 2018-03-27T07:51:49Z

@bors retry

3 hour time-out in x86_64-gnu-incremental.

Details

[00:03:49] [TIMING] Std { target: "x86_64-unknown-linux-gnu", compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" } } -- 67.446
[00:05:01] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "tidy", path: "src/tools/tidy", mode: Libstd, is_ext_tool: false, extra_features: [] } -- 71.658
[00:05:04] [TIMING] Tidy -- 2.874
[00:05:06] [TIMING] Std { target: "x86_64-unknown-linux-gnu", compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" } } -- 0.595
[00:05:18] [TIMING] Test { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 12.772
[00:19:34] [TIMING] Rustc { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 855.453
[00:24:54] [TIMING] Llvm { target: "x86_64-unknown-linux-gnu", emscripten: false } -- 320.624
[00:26:04] [TIMING] CodegenBackend { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", backend: "llvm" } -- 69.884
[00:31:20] [TIMING] Std { target: "x86_64-unknown-linux-gnu", compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" } } -- 315.508
[00:31:49] [TIMING] Test { compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 29.295
[01:08:27] [TIMING] Rustc { compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 2197.821
[01:11:01] [TIMING] CodegenBackend { compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", backend: "llvm" } -- 153.982
[01:14:44] [TIMING] Rustdoc { host: "x86_64-unknown-linux-gnu" } -- 223.521
[01:14:46] [TIMING] Std { target: "x86_64-unknown-linux-gnu", compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" } } -- 0.540
[01:14:47] [TIMING] Test { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 0.510
[01:14:48] [TIMING] Rustc { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 0.553
[01:14:48] [TIMING] CodegenBackend { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", backend: "llvm" } -- 0.543
[01:14:48] [TIMING] Std { target: "x86_64-unknown-linux-gnu", compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" } } -- 0.419
[01:14:49] [TIMING] Test { compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 0.337
[01:14:49] [TIMING] Rustc { compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 0.381
[01:14:50] [TIMING] CodegenBackend { compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", backend: "llvm" } -- 0.394
[01:16:02] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "unstable-book-gen", path: "src/tools/unstable-book-gen", mode: Libstd, is_ext_tool: false, extra_features: [] } -- 72.478
[01:16:03] [TIMING] UnstableBookGen { target: "x86_64-unknown-linux-gnu" } -- 0.511
[01:18:12] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "rustbook", path: "src/tools/rustbook", mode: Librustc, is_ext_tool: false, extra_features: [] } -- 129.785
[01:18:15] [TIMING] RustbookSrc { target: "x86_64-unknown-linux-gnu", name: "unstable-book", src: "/checkout/obj/build/x86_64-unknown-linux-gnu/md-doc" } -- 2.690
[01:18:16] [TIMING] RustbookSrc { target: "x86_64-unknown-linux-gnu", name: "book/first-edition", src: "/checkout/src/doc" } -- 0.592
[01:18:17] [TIMING] RustbookSrc { target: "x86_64-unknown-linux-gnu", name: "book/second-edition", src: "/checkout/src/doc" } -- 1.102
[01:18:17] [TIMING] Rustdoc { host: "x86_64-unknown-linux-gnu" } -- 0.373
[01:18:18] [TIMING] Standalone { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 0.461
[01:18:19] [TIMING] TheBook { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", name: "book" } -- 1.148
[01:23:03] [TIMING] Std { stage: 2, target: "x86_64-unknown-linux-gnu" } -- 283.958
[01:25:20] [TIMING] WhitelistedRustc { stage: 2, target: "x86_64-unknown-linux-gnu" } -- 137.121
[01:25:26] [TIMING] ToolBuild { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "error_index_generator", path: "src/tools/error_index_generator", mode: Librustc, is_ext_tool: false, extra_features: [] } -- 6.457
[01:25:26] [TIMING] ErrorIndex { target: "x86_64-unknown-linux-gnu" } -- 0.118
[01:25:27] [TIMING] RustbookSrc { target: "x86_64-unknown-linux-gnu", name: "nomicon", src: "/checkout/src/doc" } -- 0.366
[01:25:27] [TIMING] RustbookSrc { target: "x86_64-unknown-linux-gnu", name: "reference", src: "/checkout/src/doc" } -- 0.480
[01:25:29] [TIMING] RustbookSrc { target: "x86_64-unknown-linux-gnu", name: "rust-by-example", src: "/checkout/src/doc" } -- 1.612
[01:25:29] [TIMING] CargoBook { target: "x86_64-unknown-linux-gnu", name: "cargo" } -- 0.161
[01:25:31] [TIMING] Std { target: "x86_64-unknown-linux-gnu", compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" } } -- 0.553
[01:25:37] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "tidy", path: "src/tools/tidy", mode: Libstd, is_ext_tool: false, extra_features: [] } -- 6.013
[01:25:40] [TIMING] Tidy -- 2.749
[01:25:48] [TIMING] Bootstrap -- 8.602
[01:25:49] [TIMING] Test { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 0.563
[01:25:50] [TIMING] Rustc { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 0.614
[01:25:50] [TIMING] CodegenBackend { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", backend: "llvm" } -- 0.573
[01:25:51] [TIMING] Std { target: "x86_64-unknown-linux-gnu", compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" } } -- 0.432
[01:25:51] [TIMING] Test { compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 0.343
[01:25:51] [TIMING] Rustc { compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 0.391
[01:25:52] [TIMING] CodegenBackend { compiler: Compiler { stage: 1, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", backend: "llvm" } -- 0.399
[01:26:13] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "compiletest", path: "src/tools/compiletest", mode: Libtest, is_ext_tool: false, extra_features: [] } -- 21.438
[01:28:01] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "ui", suite: "ui" } -- 107.989
[01:46:59] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "run-pass", suite: "run-pass" } -- 1138.145
[01:51:35] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "compile-fail", suite: "compile-fail" } -- 275.421
[01:51:41] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "parse-fail", suite: "parse-fail" } -- 6.342
[01:52:05] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "run-fail", suite: "run-fail" } -- 24.049
[01:52:10] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "run-pass-valgrind", suite: "run-pass-valgrind" } -- 5.299
[01:52:39] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "mir-opt", suite: "mir-opt" } -- 28.143
[01:52:47] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "codegen", suite: "codegen" } -- 8.242
[01:52:51] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "codegen-units", suite: "codegen-units" } -- 4.561
[01:53:27] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "incremental", suite: "incremental" } -- 36.072
[01:53:47] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "debuginfo-gdb", suite: "debuginfo" } -- 19.985
[01:54:20] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "ui", suite: "ui-fulldeps" } -- 32.440
[02:04:15] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "run-pass", suite: "run-pass-fulldeps" } -- 595.359
[02:04:22] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "run-fail", suite: "run-fail-fulldeps" } -- 6.565
[02:06:31] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "compile-fail", suite: "compile-fail-fulldeps" } -- 129.629
[02:06:36] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "incremental", suite: "incremental-fulldeps" } -- 5.004
[02:06:37] [TIMING] Rustdoc { host: "x86_64-unknown-linux-gnu" } -- 0.367
[02:11:53] [TIMING] Compiletest { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: "rustdoc", suite: "rustdoc" } -- 316.133
[02:12:01] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Libtest, test_kind: Test, krate: "term" } -- 8.029
[02:12:21] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Libtest, test_kind: Test, krate: "test" } -- 19.788
[02:17:25] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Libstd, test_kind: Test, krate: "alloc" } -- 304.094
[02:17:25] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Libstd, test_kind: Test, krate: "alloc_system" } -- 0.541
[02:26:36] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Libstd, test_kind: Test, krate: "core" } -- 550.298
[02:26:36] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Libstd, test_kind: Test, krate: "panic_abort" } -- 0.548
[02:34:52] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Libstd, test_kind: Test, krate: "std" } -- 495.874
[02:35:07] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Libstd, test_kind: Test, krate: "std_unicode" } -- 15.048
[02:35:08] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Libstd, test_kind: Test, krate: "unwind" } -- 0.506
[02:35:12] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "arena" } -- 4.688
[02:35:16] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "fmt_macros" } -- 3.466
[02:35:21] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "graphviz" } -- 5.013
[02:35:25] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "proc_macro" } -- 3.774
[02:43:47] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc" } -- 502.705
[02:43:48] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_allocator" } -- 0.392
[02:44:28] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_apfloat" } -- 40.105
[02:44:57] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_back" } -- 29.124
[02:44:57] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_borrowck" } -- 0.371
[02:45:01] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_const_math" } -- 3.180
[02:45:41] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_data_structures" } -- 40.342
[02:47:15] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_driver" } -- 93.595
[02:47:22] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_errors" } -- 7.718
[02:47:34] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_incremental" } -- 12.062
[02:47:35] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_lint" } -- 0.350
[02:47:55] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_metadata" } -- 20.675
[02:50:27] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_mir" } -- 151.767
[02:50:33] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_passes" } -- 5.492
[02:50:47] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_platform_intrinsics" } -- 14.652
[02:50:50] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_plugin" } -- 2.503
[02:50:55] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_privacy" } -- 4.753
[02:50:55] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_resolve" } -- 0.362
[02:51:05] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_save_analysis" } -- 10.618
[02:51:09] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_traits" } -- 4.002
[02:51:10] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_trans_utils" } -- 0.355
[02:51:10] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc_typeck" } -- 0.357
[02:52:02] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "serialize" } -- 51.681
[02:54:45] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "syntax" } -- 163.207
[02:55:01] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "syntax_ext" } -- 16.216
[02:55:11] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "syntax_pos" } -- 9.192
[02:55:12] [TIMING] Crate { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", mode: Librustc, test_kind: Test, krate: "rustc-main" } -- 1.786
[02:56:20] [TIMING] CrateRustdoc { host: "x86_64-unknown-linux-gnu", test_kind: Test } -- 67.556
[02:56:20] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "unstable-book-gen", path: "src/tools/unstable-book-gen", mode: Libstd, is_ext_tool: false, extra_features: [] } -- 0.527
[02:56:21] [TIMING] UnstableBookGen { target: "x86_64-unknown-linux-gnu" } -- 0.534
[02:56:21] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "rustbook", path: "src/tools/rustbook", mode: Librustc, is_ext_tool: false, extra_features: [] } -- 0.547
[02:56:24] [TIMING] RustbookSrc { target: "x86_64-unknown-linux-gnu", name: "unstable-book", src: "/checkout/obj/build/x86_64-unknown-linux-gnu/md-doc" } -- 2.678
[02:56:25] [TIMING] TheBook { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", name: "book" } -- 1.144
[02:56:26] [TIMING] Std { stage: 2, target: "x86_64-unknown-linux-gnu" } -- 1.133
[02:56:27] [TIMING] WhitelistedRustc { stage: 2, target: "x86_64-unknown-linux-gnu" } -- 0.645
[02:56:27] [TIMING] ToolBuild { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "error_index_generator", path: "src/tools/error_index_generator", mode: Librustc, is_ext_tool: false, extra_features: [] } -- 0.363
[02:56:28] [TIMING] ErrorIndex { target: "x86_64-unknown-linux-gnu" } -- 0.114
[02:56:28] [TIMING] CargoBook { target: "x86_64-unknown-linux-gnu", name: "cargo" } -- 0.155
[02:56:30] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "linkchecker", path: "src/tools/linkchecker", mode: Libstd, is_ext_tool: false, extra_features: [] } -- 2.734
[02:56:52] [TIMING] Linkcheck { host: "x86_64-unknown-linux-gnu" } -- 22.048
[02:57:40] [TIMING] ErrorIndex { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" } } -- 47.446

kennytm · 2018-03-27T08:46:56Z

@bors p=15

bors · 2018-03-27T09:36:12Z

⌛ Testing commit 39712e5 with merge 83bcdc9af15af7b689ceba0e1772e037dc546c85...

bors · 2018-03-27T09:44:20Z

💔 Test failed - status-travis

kennytm · 2018-03-27T10:28:58Z

@bors retry

Spuriously canceled ¿❓⸮❔😕?❓❔

bors · 2018-03-27T14:31:49Z

⌛ Testing commit 39712e5 with merge 9c9424d...

Introduce trait engine address #48895 step 1: introduce trait engine

bors · 2018-03-27T17:21:11Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 9c9424d to master...

Rollup of 11 pull requests - Successful merges: #48639, #49223, #49333, #49369, #49381, #49395, #49399, #49401, #49417, #49202, #49426 - Failed merges:

rust-highfive assigned nikomatsakis Mar 20, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 20, 2018

csmoe force-pushed the trait_engine branch 6 times, most recently from 3e8979d to d442a98Compare March 20, 2018 11:53

nikomatsakis mentioned this pull request Mar 20, 2018
🛠 introduce abstraction layer between trait solver and type checker #48895
Closed

nikomatsakis requested changes Mar 20, 2018
View reviewed changes

nikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018

csmoe force-pushed the trait_engine branch from d442a98 to c3f3902Compare March 22, 2018 03:28

nikomatsakis requested changes Mar 22, 2018
View reviewed changes

nikomatsakis approved these changes Mar 22, 2018
View reviewed changes

csmoe force-pushed the trait_engine branch from 7fc26f6 to aceae0dCompare March 23, 2018 01:19

csmoeand others added 7 commits March 23, 2018 09:21

introduce trait engine mod
20703b3

import trait engine to typeck
0c4062a

fix Self
7c2eb1c

apply rustfmt
012262c

move the defaut object lifetime bound into the trait
bad80fe
This way, we don't have to repeat it.

use infcx.tcx, so we get the local tcx
8179a4b
The use of tcx/gcx in this function is subtle.

rename 'tcx and tcx to 'gcx and gcx
39712e5
This helps to make clear where *global* lifetimes are needed in `coerce_unsized_info`

csmoe force-pushed the trait_engine branch from aceae0d to 39712e5Compare March 23, 2018 01:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 27, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 27, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2018

bors added a commit that referenced this pull request Mar 27, 2018
Auto merge of#49202- csmoe:trait_engine, r=nikomatsakis
9c9424d
Introduce trait engine address #48895 step 1: introduce trait engine

bors merged commit 39712e5 into rust-lang:masterMar 27, 2018

bors mentioned this pull request Mar 27, 2018
Small typeck refactorings #49419
Merged

kennytm mentioned this pull request Mar 27, 2018
Rollup of 11 pull requests #49406
Merged

bors added a commit that referenced this pull request Mar 27, 2018
Auto merge of#49406- kennytm:rollup, r=kennytm
35f368f
Rollup of 11 pull requests - Successful merges: #48639, #49223, #49333, #49369, #49381, #49395, #49399, #49401, #49417, #49202, #49426 - Failed merges:

bors added a commit that referenced this pull request Mar 28, 2018
Auto merge of#49406- kennytm:rollup, r=kennytm
59ec9bf
Rollup of 11 pull requests - Successful merges: #48639, #49223, #49333, #49369, #49381, #49395, #49399, #49401, #49417, #49202, #49426 - Failed merges:

Uh oh!

Uh oh!

Conversation

csmoe commented Mar 20, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Mar 20, 2018

Uh oh!

nikomatsakisMar 20, 2018

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Mar 22, 2018

Uh oh!

nikomatsakisMar 22, 2018

Choose a reason for hiding this comment

Uh oh!

csmoe commented Mar 22, 2018

Uh oh!

nikomatsakis commented Mar 22, 2018

Uh oh!

nikomatsakis commented Mar 22, 2018

Uh oh!

bors commented Mar 22, 2018

Uh oh!

nikomatsakis commented Mar 26, 2018

Uh oh!

bors commented Mar 26, 2018

Uh oh!

nikomatsakis commented Mar 26, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

kennytm commented Mar 27, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kennytm commented Mar 27, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

kennytm commented Mar 27, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

bors commented Mar 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

csmoe commented Mar 20, 2018•
edited
Loading

kennytm commented Mar 27, 2018•
edited
Loading