Uh oh!
There was an error while loading. Please reload this page.
Easy edition feature flag - #49252
Conversation
There was a problem hiding this comment.
Avoiding the anachronism of "preview" may be more valuable than keeping these names symmetrical?
There was a problem hiding this comment.
No, once a feature is added it can't be "removed" completely.
There's no way to use the rust_2015_preview feature, that feature exists only so that attempting to use it will throw a "feature removed" warning. This goes for the 2018_preview feature when you enable the 2018 epoch, as well.
Yes, we could just not do this for 2015, but it didn't seem worth it to special case 2015.
nikomatsakis
commented
Mar 23, 2018
Sorry @Manishearth, didn't get to this yesterday and may not today. I suck. As far as feature flags go, a preliminary list would be the features found here: though some of those are rapidly stabilizing. I can come around for a more complete list soon. |
bors
commented
Mar 23, 2018
☔ The latest upstream changes (presumably #49308) made this pull request unmergeable. Please resolve the merge conflicts. |
4dd01d5 to
b622870Compareb622870 to
45f9aabCompare45f9aab to
195c6b4CompareManishearth
commented
Mar 29, 2018
Done |
nikomatsakis
commented
Apr 2, 2018
@bors r+ |
bors
commented
Apr 2, 2018
📌 Commit 195c6b4 has been approved by |
bors
commented
Apr 2, 2018
Easy edition feature flag We no longer gate features on epochs; instead we have a `#![feature(rust_2018_preview)]` that flips on a bunch of features (currently dyn_trait). Based on #49001 to avoid merge conflicts r? @nikomatsakis
bors
commented
Apr 2, 2018
☀️ Test successful - status-appveyor, status-travis |
We no longer gate features on epochs; instead we have a
#![feature(rust_2018_preview)]that flips on a bunch of features (currently dyn_trait).Based on #49001 to avoid merge conflicts
r? @nikomatsakis