Uh oh!
There was an error while loading. Please reload this page.
Rollup of 15 pull requests - #49308
Merged
Merged
Conversation
spawn() is expected to return an error if the specified file could not be executed. FreeBSD's posix_spawn() supports returning ENOENT/ENOEXEC if the exec() fails, which not all platforms support. This brings a very significant performance improvement for FreeBSD, involving heavy use of Command in threads, due to fork() invoking jemalloc fork handlers and causing lock contention. FreeBSD's posix_spawn() avoids this problem due to using vfork() internally.
The relevant support was added in https://sourceware.org/bugzilla/show_bug.cgi?id=10354#c12
…hings Also, tweak the test for ignored type aliases such that replacing the type alias by a newtype struct leads to a well-formed type definition, and errors when used the way the type alias is used.
First of all, the lint is specific for type aliases. Second, it turns out the bounds are not entirely ignored but actually used when accessing associated types. So change the wording of the lint, and adapt its name to reality. The lint has never been on stable or beta, so renaming is safe.
…hout "as", suggest to use the "as" form instead. This is necessary to get rid of the type bound, and hence silence the warning.
alexcrichton
commented
Mar 23, 2018
MemberAuthor
@bors: r+ |
bors
commented
Mar 23, 2018
Collaborator
📌 Commit 0e6cd8b has been approved by |
bors
commented
Mar 23, 2018
Collaborator
bors added a commit
that referenced
this pull request
Mar 23, 2018
bors
commented
Mar 23, 2018
Collaborator
💔 Test failed - status-appveyor |
alexcrichton
commented
Mar 23, 2018
MemberAuthor
This was referenced Mar 23, 2018
This was referenced Mar 23, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[repr(packed(n))]RFC 1399. #48528, Command: Support posix_spawn() on FreeBSD/OSX/GNU Linux #48624, rustc: Add a#[wasm_custom_section]attribute #48883, Improve lint for type alias bounds #48909, add an "unstable features" chapter to the rustdoc book #49028, Misc changes from my parallel rustc branch #49030, Remove core::fmt::num::Decimal #49102, Reduce the diagnostic spam when multiple fields are missing in pattern #49160, Document only-X test header #49169, Bump racer and home #49203, Produce nice array lengths on a best effort basis #49262, Use GNU version of fgrep/egrep tool if available #49272, Add test for issue-48238 #49295