Skip to content

Produce nice array lengths on a best effort basis - #49262

Merged
alexcrichton merged 2 commits into
rust-lang:masterfrom
oli-obk:fixed_size_array_len
Mar 23, 2018
Merged

Produce nice array lengths on a best effort basis#49262
alexcrichton merged 2 commits into
rust-lang:masterfrom
oli-obk:fixed_size_array_len

Conversation

@oli-obk

@oli-obkoli-obk commented Mar 22, 2018

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2018
oli-obk
oli-obk commented Mar 22, 2018
View reviewed changes
Comment threadsrc/test/ui/did_you_mean/bad-assoc-ty.stderr
LL | type A = [u8; 4]::AssocTy;
| ^^^^^^^^^^^^^^^^ ambiguous associated type
|
= note: specify the type using the syntax `<[u8; <unevaluated[]>] as Trait>::AssocTy`

@oli-obkoli-obkMar 22, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not fix this case because it would have been very involved. The error reporting mechanisms around this error are very string heavy. This would need to be addressed in a future PR

@estebank

estebank commented Mar 22, 2018

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 22, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit b48a26c has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2018
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 23, 2018
@frewsxcv
Rollup merge ofrust-lang#49262- oli-obk:fixed_size_array_len, r=est…
759ebda
…ebank
Produce nice array lengths on a best effort basis
fixesrust-lang#49208
r? @estebank
@frewsxcvfrewsxcv mentioned this pull request Mar 23, 2018
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 23, 2018
@frewsxcv
Rollup merge ofrust-lang#49262- oli-obk:fixed_size_array_len, r=est…
7936d7d
…ebank
Produce nice array lengths on a best effort basis
fixesrust-lang#49208
r? @estebank
@frewsxcvfrewsxcv mentioned this pull request Mar 23, 2018
Closed
@alexcrichtonalexcrichton mentioned this pull request Mar 23, 2018
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
@alexcrichton
Rollup merge ofrust-lang#49262- oli-obk:fixed_size_array_len, r=est…
6fd3cc5
…ebank
Produce nice array lengths on a best effort basis
fixesrust-lang#49208
r? @estebank
bors added a commit that referenced this pull request Mar 23, 2018
@bors
Auto merge of#49308- alexcrichton:rollup, r=alexcrichton
c08480f
Rollup of 15 pull requests
- Successful merges: #48265, #48528, #48552, #48624, #48883, #48909, #49028, #49030, #49102, #49160, #49169, #49203, #49262, #49272, #49295
- Failed merges: #48942, #49035
@alexcrichton
alexcrichton merged commit b48a26c into rust-lang:masterMar 23, 2018
@oli-obk
oli-obk deleted the fixed_size_array_len branch June 15, 2020 15:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebankestebank

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

All fixed-size array impls show up as <unevaluated[]>

5 participants

@oli-obk@estebank@bors@alexcrichton@rust-highfive