Uh oh!
There was an error while loading. Please reload this page.
Enable target_feature on any LLVM 6+ - #49428
Conversation
In `LLVMRustHasFeature()`, rather than using `MCInfo->getFeatureTable()` that is specific to Rust's LLVM fork, we can use this in LLVM 6: /// Check whether the subtarget features are enabled/disabled as per /// the provided string, ignoring all other features. bool checkFeatures(StringRef FS) const; Now rustc using external LLVM can also have `target_feature`.
cuviper
commented
Mar 27, 2018
(The bot seems to be asleep, so I've manually set the requested reviewer...) |
hanna-kruppe
commented
Mar 27, 2018
Does this mean we can drop rust-lang/llvm@a8a60a1? |
cuviper
commented
Mar 27, 2018
@rkruppe those tables are still used for |
cuviper
commented
Mar 27, 2018
(An alternative for that same info is |
hanna-kruppe
commented
Mar 27, 2018
Surely |
cuviper
commented
Mar 27, 2018
I think |
hanna-kruppe
commented
Mar 27, 2018
Ugh, that's news to me. IMO the |
alexcrichton
commented
Mar 27, 2018
bors
commented
Mar 27, 2018
📌 Commit a93a4d2 has been approved by |
…xcrichton Enable target_feature on any LLVM 6+ In `LLVMRustHasFeature()`, rather than using `MCInfo->getFeatureTable()` that is specific to Rust's LLVM fork, we can use this in LLVM 6: /// Check whether the subtarget features are enabled/disabled as per /// the provided string, ignoring all other features. bool checkFeatures(StringRef FS) const; Now rustc using external LLVM can also have `target_feature`. r? @alexcrichton
@rkruppe the problem is that |
In
LLVMRustHasFeature(), rather than usingMCInfo->getFeatureTable()that is specific to Rust's LLVM fork, we can use this in LLVM 6:
Now rustc using external LLVM can also have
target_feature.r? @alexcrichton