Uh oh!
There was an error while loading. Please reload this page.
Rollup of 12 pull requests - #49460
Merged
Merged
Conversation
In `LLVMRustHasFeature()`, rather than using `MCInfo->getFeatureTable()` that is specific to Rust's LLVM fork, we can use this in LLVM 6: /// Check whether the subtarget features are enabled/disabled as per /// the provided string, ignoring all other features. bool checkFeatures(StringRef FS) const; Now rustc using external LLVM can also have `target_feature`.
Probably accidentally reintroduced in a rebase/merge
If the cached data can't be loaded from disk, just issue a warning to the user so they know why compilation is taking longer than usual but don't fail the entire compilation since we can recover by ignorning the on disk cache. In the same way, if the disk cache can't be deserialized (because it has been corrupted for some reason), report the issue as a warning and continue without failing the compilation. `Decodable::decode()` tends to panic with various errors like "entered unreachable code" or "index out of range" if the input data is corrupted. Work around this by catching panics from the `decode()` calls when joining the thread and continuing without the cached data. Fixesrust-lang#48847
Stabilize method `String::retain` Closesrust-lang#43874
don't pass -no-pie to gnu ld fixesrust-lang#48884
…e, r=michaelwoerister [incremental] Don't panic if decoding the cache fails If the cached data can't be loaded from disk, just issue a warning to the user so they know why compilation is taking longer than usual but don't fail the entire compilation since we can recover by ignorning the on disk cache. In the same way, if the disk cache can't be deserialized (because it has been corrupted for some reason), report the issue as a warning and continue without failing the compilation. `Decodable::decode()` tends to panic with various errors like "entered unreachable code" or "index out of range" if the input data is corrupted. Work around this by catching panics from the `decode()` calls and continuing without the cached data. Fixesrust-lang#48847
Implement `shrink_to` method on collections Fixesrust-lang#49385
…=QuietMisdreavus Fix search appearance Fixesrust-lang#49377. r? @QuietMisdreavus And a screenshot: <img width="1016" alt="screen shot 2018-03-27 at 10 33 01" src="https://user-images.githubusercontent.com/3050060/37956373-7b522852-31ab-11e8-8915-7e20064b5edd.png">
…rn, r=GuillaumeGomez Correctly handle impl trait in external items in rustdoc fixesrust-lang#49373 r? @QuietMisdreavus
…xcrichton Enable target_feature on any LLVM 6+ In `LLVMRustHasFeature()`, rather than using `MCInfo->getFeatureTable()` that is specific to Rust's LLVM fork, we can use this in LLVM 6: /// Check whether the subtarget features are enabled/disabled as per /// the provided string, ignoring all other features. bool checkFeatures(StringRef FS) const; Now rustc using external LLVM can also have `target_feature`. r? @alexcrichton
…insertion, r=QuietMisdreavus Fix collapse toggle insertions on impl with docs Just went through this one randomly... When an impl has docs, the collapse toggle isn't generated. This fixes it. r? @QuietMisdreavus
… r=QuietMisdreavus Fix trait implementation not collapsing docs r? @QuietMisdreavus
…tMisdreavus Fix text overlap Fixesrust-lang#49006. r? @QuietMisdreavus
…imulacrum Delete leftover librustc_const_eval Probably accidentally reintroduced in a rebase/merge fixesrust-lang#49440 r? @Mark-Simulacrum
…olnay Clarify "length" wording in `Vec::with_capacity`. Fixesrust-lang#49448.
rust-highfive
commented
Mar 28, 2018
Contributor
Some changes occurred in HTML/CSS. |
rust-highfive
commented
Mar 28, 2018
Contributor
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
commented
Mar 28, 2018
MemberAuthor
@bors r+ p=12 |
bors
commented
Mar 28, 2018
Collaborator
📌 Commit 30560bb has been approved by |
bors
commented
Mar 28, 2018
Collaborator
bors
commented
Mar 29, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String::retain#49243, don't pass -no-pie to gnu ld #49329, [incremental] Don't panic if decoding the cache fails #49364, Implementshrink_tomethod on collections #49400, Fix search appearance #49405, Correctly handle impl trait in external items in rustdoc #49427, Enable target_feature on any LLVM 6+ #49428, Fix collapse toggle insertions on impl with docs #49429, Fix trait implementation not collapsing docs #49439, Fix text overlap #49442, Delete leftover librustc_const_eval #49444, Clarify "length" wording inVec::with_capacity. #49452