Skip to content

Add docs for the test crate with the std docs - #49465

Merged
bors merged 1 commit into
rust-lang:masterfrom
ollie27:rustbuild_test_docs
Apr 14, 2018
Merged

Add docs for the test crate with the std docs#49465
bors merged 1 commit into
rust-lang:masterfrom
ollie27:rustbuild_test_docs

Conversation

@ollie27

@ollie27ollie27 commented Mar 29, 2018

Copy link
Copy Markdown
Contributor

If the compiler docs aren't going to include the test crate then it may as well be included with std.

Fixes#49388

@ollie27
Add docs for the test crate with the std docs
e719bb0
If the compiler docs aren't going to include the test crate then it may as well be included with std.
@ollie27ollie27 mentioned this pull request Mar 29, 2018
Closed
@Mark-Simulacrum

Mark-Simulacrum commented Mar 29, 2018

Copy link
Copy Markdown
Member

cc @rust-lang/docs, if you want this change I believe it's correct in terms of code.

@QuietMisdreavus

QuietMisdreavus commented Mar 29, 2018

Copy link
Copy Markdown
Contributor

We've already been shipping docs for test and proc_macro with the std docs, right? Does this even affect proc_macro at all?

@ollie27

ollie27 commented Mar 29, 2018

Copy link
Copy Markdown
ContributorAuthor

The current list of crates we ship docs for is alloc, core, proc_macro, std and std_unicode as can be seen on https://doc.rust-lang.org/1.25.0/std/. This is just adding test to that list.

@shepmastershepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2018
@ollie27

ollie27 commented Apr 5, 2018

Copy link
Copy Markdown
ContributorAuthor

This will need backporting to beta now if this is accepted.

@emilyalbiniemilyalbini added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 9, 2018
@emilyalbini

emilyalbini commented Apr 9, 2018

Copy link
Copy Markdown
Member

@rust-lang/docs, can we get a decision on this PR? Thanks!

@emilyalbiniemilyalbini added S-waiting-on-team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2018
@steveklabniksteveklabnik added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Apr 9, 2018
@steveklabnik

steveklabnik commented Apr 9, 2018

Copy link
Copy Markdown
Contributor

@rfcbot: merge

I'd like to move that we accept this. People are confused about where to find these docs on IRC fairly often.

@QuietMisdreavus

QuietMisdreavus commented Apr 9, 2018•
edited by frewsxcv
Loading

Copy link
Copy Markdown
Contributor

Manual tickyboxes activate!

@steveklabnik wants to merge this PR. See the post above for explanation.

@frewsxcv

frewsxcv commented Apr 14, 2018

Copy link
Copy Markdown
Contributor

unanimous docs team approval! ✅

@bors r=steveklabnik,QuietMisdreavus,frewsxcv,GuillaumeGomez

@bors

bors commented Apr 14, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit e719bb0 has been approved by steveklabnik,QuietMisdreavus,frewsxcv,GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team labels Apr 14, 2018
@frewsxcv

frewsxcv commented Apr 14, 2018

Copy link
Copy Markdown
Contributor

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Apr 14, 2018
@kennytm
Rollup merge ofrust-lang#49465- ollie27:rustbuild_test_docs, r=stev…
15eb465
…eklabnik,QuietMisdreavus,frewsxcv,GuillaumeGomez
Add docs for the test crate with the std docs
If the compiler docs aren't going to include the test crate then it may as well be included with std.
Fixesrust-lang#49388
@kennytmkennytm mentioned this pull request Apr 14, 2018
Merged
bors added a commit that referenced this pull request Apr 14, 2018
@bors
Auto merge of#49939- kennytm:rollup, r=kennytm
21dae95
Rollup of 14 pull requests
Successful merges: #49908, #49876, #49916, #49951, #49465, #49922, #49866, #49915, #49886, #49913, #49852, #49958, #49871, #49864
Failed merges:
@bors
bors merged commit e719bb0 into rust-lang:masterApr 14, 2018
@ollie27
ollie27 deleted the rustbuild_test_docs branch April 14, 2018 17:28
@alexcrichtonalexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 20, 2018
@alexcrichtonalexcrichton mentioned this pull request Apr 20, 2018
Merged
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 20, 2018
bors added a commit that referenced this pull request Apr 21, 2018
@bors
Auto merge of#50127- alexcrichton:beta-next2, r=alexcrichton
9b97d1e
[beta] Processing merged backports
This is a backport of the following PRs:
* #49386
* #49465
* #49647
* #49692
* #49695
* #49714
* #49730
* #49830
* #49981
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsbeta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@ollie27@Mark-Simulacrum@QuietMisdreavus@emilyalbini@steveklabnik@frewsxcv@bors@alexcrichton@shepmaster@aturon