Skip to content

Don't inject clippy into rls on stable/beta - #49876

Merged
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:no_secret_clippy_on_stable_☹
Apr 14, 2018

Hidden character warning

The head ref may contain hidden characters: "no_secret_clippy_on_stable_\u2639"
Merged

Don't inject clippy into rls on stable/beta#49876
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:no_secret_clippy_on_stable_☹

Conversation

@oli-obk

@oli-obkoli-obk commented Apr 11, 2018

Copy link
Copy Markdown
Contributor

r? @nrc

as discussed at the all-hands

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2018
@kennytmkennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 11, 2018
@nrc

nrc commented Apr 12, 2018

Copy link
Copy Markdown
Member

@bors: r+

We'd normally discuss the beta request at a meeting, but this seems obviously a good thing to uplift, so beta approving too.

@bors

bors commented Apr 12, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 34956c8 has been approved by nrc

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2018
@nrcnrc added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 12, 2018
@oli-obk

oli-obk commented Apr 12, 2018

Copy link
Copy Markdown
ContributorAuthor

Is the rls-preview component available on beta/stable? If not, there's no need to backport

@nrc

nrc commented Apr 13, 2018

Copy link
Copy Markdown
Member

Is the rls-preview component available on beta/stable? If not, there's no need to backport

It is

kennytm added a commit to kennytm/rust that referenced this pull request Apr 13, 2018
@kennytm
Rollup merge ofrust-lang#49876- oli-obk:no_secret_clippy_on_stable_…
9dbfcb5
…☹, r=nrc
Don't inject clippy into rls on stable/beta
r? @nrc
as discussed at the all-hands
@kennytmkennytm mentioned this pull request Apr 13, 2018
Closed
@kennytmkennytm mentioned this pull request Apr 13, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Apr 14, 2018
@kennytm
Rollup merge ofrust-lang#49876- oli-obk:no_secret_clippy_on_stable_…
c22b4db
…☹, r=nrc
Don't inject clippy into rls on stable/beta
as discussed at the all-hands
bors added a commit that referenced this pull request Apr 14, 2018
@bors
Auto merge of#49939- kennytm:rollup, r=kennytm
21dae95
Rollup of 14 pull requests
Successful merges: #49908, #49876, #49916, #49951, #49465, #49922, #49866, #49915, #49886, #49913, #49852, #49958, #49871, #49864
Failed merges:
@bors
bors merged commit 34956c8 into rust-lang:masterApr 14, 2018
@oli-obk
oli-obk deleted the no_secret_clippy_on_stable_☹ branch April 17, 2018 13:34
@oli-obkoli-obk mentioned this pull request Apr 17, 2018
Closed
@oli-obkoli-obk removed beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 17, 2018
@oli-obkoli-obk mentioned this pull request Apr 17, 2018
Merged
@kennytmkennytm added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 17, 2018
bors added a commit that referenced this pull request Apr 19, 2018
@bors
Auto merge of#50027- oli-obk:const_signed_pat_beta, r=kennytm
8423230
[beta] backport various PRs
original PRs:
* #49949 (not yet merged at the time of writing)
* #49947 (long running const eval error -> warning)
* #49833 (static recursion)
* #49876 (no clippy in stable rls)
* #49904 (Work around LLVM debuginfo problem in librustc_driver. )
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrcnrc

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oli-obk@nrc@bors@kennytm@rust-highfive