Skip to content

Stabilize Option::filter. - #49575

Merged
bors merged 2 commits into
rust-lang:masterfrom
tmccombs:option-filter-stabilize
Apr 12, 2018
Merged

Stabilize Option::filter.#49575
bors merged 2 commits into
rust-lang:masterfrom
tmccombs:option-filter-stabilize

Conversation

@tmccombs

Copy link
Copy Markdown
Contributor

Fixes#45860

@emilyalbiniemilyalbini added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. relnotes Marks issues that should be documented in the release notes of the next release. labels Apr 2, 2018
@frewsxcv

Copy link
Copy Markdown
Contributor

there a couple other instances of the feature flag that can be removed:

https://github.com/rust-lang/rust/search?utf8=%E2%9C%93&q=option_filter&type=

@frewsxcvfrewsxcv added the T-libs-api [DEPRECATED; DO NOT USE] label Apr 5, 2018
@emilyalbini

Copy link
Copy Markdown
Member

Ping from triage @withoutboats! This PR needs your review.

@withoutboats

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 10, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit c7ac32a has been approved by withoutboats

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2018
@kennytm

Copy link
Copy Markdown
Member

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Apr 11, 2018
@kennytmkennytm mentioned this pull request Apr 11, 2018
bors added a commit that referenced this pull request Apr 11, 2018
Rollup of 14 pull requests
Successful merges:
- #49525 (Use sort_by_cached_key where appropriate)
- #49575 (Stabilize `Option::filter`.)
- #49614 (in which the non-shorthand patterns lint keeps its own counsel in macros)
- #49665 (Small nits to make couple of tests pass on mips targets.)
- #49781 (add regression test for #16223 (NLL): use of collaterally moved value)
- #49795 (Properly look for uninhabitedness of variants in niche-filling check)
- #49809 (Stop emitting color codes on TERM=dumb)
- #49856 (Do not uppercase-lint #[no_mangle] statics)
- #49863 (fixed typo)
- #49857 (Fix "fp" target feature for AArch64)
- #49849 (Add --enable-debug flag to musl CI build script)
- #49734 (proc_macro: Generalize `FromIterator` impl)
- #49730 (Fix ICE with impl Trait)
- #48270 (Replace `structurally_resolved_type` in casts check.)
Failed merges:
@bors
bors merged commit c7ac32a into rust-lang:masterApr 12, 2018
@tmccombs
tmccombs deleted the option-filter-stabilize branch August 16, 2018 06:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tmccombs@frewsxcv@emilyalbini@withoutboats@bors@kennytm