Uh oh!
There was an error while loading. Please reload this page.
proc_macro: Generalize FromIterator impl - #49734
Conversation
rust-highfive
commented
Apr 6, 2018
(rust_highfive has picked a reviewer for you, use r? to override) |
dtolnay
left a comment
There was a problem hiding this comment.
Can we get away with
implFromIterator<TokenTree>forTokenStreamimplFromIterator<TokenStream>forTokenStreamfor now instead of dealing with T: Into<TokenStream>?
alexcrichton
commented
Apr 6, 2018
@dtolnay we could try yeah but it would still be a technical breaking change due to custom From impls. |
nikomatsakis
commented
Apr 6, 2018
maybe worth a try though |
To be clear, I filed #49725 to make sure we deal with it knowingly in case other projects are impacted, but I don’t mind if the resolution is "no change". It’s an easy fix for Servo, and that crate is not part of the subset used by Firefox that needs to build on the Stable channel. |
While never intended to be stable we forgot that trait impls are insta-stable! This construction of `FromIterator` wasn't our first choice of how to stabilize the impl but our hands are tied at this point, so revert back to the original definition of `FromIterator` before rust-lang#49597Closesrust-lang#49725
63dc0a2 to
d985344Comparealexcrichton
commented
Apr 6, 2018
Ok, I've added just |
nikomatsakis
commented
Apr 10, 2018
@alexcrichton did you want to do a crater run or something? |
nikomatsakis
commented
Apr 10, 2018
Not sure what is expected path here |
I'm ok landing this and seeing if there's still any breakage. The damage is already done on nightly so it may be a bit late for a crater run :( |
nikomatsakis
commented
Apr 11, 2018
@bors r+ |
bors
commented
Apr 11, 2018
📌 Commit d985344 has been approved by |
…m, r=nikomatsakis proc_macro: Generalize `FromIterator` impl While never intended to be stable we forgot that trait impls are insta-stable! This construction of `FromIterator` wasn't our first choice of how to stabilize the impl but our hands are tied at this point, so revert back to the original definition of `FromIterator` before rust-lang#49597Closesrust-lang#49725
Rollup of 14 pull requests Successful merges: - #49525 (Use sort_by_cached_key where appropriate) - #49575 (Stabilize `Option::filter`.) - #49614 (in which the non-shorthand patterns lint keeps its own counsel in macros) - #49665 (Small nits to make couple of tests pass on mips targets.) - #49781 (add regression test for #16223 (NLL): use of collaterally moved value) - #49795 (Properly look for uninhabitedness of variants in niche-filling check) - #49809 (Stop emitting color codes on TERM=dumb) - #49856 (Do not uppercase-lint #[no_mangle] statics) - #49863 (fixed typo) - #49857 (Fix "fp" target feature for AArch64) - #49849 (Add --enable-debug flag to musl CI build script) - #49734 (proc_macro: Generalize `FromIterator` impl) - #49730 (Fix ICE with impl Trait) - #48270 (Replace `structurally_resolved_type` in casts check.) Failed merges:
While never intended to be stable we forgot that trait impls are insta-stable!
This construction of
FromIteratorwasn't our first choice of how to stabilizethe impl but our hands are tied at this point, so revert back to the original
definition of
FromIteratorbefore #49597Closes#49725