Uh oh!
There was an error while loading. Please reload this page.
1.26.2 release - #51258
Merged
Merged
Conversation
rust-highfive
commented
May 31, 2018
Contributor
|
eddyb
commented
May 31, 2018
Contributor
Do we want to also get #51051 in? Are there any other "quick fixes" we might be forgetting? |
emilyalbini
commented
May 31, 2018
Member
This comment has been minimized.
This comment has been minimized.
eddyb
commented
May 31, 2018
Contributor
@pietroalbini Ah it seems that was done without backporting it to beta in the first place? |
emilyalbini
commented
May 31, 2018
Member
nikomatsakis
commented
Jun 1, 2018
Contributor
`PointerKind` is included in `LoanPath` and hence forms part of the equality check; this led to having two unequal paths that both represent `*x`, depending on whether the `*` was inserted automatically or explicitly. Bad mojo. The `note` field, in contrast, is intended more-or-less primarily for this purpose of adding extra data.
Mark-Simulacrum
commented
Jun 1, 2018
MemberAuthor
@bors r=nikomatsakis p=300 (stable artifacts) |
bors
commented
Jun 1, 2018
Collaborator
📌 Commit 7093b11 has been approved by |
bors
commented
Jun 1, 2018
Collaborator
bors added a commit
that referenced
this pull request
Jun 1, 2018
1.26.2 release This includes a backport of #51235 which fixes#51117 on stable. It has not been tested. r? @nikomatsakis since the backport was not clean. cc @rust-lang/core @rust-lang/release
bors
commented
Jun 1, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a backport of #51235 which fixes#51117 on stable. It has not been tested.
r? @nikomatsakis since the backport was not clean.
cc @rust-lang/core @rust-lang/release