Skip to content

also check let arms and nested patterns for mutable borrows - #51274

Merged
bors merged 1 commit into
rust-lang:masterfrom
nikomatsakis:issue-46557-promote-ref-mut
Jun 2, 2018
Merged

also check let arms and nested patterns for mutable borrows#51274
bors merged 1 commit into
rust-lang:masterfrom
nikomatsakis:issue-46557-promote-ref-mut

Conversation

@nikomatsakis

@nikomatsakisnikomatsakis commented Jun 1, 2018

Copy link
Copy Markdown
Contributor

Fixes#46557

r? @eddyb

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2018
@nikomatsakis

nikomatsakis commented Jun 1, 2018

Copy link
Copy Markdown
ContributorAuthor

oh, let me bless the test. =)

@nikomatsakisnikomatsakis mentioned this pull request Jun 1, 2018
Closed
@Mark-Simulacrum

Mark-Simulacrum commented Jun 1, 2018

Copy link
Copy Markdown
Member

Should we backport this to beta since it does fix unsoundness?

@nikomatsakis

nikomatsakis commented Jun 1, 2018

Copy link
Copy Markdown
ContributorAuthor

Fixed tests.

@nikomatsakis
nikomatsakisforce-pushed the issue-46557-promote-ref-mut branch from 4d932a9 to a667049CompareJune 1, 2018 14:06
@nikomatsakis

nikomatsakis commented Jun 1, 2018

Copy link
Copy Markdown
ContributorAuthor

@Mark-Simulacrum we could .. it's not a recent regression or anything though.

@nikomatsakis

nikomatsakis commented Jun 1, 2018

Copy link
Copy Markdown
ContributorAuthor

OTOH it's a small patch and I believe the code is pretty old, would be a low-risk backport

@oli-obkoli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 1, 2018
@nikomatsakisnikomatsakis mentioned this pull request Jun 1, 2018
Merged
@emilyalbiniemilyalbini mentioned this pull request Jun 1, 2018
Merged
@eddyb

eddyb commented Jun 2, 2018

Copy link
Copy Markdown
Contributor

I hate the old borrowck, at this point it's an incoherent mess of recursive fine-prints.

@bors r+ p=10

@bors

bors commented Jun 2, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit a667049 has been approved by eddyb

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2018
@bors

bors commented Jun 2, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a667049 with merge d830f46...

bors added a commit that referenced this pull request Jun 2, 2018
@bors
Auto merge of#51274- nikomatsakis:issue-46557-promote-ref-mut, r=eddyb
d830f46
also check `let` arms and nested patterns for mutable borrows
Fixes#46557
r? @eddyb
@bors

bors commented Jun 2, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing d830f46 to master...

@bors
bors merged commit a667049 into rust-lang:masterJun 2, 2018
@emilyalbiniemilyalbini added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 7, 2018
@nikomatsakis

nikomatsakis commented Jun 7, 2018

Copy link
Copy Markdown
ContributorAuthor

We could backport this, but there's no burning reason to do so. Clearing the backport flag.

@nikomatsakisnikomatsakis removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nikomatsakis@Mark-Simulacrum@eddyb@bors@oli-obk@emilyalbini@rust-highfive