Update zx_cprng_draw_new on Fuchsia

[abarth]

Fuchsia is changing the semantics for zx_cprng_draw and
zx_cprng_draw_new is a temporary name for the new semantics.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[cramertj]

@bors r+ rollup

[bors]

📌 Commit 03a40b3 has been approved by cramertj

[bors]

⌛ Testing commit 03a40b3 with merge 033d6ba74ec7cb2101899fa90b6887ae8a16e997...

[bors]

💔 Test failed - status-travis

[rust-highfive]

The job dist-x86_64-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

 0 0 0 0 0 0 0 0 --:--:-- 0:00:51 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:52 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:53 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:54 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:55 --:--:-- 0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:06:47] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:575:17
[01:06:47] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-freebsd --target x86_64-unknown-freebsd
[01:06:47] Build completed unsuccessfully in 1:03:56
travis_time:end:02fa56ac:start=1529473566422106043,finish=1529477574469448976,duration=4008047342933
---
travis_time:end:029f5410:start=1529477575085227113,finish=1529477575092833958,duration=7606845
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:13433aa8
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:36e8137c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[rust-highfive]

The job dist-x86_64-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

 0 0 0 0 0 0 0 0 --:--:-- 0:00:51 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:52 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:53 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:54 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:55 --:--:-- 0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:06:47] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:575:17
[01:06:47] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-freebsd --target x86_64-unknown-freebsd
[01:06:47] Build completed unsuccessfully in 1:03:56
travis_time:end:02fa56ac:start=1529473566422106043,finish=1529477574469448976,duration=4008047342933
---
travis_time:end:029f5410:start=1529477575085227113,finish=1529477575092833958,duration=7606845
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:13433aa8
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:36e8137c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[cramertj]

@bors retry

Flakes

[bors]

⌛ Testing commit 03a40b3 with merge 68188cb1f96e9356796120d40e3a2b74cf66785c...

[bors]

💥 Test timed out

[cramertj]

@bors retry

cc @kennytm, @Mark-Simulacrum WRT flakes

[pitdicker]

@abarth Can you explain to me why the standard library uses zx_cprng_draw/zx_cprng_draw_new, while the rand crate uses fuchsia_zircon::cprng_draw?

Is it to prevent adding a dependency to the standard library? Would it make sense to use the same method in rand?

[abarth]

@pitdicker I know very little about Rust. I'm a Fuchsia developer whose currently working on cleanup up the syscall API. @cramertj would probably know more about why these dependencies are set up this way.

[pitdicker]

Thank you @abarth.

In my opinion the standard library should not have all these OS details, when it already depends on thread_rng from Rand. It only uses this function to get two random values from the OS in collections/hash/map.rs, as a work-around that seems questionable to me. Anyway, it would be better if it used OsRng from rand, or didn't need the work-around at all.

But I suppose that is for another PR.

Edit: sorry, rand is only a dev-dependency.

[abarth]

@cramertj Is there some magic command we need to utter to convince the bots that this PR is acceptable. Rust is now the only remaining client of this syscall.

[Mark-Simulacrum]

This is in the queue (https://buildbot2.rust-lang.org/homu/queue/rust). I'll probably do a roll-up tomorrow, so I'd anticipate this landing in around 12-18 hours.

[abarth]

Thanks! /me is slowly learning his way around.