Uh oh!
There was an error while loading. Please reload this page.
Disable probestack when GCOV profiling is being used - #51666
Merged
Conversation
rust-highfive
commented
Jun 20, 2018
Contributor
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
marco-c
commented
Jun 20, 2018
ContributorAuthor
CC @kennytm |
nagisa
commented
Jun 21, 2018
Member
The idea seems sound to me. It is a shame that it has to be disabled, as profiling no longer reflects the call overhead accurately, though. @bors r+ |
bors
commented
Jun 21, 2018
Collaborator
📌 Commit e9aacfd has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Jun 22, 2018
Disable probestack when GCOV profiling is being used If I compile Firefox with gcov profiling enabled, Firefox crashes at startup because of probestack. Since it's disabled for PGO, I think it makes sense to disable it for gcov too.
bors added a commit
that referenced
this pull request
Jun 22, 2018
Rollup of 6 pull requests Successful merges: - #51158 (Mention spec and indented blocks in doctest docs) - #51629 (Do not consume semicolon twice while parsing local statement) - #51637 (Update zx_cprng_draw_new on Fuchsia) - #51664 (make more libsyntax methods public) - #51666 (Disable probestack when GCOV profiling is being used) - #51703 (Recognize the extra "LLVM tools versions" argument to build-manifest.) Failed merges: r? @ghost
bors
commented
Jun 22, 2018
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I compile Firefox with gcov profiling enabled, Firefox crashes at startup because of probestack.
Since it's disabled for PGO, I think it makes sense to disable it for gcov too.