Uh oh!
There was an error while loading. Please reload this page.
Fix unknown windows build - #51642
Merged
Merged
Conversation
rust-highfive
commented
Jun 19, 2018
Contributor
Some changes occurred in HTML/CSS. |
rust-highfive
commented
Jun 19, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomezforce-pushed
the
fix-unknown-windows-build
branch
from
June 19, 2018 22:07
ec76376 to
d259f43Compareoli-obk
reviewed
Jun 20, 2018
| cfg_if! { | ||
| if #[cfg(windows)] { | ||
| // On windows we'll just be documenting what's already available | ||
| #[allow(missing_docs)] |
Contributor
There was a problem hiding this comment.
The issue was about wasm. What is this change for?
MemberAuthor
There was a problem hiding this comment.
Rust docs fails to build on the given target because of #[deny(missing_docs)] I assumed (because I had the issue when updating rustdoc in the first place). A hidden failure in short. :)
emilyalbini
commented
Jun 25, 2018
Member
Ping from triage! @oli-obk what's the status of this PR? |
oli-obk
commented
Jun 25, 2018
Contributor
@bors r+ rollup |
bors
commented
Jun 25, 2018
Collaborator
📌 Commit d259f43 has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 25, 2018
…build, r=oli-obk Fix unknown windows build Fixesrust-lang#51618.
GuillaumeGomez
commented
Jun 25, 2018
MemberAuthor
Following last comment on the issue, I added a missing |
oli-obk
commented
Jun 25, 2018
Contributor
@bors r+ |
bors
commented
Jun 25, 2018
Collaborator
📌 Commit 3c6c18d has been approved by |
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Jun 26, 2018
…build, r=oli-obk Fix unknown windows build Fixesrust-lang#51618.
bors added a commit
that referenced
this pull request
Jun 26, 2018
Rollup of 11 pull requests Successful merges: - #51104 (add `dyn ` to display of dynamic (trait) types) - #51153 (Link panic and compile_error docs) - #51642 (Fix unknown windows build) - #51730 (New safe associated functions for PinMut) - #51731 (Fix ICEs when using continue as an array length inside closures (inside loop conditions)) - #51747 (Add error for using null characters in #[export_name]) - #51769 (Update broken rustc-guide links) - #51786 (Remove unnecessary stat64 pointer casts) - #51788 (Fix typo) - #51789 (Don't ICE when performing `lower_pattern_unadjusted` on a `TyError`) - #51791 (Minify css) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#51618.