Skip to content

Minify css - #51791

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:minify-css
Jun 26, 2018
Merged

Minify css#51791
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:minify-css

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Sizes changes:

dark.css: 8821 => 7804 (~11%)
light.css: 8587 => 7565 (~11%)
rustdoc.css: 22364 => 17818 (~20%)
settings.css: 1384 => 1236 (~10%)

So obviously, the bigger the file, the bigger minification.

r? @QuietMisdreavus

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2018
@estebank

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jun 26, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f7485df has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2018
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Jun 26, 2018
Minify css
Sizes changes:
```
dark.css: 8821 => 7804 (~11%)
light.css: 8587 => 7565 (~11%)
rustdoc.css: 22364 => 17818 (~20%)
settings.css: 1384 => 1236 (~10%)
```
So obviously, the bigger the file, the bigger minification.
r? @QuietMisdreavus
bors added a commit that referenced this pull request Jun 26, 2018
Rollup of 11 pull requests
Successful merges:
- #51104 (add `dyn ` to display of dynamic (trait) types)
- #51153 (Link panic and compile_error docs)
- #51642 (Fix unknown windows build)
- #51730 (New safe associated functions for PinMut)
- #51731 (Fix ICEs when using continue as an array length inside closures (inside loop conditions))
- #51747 (Add error for using null characters in #[export_name])
- #51769 (Update broken rustc-guide links)
- #51786 (Remove unnecessary stat64 pointer casts)
- #51788 (Fix typo)
- #51789 (Don't ICE when performing `lower_pattern_unadjusted` on a `TyError`)
- #51791 (Minify css)
Failed merges:
r? @ghost
@bors
bors merged commit f7485df into rust-lang:masterJun 26, 2018
@GuillaumeGomez
GuillaumeGomez deleted the minify-css branch June 26, 2018 14:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez@estebank@bors@QuietMisdreavus@rust-highfive