Uh oh!
There was an error while loading. Please reload this page.
Update stdsimd - #51695
Conversation
rust-highfive
commented
Jun 22, 2018
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Jun 22, 2018
est31
commented
Jun 22, 2018
r? @kennytm |
rust-highfive
commented
Jun 22, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
est31
commented
Jun 23, 2018
Added WIP label to wait for rust-lang/stdarch#492 |
kennytm
commented
Jun 25, 2018
@bors r+ |
bors
commented
Jun 25, 2018
📌 Commit afa309b has been approved by |
kennytm
commented
Jun 25, 2018
@bors rollup |
rust-lang/stdarch#494, not in this PR yet. |
@bors r- rollup- Cannot compile on s390x due to rust-lang/stdarch#467. Error log: #51782 (comment) |
@est31 so I think I found the issue. https://github.com/rust-lang/rust/blob/master/src/etc/wasm32-shim.js#L109 needs to be updated with the missing functions. At most those should be cc @alexcrichton it seems that rustc has a system for running at least some of the unit tests for |
rust-highfive
commented
Jul 2, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
6eb5ab1 to
1df347aComparerust-highfive
commented
Jul 2, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jul 2, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
They are all needed now due to the stdsimd update.
est31
commented
Jul 2, 2018
wasm is green now: https://travis-ci.org/rust-lang/rust/builds/399147037 I've squashed and removed the temporary test stuff. re-r? @alexcrichton |
est31
commented
Jul 2, 2018
or @kennytm :) |
alexcrichton
commented
Jul 2, 2018
@bors: r+ |
bors
commented
Jul 2, 2018
📌 Commit 56e4625 has been approved by |
bors
commented
Jul 3, 2018
bors
commented
Jul 3, 2018
☀️ Test successful - status-appveyor, status-travis |
alex
commented
Jul 12, 2018
It appears that as a result of this, things linking against only Was this known/expected? Is there by chance a discussion about this somewhere that I couldn't find? |
gnzlbg
commented
Jul 12, 2018
@alex not expected but we have seen the partial downfall of that here due to the wasm issues. Could you file an issue? Also, on which platform is this happening? cc @alexcrichton are the types |
Closes#51691