Skip to content

deprecate read/write eflags - #494

Merged
alexcrichton merged 1 commit into
rust-lang:masterfrom
gnzlbg:deprecate_eflags
Jun 27, 2018
Merged

deprecate read/write eflags#494
alexcrichton merged 1 commit into
rust-lang:masterfrom
gnzlbg:deprecate_eflags

Conversation

@gnzlbg

@gnzlbggnzlbg commented Jun 23, 2018

Copy link
Copy Markdown
Contributor

This deprecates __{read,write}eflags.

@rust-langrust-lang deleted a comment Jun 24, 2018
@rust-langrust-lang deleted a comment Jun 24, 2018
@kennytmkennytm mentioned this pull request Jun 25, 2018
@gnzlbggnzlbg mentioned this pull request Jun 26, 2018
@gnzlbg
gnzlbgforce-pushed the deprecate_eflags branch 2 times, most recently from cfe0363 to 2cf8650CompareJune 26, 2018 13:27
@gnzlbg
gnzlbgforce-pushed the deprecate_eflags branch 2 times, most recently from 89dcee9 to 4b7f75fCompareJune 26, 2018 14:28
@gnzlbg

Copy link
Copy Markdown
ContributorAuthor

Which rust version belongs exactly to the deprecation attribute? It might hit nightly in the next weeks, so it should be two stable versions from now (1.29) right?

@BurntSushi

Copy link
Copy Markdown
Member

At a high level this LGTM, but I don't know enough about the particulars of how exactly things are deprecated to feel comfortable signing off on this.

cc @rust-lang-nursery/libs @alexcrichton

@gnzlbg
gnzlbg requested a review from alexcrichtonJune 27, 2018 16:41
@alexcrichton

Copy link
Copy Markdown
Member

FWIW these are covered by this block during verification which is why they passed through to stable without actually being defined by Intel.

I think it's a compelling enough argument to deprecate these intrinsics currently and we can always undeprecate if we really need to (or if some LLVM "bug" is fixed or something like that)

Thanks for the PR @gnzlbg!

@alexcrichton
alexcrichton merged commit f9f649a into rust-lang:masterJun 27, 2018
TheIronBorn pushed a commit to TheIronBorn/stdsimd that referenced this pull request Jun 29, 2018
TheIronBorn pushed a commit to TheIronBorn/stdsimd that referenced this pull request Jun 29, 2018
lu-zero pushed a commit to lu-zero/stdarch that referenced this pull request Jul 10, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gnzlbg@BurntSushi@alexcrichton