Uh oh!
There was an error while loading. Please reload this page.
deprecate read/write eflags - #494
Conversation
cfe0363 to
2cf8650Compare89dcee9 to
4b7f75fComparegnzlbg
commented
Jun 26, 2018
Which rust version belongs exactly to the deprecation attribute? It might hit nightly in the next weeks, so it should be two stable versions from now (1.29) right? |
BurntSushi
commented
Jun 26, 2018
At a high level this LGTM, but I don't know enough about the particulars of how exactly things are deprecated to feel comfortable signing off on this. cc @rust-lang-nursery/libs @alexcrichton |
alexcrichton
commented
Jun 27, 2018
FWIW these are covered by this block during verification which is why they passed through to stable without actually being defined by Intel. I think it's a compelling enough argument to deprecate these intrinsics currently and we can always undeprecate if we really need to (or if some LLVM "bug" is fixed or something like that) Thanks for the PR @gnzlbg! |
This deprecates
__{read,write}eflags.