Uh oh!
There was an error while loading. Please reload this page.
Revert "Stabilize to_bytes and from_bytes for integers." - #52850
Merged
Conversation
This reverts commit c8f9b84.
rust-highfive
commented
Jul 30, 2018
Contributor
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
SimonSapin
commented
Jul 30, 2018
ContributorAuthor
alexcrichton
commented
Jul 30, 2018
Member
@bors: r+ Sounds like a good plan of action to me! |
bors
commented
Jul 30, 2018
Collaborator
📌 Commit f162438 has been approved by |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 30, 2018
Revert "Stabilize to_bytes and from_bytes for integers." This reverts commit c8f9b84 / PR rust-lang#51835, and reopens the tracking issue rust-lang#49792. These methods were stabilized in Rust 1.29, which is still in Nightly as of this writing. So my understanding is that it is still time to change our minds. Given the ongoing discussion in rust-lang#51919 about possibly renaming these APIs and since 1.29 goes to beta soon, I’d like to revert this stabilization for now until a decision is made in that PR. It’s possible that a decision will be made in time for 1.29, but there is no urgency. At most I expect this functionality to make it into 1.30.
RalfJung
commented
Jul 31, 2018
Member
"Promote master to beta" happens today (according to https://forge.rust-lang.org/release-process.html). Doesn't that mean if the PR does not land today, the beta (and hence stable) would not contain the revert? |
SimonSapin
commented
Jul 31, 2018
ContributorAuthor
Oh I didn’t realize that, thanks Ralf. Let’s try to get it in in time: @bors p=10 … and yes, if we miss the promotion to beta we can still backport. |
bors
commented
Jul 31, 2018
Collaborator
bors added a commit
that referenced
this pull request
Jul 31, 2018
Revert "Stabilize to_bytes and from_bytes for integers." This reverts commit c8f9b84 / PR #51835, and reopens the tracking issue #49792. These methods were stabilized in Rust 1.29, which is still in Nightly as of this writing. So my understanding is that it is still time to change our minds. Given the ongoing discussion in #51919 about possibly renaming these APIs and since 1.29 goes to beta soon, I’d like to revert this stabilization for now until a decision is made in that PR. It’s possible that a decision will be made in time for 1.29, but there is no urgency. At most I expect this functionality to make it into 1.30.
bors
commented
Jul 31, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c8f9b84 / PR #51835, and reopens the tracking issue #49792.
These methods were stabilized in Rust 1.29, which is still in Nightly as of this writing. So my understanding is that it is still time to change our minds. Given the ongoing discussion in #51919 about possibly renaming these APIs and since 1.29 goes to beta soon, I’d like to revert this stabilization for now until a decision is made in that PR. It’s possible that a decision will be made in time for 1.29, but there is no urgency. At most I expect this functionality to make it into 1.30.