Uh oh!
There was an error while loading. Please reload this page.
Rollup of 22 pull requests - #52882
Closed
Mark-Simulacrum wants to merge 63 commits into
Closed
Conversation
…crate to enable related tests
… with wrong variant
Allow target specs to disable that attribute.
Refer instead to thanks page.
This reverts commit c8f9b84.
…r=QuietMisdreavus Delete unused code in rustdoc Also hid the unused crate exports of rustdoc. This is technically a breaking change but we don't even ship librustdoc in the sysroot so I don't expect breakage.
Remove unstable and deprecated APIs
Update clippy to latest master r? @oli-obk There is a regression in the version in current nightly that falsely lints `println!` and `writeln!` that use named arguments, thinking all rhs values for the argument expressions are literals even when they are not. This update includes the fix for that.
rustc: Disallow machine applicability in foreign macros Recent changes to lints disallowed lints from being emitted against code located in foreign macros, except for future-incompatible lints. For a future incompatible lint, however, the automatic suggestions may not be applicable! This commit updates this code path to force all applicability suggestions made to foreign macros to never be `MachineApplicable`. This should avoid rustfix actually attempting fixing these suggestions, causing non-compiling code to be produced. Closesrust-lang/cargo#5799
Clarify thread::park semantics It took me quite some time to realize that the example is not actually racy, so let's clarify it? :-)
…aelwoerister
pretty print for std::collections::vecdeque
I want pretty print function for VecDeque like Vec.
```rust
use std::collections::VecDeque;
fn main() {
let mut d: VecDeque<i32> = VecDeque::new();
d.push_back(4);
d.push_back(4);
d.push_back(6);
let mut v: Vec<i32> = Vec::new();
v.push(4);
v.push(4);
v.push(6);
}
```
```
(gdb) p v
$1 = Vec<i32>(len: 3, cap: 4) = {4, 4, 6}
(gdb) p d
$2 = VecDeque<i32>(len: 3, cap: 8) = {4, 4, 6}
```
Thanks.…, r=cramertj Fix From<LocalWaker> This is a follow-up to rust-lang#52640 Fixes `From<LocalWaker>` which is affected by the same accidental drop bug (unless I'm totally mistaken) r? @cramertj
…r=rkruppe Fix -Wpessimizing-move warnings in rustllvm/PassWrapper These are producing warnings when building rustc (`warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]`).
Make sure rust-lang#47772 does not regress Mostly to make my life in rust-lang#52206 harder.^^ Or should I just add that test there?
…lexcrichton remove references to AUTHORS.txt file Rust does not ship an AUTHORS.txt file anymore.
…=varkor Fix Alias intra doc ICE Fixesrust-lang#52611. cc @QuietMisdreavus r? @varkor
update comment r? @joshtriplett Addressing comment: rust-lang#52761 (review)
…ark-Simulacrum Add timeout to use of `curl` in bootstrap.py. Recently we've seen a lot of "30 minutes no output" spurious errors while downloading the bootstrap compiler. This added several timeout options so if the "30 minutes no output" errors were caused by connection or transfer issue, we could fail quicker for curl to retry.
Revert "Stabilize to_bytes and from_bytes for integers." This reverts commit c8f9b84 / PR rust-lang#51835, and reopens the tracking issue rust-lang#49792. These methods were stabilized in Rust 1.29, which is still in Nightly as of this writing. So my understanding is that it is still time to change our minds. Given the ongoing discussion in rust-lang#51919 about possibly renaming these APIs and since 1.29 goes to beta soon, I’d like to revert this stabilization for now until a decision is made in that PR. It’s possible that a decision will be made in time for 1.29, but there is no urgency. At most I expect this functionality to make it into 1.30.
…hton Improve bootstrap help on stages Cc @eddyb
…imulacrum update books for new release r? @Mark-Simulacrum
…Simulacrum releases.md: fix 2 typos
Implement Unpin for FutureObj and LocalFutureObj cc @MajorBreakfast r? @aturon
Fix wrong issue number in the test name I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113 r? @kennytm
Mark-Simulacrum
commented
Jul 30, 2018
MemberAuthor
@bors r+ p=10 |
bors
commented
Jul 30, 2018
Collaborator
📌 Commit baf6b76 has been approved by |
bors
commented
Jul 31, 2018
Collaborator
⌛ Testing commit baf6b76 with merge c8436ae882ce41f4134a94ae38db462dc07a8461... |
bors
commented
Jul 31, 2018
Collaborator
💔 Test failed - status-appveyor |
RalfJung
commented
Jul 31, 2018
Member
Seems like that's my PR (#52825): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
curlin bootstrap.py. #52846 (Add timeout to use ofcurlin bootstrap.py.)Failed merges:
r? @ghost