Documentation for impl From for AtomicBool and other Atomic types by phungleson · Pull Request #53506 · rust-lang/rust

phungleson · 2018-08-19T21:07:46Z

As part of issue #51430 (cc @skade).

The impl is very simple, so not sure if we need to go into any details.

rust-highfive · 2018-08-19T21:07:48Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-08-19T21:18:32Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-08-19T21:31:09Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:04:33] Compiling build_helper v0.1.0 (file:///checkout/src/build_helper)
[00:04:35] error: expected a literal
[00:04:35] --> libcore/sync/atomic.rs:1835:5
[00:04:35] |
[00:04:35] 1835 | i8 AtomicI8 ATOMIC_I8_INIT
[00:04:35] | ^^ ^^^^^^^^
[00:04:35] |
[00:04:35] = note: only literals (like `"foo"`, `42` and `3.14`) can be passed to `concat!()`
[00:04:35] error: expected a literal
[00:04:35] --> libcore/sync/atomic.rs:1848:5
[00:04:35] |
[00:04:35] |
[00:04:35] 1848 | u8 AtomicU8 ATOMIC_U8_INIT
[00:04:35] | ^^ ^^^^^^^^
[00:04:35] |
[00:04:35] = note: only literals (like `"foo"`, `42` and `3.14`) can be passed to `concat!()`
[00:04:35] error: expected a literal
[00:04:35] --> libcore/sync/atomic.rs:1861:5
[00:04:35] |
[00:04:35] |
[00:04:35] 1861 | i16 AtomicI16 ATOMIC_I16_INIT
[00:04:35] | ^^^ ^^^^^^^^^
[00:04:35] |
[00:04:35] = note: only literals (like `"foo"`, `42` and `3.14`) can be passed to `concat!()`
[00:04:35] error: expected a literal
[00:04:35] --> libcore/sync/atomic.rs:1874:5
[00:04:35] |
[00:04:35] |
[00:04:35] 1874 | u16 AtomicU16 ATOMIC_U16_INIT
[00:04:35] | ^^^ ^^^^^^^^^
[00:04:35] |
[00:04:35] = note: only literals (like `"foo"`, `42` and `3.14`) can be passed to `concat!()`
[00:04:35] error: expected a literal
[00:04:35] --> libcore/sync/atomic.rs:1887:5
[00:04:35] |
[00:04:35] |
[00:04:35] 1887 | i32 AtomicI32 ATOMIC_I32_INIT
[00:04:35] | ^^^ ^^^^^^^^^
[00:04:35] |
[00:04:35] = note: only literals (like `"foo"`, `42` and `3.14`) can be passed to `concat!()`
[00:04:35] error: expected a literal
[00:04:35] --> libcore/sync/atomic.rs:1900:5
[00:04:35] |
[00:04:35] |
[00:04:35] 1900 | u32 AtomicU32 ATOMIC_U32_INIT
[00:04:35] | ^^^ ^^^^^^^^^
[00:04:35] |
[00:04:35] = note: only literals (like `"foo"`, `42` and `3.14`) can be passed to `concat!()`
[00:04:35] error: expected a literal
[00:04:35] --> libcore/sync/atomic.rs:1913:5
[00:04:35] |
[00:04:35] |
[00:04:35] 1913 | i64 AtomicI64 ATOMIC_I64_INIT
[00:04:35] | ^^^ ^^^^^^^^^
[00:04:35] |
[00:04:35] = note: only literals (like `"foo"`, `42` and `3.14`) can be passed to `concat!()`
[00:04:35] error: expected a literal
[00:04:35] --> libcore/sync/atomic.rs:1926:5
[00:04:35] |
[00:04:35] |
[00:04:35] 1926 | u64 AtomicU64 ATOMIC_U64_INIT
[00:04:35] | ^^^ ^^^^^^^^^
[00:04:35] |
[00:04:35] = note: only literals (like `"foo"`, `42` and `3.14`) can be passed to `concat!()`
[00:04:35] error: expected a literal
[00:04:35] --> libcore/sync/atomic.rs:1939:5
[00:04:35] |
[00:04:35] |
[00:04:35] 1939 | isize AtomicIsize ATOMIC_ISIZE_INIT
[00:04:35] | ^^^^^ ^^^^^^^^^^^
[00:04:35] |
[00:04:35] = note: only literals (like `"foo"`, `42` and `3.14`) can be passed to `concat!()`
[00:04:35] error: expected a literal
[00:04:35] --> libcore/sync/atomic.rs:1952:5
[00:04:35] |
[00:04:35] |
[00:04:35] 1952 | usize AtomicUsize ATOMIC_USIZE_INIT
[00:04:35] | ^^^^^ ^^^^^^^^^^^
[00:04:35] |
[00:04:35] = note: only literals (like `"foo"`, `42` and `3.14`) can be passed to `concat!()`
[00:04:36] error: aborting due to 10 previous errors
[00:04:36] [00:04:36] error: Could not compile `core`.
[00:04:36]

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

KodrAus

Thanks @phungleson!

Looks like we need to fix up the concat! call we're using.

rust-highfive · 2018-08-19T23:54:13Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:04:43] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:43] tidy error: /checkout/src/libcore/sync/atomic.rs:1127: line longer than 100 chars
[00:04:45] some tidy checks failed
[00:04:45] [00:04:45] [00:04:45] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:45] [00:04:45] [00:04:45] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:45] Build completed unsuccessfully in 0:00:52
[00:04:45] Build completed unsuccessfully in 0:00:52
[00:04:45] Makefile:79: recipe for target 'tidy' failed
[00:04:45] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:07ad6a3a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0372469b:start=1534722345887621847,finish=1534722345895047503,duration=7425656
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00f400b2
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2a673bd8
travis_time:start:2a673bd8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2e633bb0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

emilyalbini · 2018-08-27T15:46:42Z

Ping from triage @KodrAus! This PR needs your review.

KodrAus

Thanks for your patience @phungleson.

I've just left a few comments.

TimNN · 2018-09-04T18:18:31Z

Ping from triage @phungleson: Some changes have been requested to your PR.

phungleson · 2018-09-05T06:59:50Z

I have addressed the comments @KodrAus

rust-highfive · 2018-09-05T07:06:36Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:04:58] Compiling cc v1.0.22
[00:04:58] Compiling core v0.0.0 (file:///checkout/src/libcore)
[00:04:58] Compiling unwind v0.0.0 (file:///checkout/src/libunwind)
[00:04:58] Compiling build_helper v0.1.0 (file:///checkout/src/build_helper)
[00:04:59] error: incorrect close delimiter: `}`
[00:04:59] |
[00:04:59] 1128 | }
[00:04:59] | ^
[00:04:59] |
---
[00:05:00] --> libcore/sync/atomic.rs:1124:24
[00:05:00] |
[00:05:00] 1124 | concat!(
[00:05:00] | ________________________^
[00:05:00] 1125 | | "Converts an [`", stringify!($int_type), "`] into an [`", stringify!($atomic_type), "`]."
[00:05:00] 1126 | | #[inline]
[00:05:00] 1127 | | fn from(v: $int_type) -> Self { Self::new(v) }
[00:05:00] | |_____________^
[00:05:00] [00:05:01] error: aborting due to 2 previous errors
[00:05:01] ---
travis_time:end:13c12a40:start=1536131192847074191,finish=1536131192856304931,duration=9230740
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2413b6de
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1be9925c
travis_time:start:1be9925c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:11b7e8b4
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-09-06T05:08:55Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:04:37] Compiling cc v1.0.22
[00:04:37] Compiling core v0.0.0 (file:///checkout/src/libcore)
[00:04:37] Compiling build_helper v0.1.0 (file:///checkout/src/build_helper)
[00:04:37] Compiling unwind v0.0.0 (file:///checkout/src/libunwind)
[00:04:39] error: no rules expected the token `#`
[00:04:39] |
[00:04:39] 1126 | #[inline]
[00:04:39] | ^
[00:04:39] ...
[00:04:39] ...
[00:04:39] 1820 | / atomic_int! {
[00:04:39] 1821 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1822 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1823 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] ... |
[00:04:39] 1830 | | i8 AtomicI8 ATOMIC_I8_INIT
[00:04:39] | |_- in this macro invocation
[00:04:39] [00:04:39] [00:04:39] error: no rules expected the token `#`
[00:04:39] |
[00:04:39] 1126 | #[inline]
[00:04:39] | ^
[00:04:39] ...
[00:04:39] ...
[00:04:39] 1833 | / atomic_int! {
[00:04:39] 1834 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1835 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1836 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] ... |
[00:04:39] 1843 | | u8 AtomicU8 ATOMIC_U8_INIT
[00:04:39] | |_- in this macro invocation
[00:04:39] [00:04:39] [00:04:39] error: no rules expected the token `#`
[00:04:39] |
[00:04:39] 1126 | #[inline]
[00:04:39] | ^
[00:04:39] ...
[00:04:39] ...
[00:04:39] 1846 | / atomic_int! {
[00:04:39] 1847 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1848 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1849 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] ... |
[00:04:39] 1856 | | i16 AtomicI16 ATOMIC_I16_INIT
[00:04:39] | |_- in this macro invocation
[00:04:39] [00:04:39] [00:04:39] error: no rules expected the token `#`
[00:04:39] |
[00:04:39] 1126 | #[inline]
[00:04:39] | ^
[00:04:39] ...
[00:04:39] ...
[00:04:39] 1859 | / atomic_int! {
[00:04:39] 1860 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1861 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1862 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] ... |
[00:04:39] 1869 | | u16 AtomicU16 ATOMIC_U16_INIT
[00:04:39] | |_- in this macro invocation
[00:04:39] [00:04:39] [00:04:39] error: no rules expected the token `#`
[00:04:39] |
[00:04:39] 1126 | #[inline]
[00:04:39] | ^
[00:04:39] ...
[00:04:39] ...
[00:04:39] 1872 | / atomic_int! {
[00:04:39] 1873 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1874 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1875 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] ... |
[00:04:39] 1882 | | i32 AtomicI32 ATOMIC_I32_INIT
[00:04:39] | |_- in this macro invocation
[00:04:39] [00:04:39] [00:04:39] error: no rules expected the token `#`
[00:04:39] |
[00:04:39] 1126 | #[inline]
[00:04:39] | ^
[00:04:39] ...
[00:04:39] ...
[00:04:39] 1885 | / atomic_int! {
[00:04:39] 1886 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1887 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1888 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] ... |
[00:04:39] 1895 | | u32 AtomicU32 ATOMIC_U32_INIT
[00:04:39] | |_- in this macro invocation
[00:04:39] [00:04:39] [00:04:39] error: no rules expected the token `#`
[00:04:39] |
[00:04:39] 1126 | #[inline]
[00:04:39] | ^
[00:04:39] ...
[00:04:39] ...
[00:04:39] 1898 | / atomic_int! {
[00:04:39] 1899 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1900 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1901 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] ... |
[00:04:39] 1908 | | i64 AtomicI64 ATOMIC_I64_INIT
[00:04:39] | |_- in this macro invocation
[00:04:39] [00:04:39] [00:04:39] error: no rules expected the token `#`
[00:04:39] |
[00:04:39] 1126 | #[inline]
[00:04:39] | ^
[00:04:39] ...
[00:04:39] ...
[00:04:39] 1911 | / atomic_int! {
[00:04:39] 1912 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1913 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] 1914 | | unstable(feature = "integer_atomics", issue = "32976"),
[00:04:39] ... |
[00:04:39] 1921 | | u64 AtomicU64 ATOMIC_U64_INIT
[00:04:39] | |_- in this macro invocation
[00:04:39] [00:04:39] [00:04:39] error: no rules expected the token `#`
[00:04:39] |
[00:04:39] 1126 | #[inline]
[00:04:39] | ^
[00:04:39] ...
[00:04:39] ...
[00:04:39] 1924 | / atomic_int!{
[00:04:39] 1925 | | stable(feature = "rust1", since = "1.0.0"),
[00:04:39] 1926 | | stable(feature = "extended_compare_and_swap", since = "1.10.0"),
[00:04:39] 1927 | | stable(feature = "atomic_debug", since = "1.3.0"),
[00:04:39] ... |
[00:04:39] 1934 | | isize AtomicIsize ATOMIC_ISIZE_INIT
[00:04:39] | |_- in this macro invocation
[00:04:39] [00:04:39] [00:04:39] error: no rules expected the token `#`
[00:04:39] |
[00:04:39] 1126 | #[inline]
[00:04:39] | ^
[00:04:39] ...
[00:04:39] ...
[00:04:39] 1937 | / atomic_int!{
[00:04:39] 1938 | | stable(feature = "rust1", since = "1.0.0"),
[00:04:39] 1939 | | stable(feature = "extended_compare_and_swap", since = "1.10.0"),
[00:04:39] 1940 | | stable(feature = "atomic_debug", since = "1.3.0"),
[00:04:39] ... |
[00:04:39] 1947 | | usize AtomicUsize ATOMIC_USIZE_INIT
[00:04:39] | |_- in this macro invocation
[00:04:39] [00:04:40] error: aborting due to 10 previous errors
[00:04:40] ---
[00:04:40] warning: build failed, waiting for other jobs to finish...
[00:04:43] error: build failed
[00:04:43] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:04:43] expected success, got: exit code: 101
[00:04:43] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1155:9
[00:04:43] travis_fold:end:stage0-std
[00:04:43] travis_time:end:stage0-std:start=1536210430335637270,finish=1536210436412742988,duration=6077105718
[00:04:43] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:04:43] Build completed unsuccessfully in 0:00:07
[00:04:43] Makefile:28: recipe for target 'all' failed
[00:04:43] make: *** [all] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:138b5d98
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:04640c78:start=1536210437176483594,finish=1536210437184846701,duration=8363107
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:159f1890
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0559538f
travis_time:start:0559538f
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:069040a9
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-09-06T07:20:12Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:43:41] Checking alloc_system v0.0.0 (file:///checkout/src/liballoc_system)
[00:43:41] Checking unwind v0.0.0 (file:///checkout/src/libunwind)
[00:43:42] Checking alloc_jemalloc v0.0.0 (file:///checkout/src/liballoc_jemalloc)
[00:43:42] Checking panic_abort v0.0.0 (file:///checkout/src/libpanic_abort)
[00:43:44] warning: `[AtomicIsize]` cannot be resolved, ignoring it...
[00:43:44] |
[00:43:44] 41 | };
[00:43:44] | _______^
[00:43:44] 42 | | }
[00:43:44] 42 | | }
[00:43:44] 43 | |
[00:43:44] 44 | | macro_rules! nonzero_integers {
[00:43:44] | |_________^ cannot be resolved, ignoring
[00:43:44] = note: #[warn(intra_doc_link_resolution_failure)] on by default
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:44] [00:43:44] warning: `[AtomicU16]` cannot be resolved, ignoring it...
[00:43:44] |
[00:43:44] 41 | / };
[00:43:44] 42 | | }
[00:43:44] 43 | |
[00:43:44] 43 | |
[00:43:44] 44 | | macro_rules! nonzero_integers {
[00:43:44] | |_____^ cannot be resolved, ignoring
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:44] [00:43:44] warning: `[AtomicI32]` cannot be resolved, ignoring it...
[00:43:44] |
[00:43:44] 41 | / };
[00:43:44] 42 | | }
[00:43:44] 43 | |
[00:43:44] 43 | |
[00:43:44] 44 | | macro_rules! nonzero_integers {
[00:43:44] | |_____^ cannot be resolved, ignoring
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:44] warning: `[AtomicBool]` cannot be resolved, ignoring it...
[00:43:44] --> /checkout/src/libcore/sync/atomic.rs:1069:38
[00:43:44] --> /checkout/src/libcore/sync/atomic.rs:1069:38
[00:43:44] |
[00:43:44] 1069 | /// Converts a [`bool`] into an [`AtomicBool`].
[00:43:44] |
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:44] [00:43:44] warning: `[AtomicI16]` cannot be resolved, ignoring it...
[00:43:44] |
[00:43:44] 41 | / };
[00:43:44] 42 | | }
[00:43:44] 43 | |
[00:43:44] 43 | |
[00:43:44] 44 | | macro_rules! nonzero_integers {
[00:43:44] | |_____^ cannot be resolved, ignoring
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:44] [00:43:44] warning: `[AtomicI64]` cannot be resolved, ignoring it...
[00:43:44] |
[00:43:44] 41 | / };
[00:43:44] 42 | | }
[00:43:44] 43 | |
[00:43:44] 43 | |
[00:43:44] 44 | | macro_rules! nonzero_integers {
[00:43:44] | |_____^ cannot be resolved, ignoring
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:44] [00:43:44] warning: `[AtomicU8]` cannot be resolved, ignoring it...
[00:43:44] |
[00:43:44] 41 | / };
[00:43:44] 42 | | }
[00:43:44] 43 | |
[00:43:44] 43 | |
[00:43:44] 44 | | macro_rules! nonzero_integers {
[00:43:44] | |___^ cannot be resolved, ignoring
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:44] [00:43:44] warning: `[AtomicI8]` cannot be resolved, ignoring it...
[00:43:44] |
[00:43:44] 41 | / };
[00:43:44] 42 | | }
[00:43:44] 43 | |
[00:43:44] 43 | |
[00:43:44] 44 | | macro_rules! nonzero_integers {
[00:43:44] | |___^ cannot be resolved, ignoring
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:44] [00:43:44] warning: `[AtomicUsize]` cannot be resolved, ignoring it...
[00:43:44] |
[00:43:44] 41 | };
[00:43:44] | _______^
[00:43:44] 42 | | }
[00:43:44] 42 | | }
[00:43:44] 43 | |
[00:43:44] 44 | | macro_rules! nonzero_integers {
[00:43:44] | |_________^ cannot be resolved, ignoring
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:44] [00:43:44] warning: `[AtomicU32]` cannot be resolved, ignoring it...
[00:43:44] |
[00:43:44] 41 | / };
[00:43:44] 42 | | }
[00:43:44] 43 | |
[00:43:44] 43 | |
[00:43:44] 44 | | macro_rules! nonzero_integers {
[00:43:44] | |_____^ cannot be resolved, ignoring
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:44] [00:43:44] warning: `[AtomicU64]` cannot be resolved, ignoring it...
[00:43:44] |
[00:43:44] 41 | / };
[00:43:44] 42 | | }
[00:43:44] 43 | |
[00:43:44] 43 | |
[00:43:44] 44 | | macro_rules! nonzero_integers {
[00:43:44] | |_____^ cannot be resolved, ignoring
[00:43:44] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:44] [00:43:46] Checking rustc_msan v0.0.0 (file:///checkout/src/librustc_msan)
[00:43:46] Checking rustc_asan v0.0.0 (file:///checkout/src/librustc_asan)
[00:43:46] Checking rustc_asan v0.0.0 (file:///checkout/src/librustc_asan)
[00:43:46] Checking rustc_tsan v0.0.0 (file:///checkout/src/librustc_tsan)
[00:43:46] Checking panic_unwind v0.0.0 (file:///checkout/src/libpanic_unwind)
[00:43:46] Checking rustc_lsan v0.0.0 (file:///checkout/src/librustc_lsan)
[00:43:46] Documenting std v0.0.0 (file:///checkout/src/libstd)
[00:43:52] warning: `[AtomicIsize]` cannot be resolved, ignoring it...
[00:43:52] |
[00:43:52] 41 | };
[00:43:52] | _______^
[00:43:52] 42 | | }
[00:43:52] 42 | | }
[00:43:52] 43 | |
[00:43:52] 44 | | macro_rules! nonzero_integers {
[00:43:52] | |_________^ cannot be resolved, ignoring
[00:43:52] = note: #[warn(intra_doc_link_resolution_failure)] on by default
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:52] [00:43:52] warning: `[AtomicU16]` cannot be resolved, ignoring it...
[00:43:52] |
[00:43:52] 41 | / };
[00:43:52] 42 | | }
[00:43:52] 43 | |
[00:43:52] 43 | |
[00:43:52] 44 | | macro_rules! nonzero_integers {
[00:43:52] | |_____^ cannot be resolved, ignoring
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:52] [00:43:52] warning: `[AtomicI32]` cannot be resolved, ignoring it...
[00:43:52] |
[00:43:52] 41 | / };
[00:43:52] 42 | | }
[00:43:52] 43 | |
[00:43:52] 43 | |
[00:43:52] 44 | | macro_rules! nonzero_integers {
[00:43:52] | |_____^ cannot be resolved, ignoring
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:52] warning: `[AtomicBool]` cannot be resolved, ignoring it...
[00:43:52] --> /checkout/src/libcore/sync/atomic.rs:1069:38
[00:43:52] --> /checkout/src/libcore/sync/atomic.rs:1069:38
[00:43:52] |
[00:43:52] 1069 | /// Converts a [`bool`] into an [`AtomicBool`].
[00:43:52] |
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:52] [00:43:52] warning: `[AtomicI16]` cannot be resolved, ignoring it...
[00:43:52] |
[00:43:52] 41 | / };
[00:43:52] 42 | | }
[00:43:52] 43 | |
[00:43:52] 43 | |
[00:43:52] 44 | | macro_rules! nonzero_integers {
[00:43:52] | |_____^ cannot be resolved, ignoring
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:52] [00:43:52] warning: `[AtomicI64]` cannot be resolved, ignoring it...
[00:43:52] |
[00:43:52] 41 | / };
[00:43:52] 42 | | }
[00:43:52] 43 | |
[00:43:52] 43 | |
[00:43:52] 44 | | macro_rules! nonzero_integers {
[00:43:52] | |_____^ cannot be resolved, ignoring
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:52] [00:43:52] warning: `[AtomicU8]` cannot be resolved, ignoring it...
[00:43:52] |
[00:43:52] 41 | / };
[00:43:52] 42 | | }
[00:43:52] 43 | |
[00:43:52] 43 | |
[00:43:52] 44 | | macro_rules! nonzero_integers {
[00:43:52] | |___^ cannot be resolved, ignoring
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:52] [00:43:52] warning: `[AtomicI8]` cannot be resolved, ignoring it...
[00:43:52] |
[00:43:52] 41 | / };
[00:43:52] 42 | | }
[00:43:52] 43 | |
[00:43:52] 43 | |
[00:43:52] 44 | | macro_rules! nonzero_integers {
[00:43:52] | |___^ cannot be resolved, ignoring
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:52] [00:43:52] warning: `[AtomicUsize]` cannot be resolved, ignoring it...
[00:43:52] |
[00:43:52] 41 | };
[00:43:52] | _______^
[00:43:52] 42 | | }
[00:43:52] 42 | | }
[00:43:52] 43 | |
[00:43:52] 44 | | macro_rules! nonzero_integers {
[00:43:52] | |_________^ cannot be resolved, ignoring
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:52] [00:43:52] warning: `[AtomicU32]` cannot be resolved, ignoring it...
[00:43:52] |
[00:43:52] 41 | / };
[00:43:52] 42 | | }
[00:43:52] 43 | |
[00:43:52] 43 | |
[00:43:52] 44 | | macro_rules! nonzero_integers {
[00:43:52] | |_____^ cannot be resolved, ignoring
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:52] [00:43:52] warning: `[AtomicU64]` cannot be resolved, ignoring it...
[00:43:52] |
[00:43:52] 41 | / };
[00:43:52] 42 | | }
[00:43:52] 43 | |
[00:43:52] 43 | |
[00:43:52] 44 | | macro_rules! nonzero_integers {
[00:43:52] | |_____^ cannot be resolved, ignoring
[00:43:52] = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:43:52] [00:43:54] Finished release [optimized] target(s) in 50.65s
[00:43:55] Documenting stage2 test (x86_64-unknown-linux-gnu)
---
[00:48:38] ....................................................................................................
[00:48:42] ....................................................................................................
[00:48:45] ................................i...................................................................
[00:48:48] ....................................................................................................
[00:48:52] .................................................................................iiiiiiiii..........
[00:48:58] ...ii...............................................................................................
[00:49:02] ....................................................................................................
[00:49:06] ..............................................................i.....................................
[00:49:09] ....................................................................................................
---
[00:49:43] .......................................................................................i............
[00:49:46] ....................................................................................................
[00:49:49] ....................................................................................................
[00:49:51] ....................................................................................................
[00:49:54] .i.ii.ii..ii............................i...........................................................
[00:49:54] test result: ok. 4137 passed; 0 failed; 64 ignored; 0 measured; 0 filtered out
[00:49:54] [00:49:54] finished in 133.813
[00:49:54] travis_fold:end:test_ui_nll
---
[01:16:49] travis_fold:end:stage0-linkchecker
[01:16:49] travis_time:end:stage0-linkchecker:start=1536218388518538692,finish=1536218390838939021,duration=2320400329
[01:16:53] std/sync/atomic/struct.AtomicBool.html:236: absolute path - /checkout/src/libcore/std/primitive.bool.html
[01:17:04] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:17:04] [01:17:04] [01:17:04] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:17:04] expected success, got: exit code: 101
[01:17:04] expected success, got: exit code: 101
[01:17:04] [01:17:04] [01:17:04] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:17:04] Build completed unsuccessfully in 0:32:29
[01:17:04] Makefile:58: recipe for target 'check' failed
[01:17:04] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2e3984ce
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0d70f8eb:start=1536218407575050149,finish=1536218407586834149,duration=11784000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:15dbdf66
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-10-03T01:54:48Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:48:43] .................................................................................................... 2000/4318
[00:48:47] ..................................................................i................................. 2100/4318
[00:48:49] .................................................................................................... 2200/4318
[00:48:52] .................................................................................................... 2300/4318
[00:48:55] ...............iiiiiiiii............................................................................ 2400/4318
[00:49:00] .................................................................................................... 2600/4318
[00:49:04] .................................................................................................... 2700/4318
[00:49:07] i................................................................................................... 2800/4318
[00:49:09] ............................................................i.i..ii................................. 2900/4318
---
[01:24:07] travis_fold:end:stage0-linkchecker
[01:24:07] travis_time:end:stage0-linkchecker:start=1538531395583625889,finish=1538531397830027366,duration=2246401477
[01:27:29] std/convert/trait.From.html:190: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.bool.html
[01:27:29] std/convert/trait.From.html:190: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicBool.html
[01:27:29] std/convert/trait.From.html:213: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i16.html
[01:27:29] std/convert/trait.From.html:213: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI16.html
[01:27:29] std/convert/trait.From.html:217: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i32.html
[01:27:29] std/convert/trait.From.html:217: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI32.html
[01:27:29] std/convert/trait.From.html:219: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i64.html
[01:27:29] std/convert/trait.From.html:219: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI64.html
[01:27:29] std/convert/trait.From.html:227: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i8.html
[01:27:29] std/convert/trait.From.html:227: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI8.html
[01:27:29] std/convert/trait.From.html:228: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.isize.html
[01:27:29] std/convert/trait.From.html:228: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicIsize.html
[01:27:29] std/convert/trait.From.html:238: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u16.html
[01:27:29] std/convert/trait.From.html:238: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU16.html
[01:27:29] std/convert/trait.From.html:251: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u32.html
[01:27:29] std/convert/trait.From.html:251: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU32.html
[01:27:29] std/convert/trait.From.html:254: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u64.html
[01:27:29] std/convert/trait.From.html:254: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU64.html
[01:27:29] std/convert/trait.From.html:291: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u8.html
[01:27:29] std/convert/trait.From.html:291: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU8.html
[01:27:29] std/convert/trait.From.html:292: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.usize.html
[01:27:29] std/convert/trait.From.html:292: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicUsize.html
[01:27:46] core/convert/trait.From.html:67: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.bool.html
[01:27:46] core/convert/trait.From.html:67: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicBool.html
[01:27:46] core/convert/trait.From.html:158: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i16.html
[01:27:46] core/convert/trait.From.html:158: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI16.html
[01:27:46] core/convert/trait.From.html:164: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i32.html
[01:27:46] core/convert/trait.From.html:164: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI32.html
[01:27:46] core/convert/trait.From.html:168: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i64.html
[01:27:46] core/convert/trait.From.html:168: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI64.html
[01:27:46] core/convert/trait.From.html:170: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i8.html
[01:27:46] core/convert/trait.From.html:170: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI8.html
[01:27:46] core/convert/trait.From.html:177: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.isize.html
[01:27:46] core/convert/trait.From.html:177: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicIsize.html
[01:27:46] core/convert/trait.From.html:205: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u16.html
[01:27:46] core/convert/trait.From.html:205: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU16.html
[01:27:46] core/convert/trait.From.html:214: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u32.html
[01:27:46] core/convert/trait.From.html:214: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU32.html
[01:27:46] core/convert/trait.From.html:220: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u64.html
[01:27:46] core/convert/trait.From.html:220: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU64.html
[01:27:46] core/convert/trait.From.html:223: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u8.html
[01:27:46] core/convert/trait.From.html:223: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU8.html
[01:27:46] core/convert/trait.From.html:234: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.usize.html
[01:27:46] core/convert/trait.From.html:234: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicUsize.html
[01:28:45] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:28:45] [01:28:45] [01:28:45] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:28:45] expected success, got: exit code: 101
[01:28:45] expected success, got: exit code: 101
[01:28:45] [01:28:45] [01:28:45] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:28:45] Build completed unsuccessfully in 0:44:07
[01:28:45] make: *** [check] Error 1
[01:28:45] Makefile:58: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2202e802
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0764c52e:start=1538531684507026067,finish=1538531684513257496,duration=6231429
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:06bcc248
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:019fd7b9
travis_time:start:019fd7b9
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/bu

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

KodrAus · 2018-10-03T05:05:05Z

Ah sorry @phungleson, it looks like rustdoc can't resolve these references automatically after all. I thought we could resolve links automatically for any type that was in scope, but we can only resolve links for types that are in the same module.

We're getting an error building the docs saying those links can't be resolved, so it looks like we'll have to go back to your original idea of building the link using the concat! macro.

rust-highfive · 2018-10-03T06:33:53Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:48:57] ..............................................................................................i..... 2200/4543
[00:49:01] .................................................................................................... 2300/4543
[00:49:04] .................................................................................................... 2400/4543
[00:49:08] .................................................................................................... 2500/4543
[00:49:11] ......iiiiiiiii..................................................................................... 2600/4543
[00:49:17] .................................................................................................... 2800/4543
[00:49:21] .................................................................................................... 2900/4543
[00:49:23] ........................i........................................................................... 3000/4543
[00:49:26] ....................................................................................i.i..ii......... 3100/4543
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:02:17] [01:02:17] running 107 tests
[01:02:20] i..ii...iii.....i..i.........i..iii...........i.....i....ii...i.i.ii..............i...ii..ii.i....ii 100/107
[01:02:20] test result: ok. 77 passed; 0 failed; 30 ignored; 0 measured; 0 filtered out
[01:02:20] [01:02:20] finished in 3.356
[01:02:20] travis_fold:end:test_codegen
---
[01:24:43] travis_fold:end:stage0-linkchecker
[01:24:43] travis_time:end:stage0-linkchecker:start=1538548238985589706,finish=1538548241250086376,duration=2264496670
[01:26:52] std/convert/trait.From.html:190: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.bool.html
[01:26:52] std/convert/trait.From.html:190: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicBool.html
[01:26:52] std/convert/trait.From.html:213: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i16.html
[01:26:52] std/convert/trait.From.html:213: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI16.html
[01:26:52] std/convert/trait.From.html:217: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i32.html
[01:26:52] std/convert/trait.From.html:217: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI32.html
[01:26:52] std/convert/trait.From.html:219: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i64.html
[01:26:52] std/convert/trait.From.html:219: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI64.html
[01:26:52] std/convert/trait.From.html:227: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i8.html
[01:26:52] std/convert/trait.From.html:227: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI8.html
[01:26:52] std/convert/trait.From.html:228: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.isize.html
[01:26:52] std/convert/trait.From.html:228: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicIsize.html
[01:26:52] std/convert/trait.From.html:238: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u16.html
[01:26:52] std/convert/trait.From.html:238: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU16.html
[01:26:52] std/convert/trait.From.html:251: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u32.html
[01:26:52] std/convert/trait.From.html:251: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU32.html
[01:26:52] std/convert/trait.From.html:254: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u64.html
[01:26:52] std/convert/trait.From.html:254: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU64.html
[01:26:52] std/convert/trait.From.html:291: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u8.html
[01:26:52] std/convert/trait.From.html:291: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU8.html
[01:26:52] std/convert/trait.From.html:292: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.usize.html
[01:26:52] std/convert/trait.From.html:292: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicUsize.html
[01:27:14] core/convert/trait.From.html:67: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.bool.html
[01:27:14] core/convert/trait.From.html:67: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicBool.html
[01:27:14] core/convert/trait.From.html:158: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i16.html
[01:27:14] core/convert/trait.From.html:158: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI16.html
[01:27:14] core/convert/trait.From.html:164: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i32.html
[01:27:14] core/convert/trait.From.html:164: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI32.html
[01:27:14] core/convert/trait.From.html:168: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i64.html
[01:27:14] core/convert/trait.From.html:168: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI64.html
[01:27:14] core/convert/trait.From.html:170: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.i8.html
[01:27:14] core/convert/trait.From.html:170: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicI8.html
[01:27:14] core/convert/trait.From.html:177: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.isize.html
[01:27:14] core/convert/trait.From.html:177: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicIsize.html
[01:27:14] core/convert/trait.From.html:205: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u16.html
[01:27:14] core/convert/trait.From.html:205: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU16.html
[01:27:14] core/convert/trait.From.html:214: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u32.html
[01:27:14] core/convert/trait.From.html:214: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU32.html
[01:27:14] core/convert/trait.From.html:220: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u64.html
[01:27:14] core/convert/trait.From.html:220: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU64.html
[01:27:14] core/convert/trait.From.html:223: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u8.html
[01:27:14] core/convert/trait.From.html:223: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicU8.html
[01:27:14] core/convert/trait.From.html:234: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.usize.html
[01:27:14] core/convert/trait.From.html:234: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/sync/atomic/struct.AtomicUsize.html
[01:27:47] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:27:47] [01:27:47] [01:27:47] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:27:47] expected success, got: exit code: 101
[01:27:47] expected success, got: exit code: 101
[01:27:47] [01:27:47] [01:27:47] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:27:47] Build completed unsuccessfully in 0:43:28
[01:27:47] make: *** [check] Error 1
[01:27:47] Makefile:58: recipe for target 'check' failed

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

TimNN · 2018-10-09T17:03:31Z

Ping from triage @phungleson, what is the status of this PR?

TimNN · 2018-10-16T17:14:51Z

Ping form triage @phungleson: Could you give us an update on the status of this PR?

phungleson · 2018-10-16T21:08:04Z

The way we refers to other places seem to be changing quite a bit and it is different from area to area.

Like this PR https://github.com/rust-lang/rust/pull/53507/files looks like we can just write the name, but in this PR, looks like we still have to specify the name at the end of the docs area.

Do we have a plan to make it consistent? not having to specify anything is the best.

rust-highfive · 2018-10-16T22:24:55Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:48:51] .................................................................................................... 2200/4601
[00:48:55] ...................i................................................................................ 2300/4601
[00:48:58] .................................................................................................... 2400/4601
[00:49:02] .................................................................................................... 2500/4601
[00:49:05] ................................iiiiiiiii........................................................... 2600/4601
[00:49:11] .................................................................................................... 2800/4601
[00:49:15] .................................................................................................... 2900/4601
[00:49:18] ......................................................i............................................. 3000/4601
[00:49:21] .................................................................................................... 3100/4601
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:01:42] [01:01:42] running 111 tests
[01:01:45] i..ii...iii.......i...i.........i..iii...........i.....i.....ii...i.i.ii..............i....ii.ii.i.. 100/111
[01:01:46] ..iiii.....
[01:01:46] [01:01:46] finished in 3.386
[01:01:46] travis_fold:end:test_codegen
---
[01:25:06] travis_fold:end:stage0-linkchecker
[01:25:06] travis_time:end:stage0-linkchecker:start=1539728466306187657,finish=1539728468546663685,duration=2240476028
[01:27:29] std/sync/atomic/struct.AtomicI64.html:353: broken link - std/sync/atomic/primitive.i64.html
[01:27:29] std/sync/atomic/struct.AtomicU8.html:353: broken link - std/sync/atomic/primitive.u8.html
[01:27:29] std/sync/atomic/struct.AtomicI32.html:353: broken link - std/sync/atomic/primitive.i32.html
[01:27:29] std/sync/atomic/struct.AtomicU16.html:353: broken link - std/sync/atomic/primitive.u16.html
[01:27:29] std/sync/atomic/struct.AtomicI16.html:353: broken link - std/sync/atomic/primitive.i16.html
[01:27:29] std/sync/atomic/struct.AtomicI8.html:353: broken link - std/sync/atomic/primitive.i8.html
[01:27:29] std/sync/atomic/struct.AtomicU64.html:353: broken link - std/sync/atomic/primitive.u64.html
[01:27:29] std/sync/atomic/struct.AtomicU32.html:353: broken link - std/sync/atomic/primitive.u32.html
[01:27:29] std/sync/atomic/struct.AtomicIsize.html:313: broken link - std/sync/atomic/primitive.isize.html
[01:27:29] std/sync/atomic/struct.AtomicBool.html:234: broken link - std/sync/atomic/primitive.bool.html
[01:27:29] std/sync/atomic/struct.AtomicUsize.html:313: broken link - std/sync/atomic/primitive.usize.html
[01:27:34] std/convert/trait.From.html:199: broken link - std/convert/primitive.bool.html
[01:27:34] std/convert/trait.From.html:199: broken link - std/convert/struct.AtomicBool.html
[01:27:34] std/convert/trait.From.html:222: broken link - std/convert/primitive.i16.html
[01:27:34] std/convert/trait.From.html:222: broken link - std/convert/struct.AtomicI16.html
[01:27:34] std/convert/trait.From.html:226: broken link - std/convert/primitive.i32.html
[01:27:34] std/convert/trait.From.html:226: broken link - std/convert/struct.AtomicI32.html
[01:27:34] std/convert/trait.From.html:228: broken link - std/convert/primitive.i64.html
[01:27:34] std/convert/trait.From.html:228: broken link - std/convert/struct.AtomicI64.html
[01:27:34] std/convert/trait.From.html:236: broken link - std/convert/primitive.i8.html
[01:27:34] std/convert/trait.From.html:236: broken link - std/convert/struct.AtomicI8.html
[01:27:34] std/convert/trait.From.html:237: broken link - std/convert/primitive.isize.html
[01:27:34] std/convert/trait.From.html:237: broken link - std/convert/struct.AtomicIsize.html
[01:27:34] std/convert/trait.From.html:247: broken link - std/convert/primitive.u16.html
[01:27:34] std/convert/trait.From.html:247: broken link - std/convert/struct.AtomicU16.html
[01:27:34] std/convert/trait.From.html:260: broken link - std/convert/primitive.u32.html
[01:27:34] std/convert/trait.From.html:260: broken link - std/convert/struct.AtomicU32.html
[01:27:34] std/convert/trait.From.html:263: broken link - std/convert/primitive.u64.html
[01:27:34] std/convert/trait.From.html:263: broken link - std/convert/struct.AtomicU64.html
[01:27:34] std/convert/trait.From.html:300: broken link - std/convert/primitive.u8.html
[01:27:34] std/convert/trait.From.html:300: broken link - std/convert/struct.AtomicU8.html
[01:27:34] std/convert/trait.From.html:301: broken link - std/convert/primitive.usize.html
[01:27:34] std/convert/trait.From.html:301: broken link - std/convert/struct.AtomicUsize.html
[01:27:51] core/sync/atomic/struct.AtomicI64.html:354: broken link - core/sync/atomic/primitive.i64.html
[01:27:51] core/sync/atomic/struct.AtomicU8.html:354: broken link - core/sync/atomic/primitive.u8.html
[01:27:51] core/sync/atomic/struct.AtomicI32.html:354: broken link - core/sync/atomic/primitive.i32.html
[01:27:51] core/sync/atomic/struct.AtomicU16.html:354: broken link - core/sync/atomic/primitive.u16.html
[01:27:51] core/sync/atomic/struct.AtomicI16.html:354: broken link - core/sync/atomic/primitive.i16.html
[01:27:51] core/sync/atomic/struct.AtomicI8.html:354: broken link - core/sync/atomic/primitive.i8.html
[01:27:51] core/sync/atomic/struct.AtomicU64.html:354: broken link - core/sync/atomic/primitive.u64.html
[01:27:51] core/sync/atomic/struct.AtomicU32.html:354: broken link - core/sync/atomic/primitive.u32.html
[01:27:51] core/sync/atomic/struct.AtomicIsize.html:314: broken link - core/sync/atomic/primitive.isize.html
[01:27:51] core/sync/atomic/struct.AtomicBool.html:235: broken link - core/sync/atomic/primitive.bool.html
[01:27:51] core/sync/atomic/struct.AtomicUsize.html:314: broken link - core/sync/atomic/primitive.usize.html
[01:27:51] core/convert/trait.From.html:67: broken link - core/convert/primitive.bool.html
[01:27:51] core/convert/trait.From.html:67: broken link - core/convert/struct.AtomicBool.html
[01:27:51] core/convert/trait.From.html:158: broken link - core/convert/primitive.i16.html
[01:27:51] core/convert/trait.From.html:158: broken link - core/convert/struct.AtomicI16.html
[01:27:51] core/convert/trait.From.html:164: broken link - core/convert/primitive.i32.html
[01:27:51] core/convert/trait.From.html:164: broken link - core/convert/struct.AtomicI32.html
[01:27:51] core/convert/trait.From.html:168: broken link - core/convert/primitive.i64.html
[01:27:51] core/convert/trait.From.html:168: broken link - core/convert/struct.AtomicI64.html
[01:27:51] core/convert/trait.From.html:170: broken link - core/convert/primitive.i8.html
[01:27:51] core/convert/trait.From.html:170: broken link - core/convert/struct.AtomicI8.html
[01:27:51] core/convert/trait.From.html:177: broken link - core/convert/primitive.isize.html
[01:27:51] core/convert/trait.From.html:177: broken link - core/convert/struct.AtomicIsize.html
[01:27:51] core/convert/trait.From.html:205: broken link - core/convert/primitive.u16.html
[01:27:51] core/convert/trait.From.html:205: broken link - core/convert/struct.AtomicU16.html
[01:27:51] core/convert/trait.From.html:214: broken link - core/convert/primitive.u32.html
[01:27:51] core/convert/trait.From.html:214: broken link - core/convert/struct.AtomicU32.html
[01:27:51] core/convert/trait.From.html:220: broken link - core/convert/primitive.u64.html
[01:27:51] core/convert/trait.From.html:220: broken link - core/convert/struct.AtomicU64.html
[01:27:51] core/convert/trait.From.html:223: broken link - core/convert/primitive.u8.html
[01:27:51] core/convert/trait.From.html:223: broken link - core/convert/struct.AtomicU8.html
[01:27:51] core/convert/trait.From.html:234: broken link - core/convert/primitive.usize.html
[01:27:51] core/convert/trait.From.html:234: broken link - core/convert/struct.AtomicUsize.html
[01:28:39] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:28:39] [01:28:39] [01:28:39] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:28:39] expected success, got: exit code: 101
[01:28:39] expected success, got: exit code: 101
[01:28:39] [01:28:39] [01:28:39] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:28:39] Build completed unsuccessfully in 0:44:20
[01:28:39] make: *** [check] Error 1
[01:28:39] Makefile:58: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:05970d56
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:14b2370e:start=1539728691329701970,finish=1539728691333927318,duration=4225348
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:15bb85ba
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

KodrAus · 2018-11-20T02:21:43Z

@Mark-Simulacrum Thanks for the ping! I have had a look locally and the links do work, and I'm not getting any errors out of linkchecker on the built documentation. So am not totally sure where the problem is yet.

Mark-Simulacrum · 2018-11-20T02:30:39Z

Do we perhaps want to drop the links to bool/i32? It seems like that might allow this PR to move forward and links can be added separately.

Also cc @QuietMisdreavus, perhaps you can help diagnose the link check failures here?

TimNN · 2018-11-27T18:23:24Z

Ping from triage @phungleson: It looks like a potential way forward for this PR has been suggested (just dropping the problematic links for now).

Centril · 2018-12-01T18:53:30Z

Ping from triage... @phungleson, any thoughts on moving this PR ahead?

phungleson · 2018-12-02T21:25:22Z

From the log I can see the links are broken for all the number formats, so do you guys think if removing only bool/i32 can help?

The issue seems to be that the number are missing in some test environments.

QuietMisdreavus · 2018-12-04T17:00:07Z

The links are broken because they're appearing on the page(s) for From as well as the atomic types. I guess they're at different directory depths, so doing the ../.. dance won't work.

Using intra-doc links to link to primitives likely won't work either, because we've had problems trying to use those to link to primitive docs from core. (It requires being able to load std to have those available, which creates exotic linking problems with duplicate libcore libraries.) You'll probably have to ditch the links.

rust-highfive · 2018-12-05T00:16:50Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:35ae7b97:start=1543968699340636962,finish=1543968783582436261,duration=84241799299
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout
Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
100% |████████████████████████████████| 1.4MB 906kB/s Collecting botocore==1.12.59 (from awscli)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
InsecurePlatformWarning
Downloading https://files.pythonhosted.org/packages/21/cf/71dfc14692883aaf709bc1098a56770173a760a14b0b1cb74471609181be/botocore-1.12.59-py2.py3-none-any.whl (5.1MB)
0% | | 10kB 43.2MB/s eta 0:00:01
0% |▏ | 20kB 32.4MB/s eta 0:00:01
0% |▏ | 30kB 37.3MB/s eta 0:00:01
0% |▎ | 40kB 27.5MB/s eta 0:00:01
---
[00:03:28] Compiling cc v1.0.25
[00:03:28] Compiling core v0.0.0 (/checkout/src/libcore)
[00:03:28] Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:03:28] Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:03:28] error: incorrect close delimiter: `}`
[00:03:28] |
[00:03:28] 1138 | doc_comment! {
[00:03:28] 1138 | doc_comment! {
[00:03:28] | - close delimiter possibly meant for this
[00:03:28] 1139 | concat!(
[00:03:28] | - un-closed delimiter
[00:03:28] 1143 | }
[00:03:28] | ^ incorrect close delimiter
[00:03:28] [1merror: aborting due to 2 previous errors
---
travis_time:end:2a27d838:start=1543969007286026367,finish=1543969007292018246,duration=5991879
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:22e80130
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:07d14b83
travis_time:start:07d14b83
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:080d9220
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

KodrAus · 2018-12-05T04:39:12Z

Success! 🎉

@phungleson Would you like to give these commits a squash and I'll get this one merged :)

phungleson · 2018-12-11T22:43:14Z

All done guys, this is probably the longest simplest PR ever 😃

KodrAus · 2018-12-14T10:51:51Z

Thanks for your patience in working through this! Most of the time it's a bit more obvious why the build fails.

@bors r+ rollup

bors · 2018-12-14T10:51:52Z

📌 Commit 94c1c73 has been approved by KodrAus

@skade

…KodrAus Documentation for impl From for AtomicBool and other Atomic types As part of issue rust-lang#51430 (cc @skade). The impl is very simple, so not sure if we need to go into any details.

@skade

…KodrAus Documentation for impl From for AtomicBool and other Atomic types As part of issue rust-lang#51430 (cc @skade). The impl is very simple, so not sure if we need to go into any details.

@skade

…KodrAus Documentation for impl From for AtomicBool and other Atomic types As part of issue rust-lang#51430 (cc @skade). The impl is very simple, so not sure if we need to go into any details.

@ghost

Rollup of 20 pull requests Successful merges: - #53506 (Documentation for impl From for AtomicBool and other Atomic types) - #56343 (Remove not used mod) - #56439 (Clearer error message for dead assign) - #56640 (Add FreeBSD unsigned char platforms to std::os::raw) - #56648 (Fix BTreeMap UB) - #56672 (Document time of back operations of a Linked List) - #56706 (Make `const unsafe fn` bodies `unsafe`) - #56742 (infer: remove Box from a returned Iterator) - #56761 (Suggest using `.display()` when trying to print a `Path`) - #56781 (Update LLVM submodule) - #56789 (rustc: Add an unstable `simd_select_bitmask` intrinsic) - #56790 (Make RValue::Discriminant a normal Shallow read) - #56793 (rustdoc: look for comments when scraping attributes/crates from doctests) - #56826 (rustc: Add the `cmpxchg16b` target feature on x86/x86_64) - #56832 (std: Use `rustc_demangle` from crates.io) - #56844 (Improve CSS rule) - #56850 (Fixed issue with using `Self` ctor in typedefs) - #56855 (Remove u8 cttz hack) - #56857 (Fix a small mistake regarding NaNs in a deprecation message) - #56858 (Fix doc of `std::fs::canonicalize`) Failed merges: - #56741 (treat ref-to-raw cast like a reborrow: do a special kind of retag) r? @ghost

rust-highfive assigned KodrAus Aug 19, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2018

KodrAus previously approved these changes Aug 19, 2018
View reviewed changes

KodrAus reviewed Aug 19, 2018
View reviewed changes

Comment threadsrc/libcore/sync/atomic.rs Outdated

KodrAus reviewed Aug 28, 2018
View reviewed changes

Comment threadsrc/libcore/sync/atomic.rs Outdated
Comment threadsrc/libcore/sync/atomic.rs Outdated
Comment threadsrc/libcore/sync/atomic.rs Outdated

TimNN added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2018

KodrAus reviewed Sep 5, 2018
View reviewed changes

Comment threadsrc/libcore/sync/atomic.rs Outdated

TimNN added A-allocators Area: Custom and system allocators and removed A-allocators Area: Custom and system allocators labels Sep 25, 2018

KodrAus closed this Oct 3, 2018

KodrAus reopened this Oct 3, 2018

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2018

Documentation for impl From for AtomicBool and other Atomic types
94c1c73

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 14, 2018

kennytm mentioned this pull request Dec 14, 2018
Rollup of 27 pull requests (second batch) #56817
Closed

emilyalbini mentioned this pull request Dec 14, 2018
Rollup of 25 pull requests #56830
Closed

Centril mentioned this pull request Dec 16, 2018
Rollup of 22 pull requests #56873
Closed

Centril mentioned this pull request Dec 16, 2018
Rollup of 20 pull requests #56875
Merged

bors merged commit 94c1c73 into rust-lang:masterDec 16, 2018

Uh oh!

Uh oh!

Conversation

phungleson commented Aug 19, 2018

Uh oh!

rust-highfive commented Aug 19, 2018

Uh oh!

rust-highfive commented Aug 19, 2018

Uh oh!

rust-highfive commented Aug 19, 2018

Uh oh!

KodrAus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rust-highfive commented Aug 19, 2018

Uh oh!

emilyalbini commented Aug 27, 2018

Uh oh!

KodrAus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TimNN commented Sep 4, 2018

Uh oh!

phungleson commented Sep 5, 2018

Uh oh!

rust-highfive commented Sep 5, 2018

Uh oh!

Uh oh!

rust-highfive commented Sep 6, 2018

Uh oh!

rust-highfive commented Sep 6, 2018

Uh oh!

rust-highfive commented Oct 3, 2018

Uh oh!

KodrAus commented Oct 3, 2018

Uh oh!

rust-highfive commented Oct 3, 2018

Uh oh!

TimNN commented Oct 9, 2018

Uh oh!

TimNN commented Oct 16, 2018

Uh oh!

phungleson commented Oct 16, 2018

Uh oh!

rust-highfive commented Oct 16, 2018

Uh oh!

KodrAus commented Nov 20, 2018

Uh oh!

Mark-Simulacrum commented Nov 20, 2018

Uh oh!

TimNN commented Nov 27, 2018

Uh oh!

Centril commented Dec 1, 2018

Uh oh!

phungleson commented Dec 2, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QuietMisdreavus commented Dec 4, 2018

Uh oh!

rust-highfive commented Dec 5, 2018

Uh oh!

KodrAus commented Dec 5, 2018

Uh oh!

phungleson commented Dec 11, 2018

Uh oh!

KodrAus commented Dec 14, 2018

Uh oh!

bors commented Dec 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

phungleson commented Dec 2, 2018•
edited
Loading