Skip to content

Fixed issue with using Self ctor in typedefs - #56850

Merged
bors merged 4 commits into
rust-lang:masterfrom
alexreg:fix-self-in-typedefs
Dec 16, 2018
Merged

Fixed issue with using Self ctor in typedefs#56850
bors merged 4 commits into
rust-lang:masterfrom
alexreg:fix-self-in-typedefs

Conversation

@alexreg

@alexregalexreg commented Dec 15, 2018•
edited by pnkfelix
Loading

Copy link
Copy Markdown
Contributor

Added two regression tests.

This is definitely suitable for a beta backport.

CC @Centril

Includes regression tests labelled with issues #56199, #56835, #56611

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2018
@petrochenkov

petrochenkov commented Dec 15, 2018

Copy link
Copy Markdown
Contributor

c39a642 is missing

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2018
petrochenkov
petrochenkov reviewed Dec 15, 2018
View reviewed changes
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
@petrochenkov

petrochenkov commented Dec 15, 2018

Copy link
Copy Markdown
Contributor

r=me with error message wording updated (#56850 (comment))

@alexreg

alexreg commented Dec 15, 2018

Copy link
Copy Markdown
ContributorAuthor

@petrochenkov Done.

@rust-highfive

This comment has been minimized.

Sign in to view
@alexreg

alexreg commented Dec 15, 2018

Copy link
Copy Markdown
ContributorAuthor

@petrochenkov AppVeyor is borked. Could you r+ this anyway please?

@petrochenkov

petrochenkov commented Dec 15, 2018

Copy link
Copy Markdown
Contributor

Error wording is updated, but tests are not.

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@alexreg

alexreg commented Dec 15, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@petrochenkov LGTM! :-)

@petrochenkov

petrochenkov commented Dec 16, 2018

Copy link
Copy Markdown
Contributor

@bors r+
@bors delegate+

@bors

bors commented Dec 16, 2018

Copy link
Copy Markdown
Collaborator

✌️ @alexreg can now approve this pull request

@bors

bors commented Dec 16, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 0211856 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2018
@petrochenkov

petrochenkov commented Dec 16, 2018

Copy link
Copy Markdown
Contributor

@alexreg
Could you squash commits into one if you have time?

@petrochenkovpetrochenkov added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 16, 2018
@CentrilCentril mentioned this pull request Dec 16, 2018
Closed
Centril added a commit to Centril/rust that referenced this pull request Dec 16, 2018
@Centril
Rollup merge ofrust-lang#56850- alexreg:fix-self-in-typedefs, r=pet…
8662946
…rochenkov
Fixed issue with using `Self` ctor in typedefs
Added two regression tests.
This is definitely suitable for a beta backport.
CC @Centril
@CentrilCentril mentioned this pull request Dec 16, 2018
Merged
bors added a commit that referenced this pull request Dec 16, 2018
@bors
Auto merge of#56875- Centril:rollup, r=Centril
a8a2a88
Rollup of 20 pull requests
Successful merges:
- #53506 (Documentation for impl From for AtomicBool and other Atomic types)
- #56343 (Remove not used mod)
- #56439 (Clearer error message for dead assign)
- #56640 (Add FreeBSD unsigned char platforms to std::os::raw)
- #56648 (Fix BTreeMap UB)
- #56672 (Document time of back operations of a Linked List)
- #56706 (Make `const unsafe fn` bodies `unsafe`)
- #56742 (infer: remove Box from a returned Iterator)
- #56761 (Suggest using `.display()` when trying to print a `Path`)
- #56781 (Update LLVM submodule)
- #56789 (rustc: Add an unstable `simd_select_bitmask` intrinsic)
- #56790 (Make RValue::Discriminant a normal Shallow read)
- #56793 (rustdoc: look for comments when scraping attributes/crates from doctests)
- #56826 (rustc: Add the `cmpxchg16b` target feature on x86/x86_64)
- #56832 (std: Use `rustc_demangle` from crates.io)
- #56844 (Improve CSS rule)
- #56850 (Fixed issue with using `Self` ctor in typedefs)
- #56855 (Remove u8 cttz hack)
- #56857 (Fix a small mistake regarding NaNs in a deprecation message)
- #56858 (Fix doc of `std::fs::canonicalize`)
Failed merges:
- #56741 (treat ref-to-raw cast like a reborrow: do a special kind of retag)
r? @ghost
@bors
bors merged commit 0211856 into rust-lang:masterDec 16, 2018
@pnkfelixpnkfelix added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 20, 2018
@pnkfelixpnkfelix mentioned this pull request Dec 20, 2018
Closed
@pnkfelix

pnkfelix commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

discussed at T-compiler meeting. beta-accepted.

@pnkfelixpnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 20, 2018
@emilyalbiniemilyalbini mentioned this pull request Dec 31, 2018
Merged
@emilyalbiniemilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 31, 2018
bors added a commit that referenced this pull request Dec 31, 2018
@bors
Auto merge of#57236- pietroalbini:beta-backports, r=pietroalbini
bab921d
[beta] Rollup backports
* #56919: Remove a wrong multiplier on relocation offset computation
* #56916: Fix mutable references in `static mut`
* #56863: fix trait objects with a Self-containing projection values
* #56850: Fixed issue with using `Self` ctor in typedefs
r? @ghost
bors added a commit that referenced this pull request Jan 1, 2019
@bors
Auto merge of#57236- pietroalbini:beta-backports, r=pietroalbini
fa64cc8
[beta] Rollup backports
* #56919: Remove a wrong multiplier on relocation offset computation
* #56916: Fix mutable references in `static mut`
* #56863: fix trait objects with a Self-containing projection values
* #56850: Fixed issue with using `Self` ctor in typedefs
r? @ghost
@davidtwcodavidtwco mentioned this pull request Jan 20, 2019
Closed
@memoryruinsmemoryruins mentioned this pull request Jan 27, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alexreg@petrochenkov@rust-highfive@bors@pnkfelix@emilyalbini