Uh oh!
There was an error while loading. Please reload this page.
Merge IdxSet and IdxSetBuf - #53520
Merged
Merged
Conversation
This makes it more like `AllSets::{gen,kill}_set`, removes the need for
a bunch of bitset range computations, and removes the need for `Bits`.
It's marginally less efficient, because we have to allocate one bitset
per basic block instead of one large shared bitset, but the difference
is negligible in practice.The `Buf` vs. non-`Buf` distinction is no longer necessary, and the nastiest code in this file can be removed. To minimize this patch, `IdxSet` is made a typedef of `IdxSetBuf`. The next patch will remove this typedef.
Now that the `Buf` vs. non-`Buf` distinction has been removed, it makes sense to drop the `Buf` suffix and use the shorter names everywhere.
rust-highfive
commented
Aug 20, 2018
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
nnethercote
commented
Aug 20, 2018
ContributorAuthor
nnethercote
commented
Aug 20, 2018
ContributorAuthor
@bors try |
bors
commented
Aug 20, 2018
Collaborator
⌛ Trying commit e7e9f2e with merge 3d5c7019ca98038841575ca04bca95093b3abe4f... |
bors
commented
Aug 20, 2018
Collaborator
☀️ Test successful - status-travis |
nnethercote
commented
Aug 20, 2018
ContributorAuthor
@rust-timer build 3d5c7019ca98038841575ca04bca95093b3abe4f |
rust-timer
commented
Aug 20, 2018
Collaborator
Success: Queued 3d5c7019ca98038841575ca04bca95093b3abe4f with parent d2048b6, comparison URL. |
nnethercote
commented
Aug 20, 2018
ContributorAuthor
The comparison URL shows that there is no regression of note. ( |
nikomatsakis
commented
Aug 22, 2018
Contributor
@bors r+ |
bors
commented
Aug 22, 2018
Collaborator
📌 Commit e7e9f2e has been approved by |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 22, 2018
… r=nikomatsakis Merge `IdxSet` and `IdxSetBuf` Because it simplifies things. @r? nikomatsakis
bors
commented
Aug 23, 2018
Collaborator
bors added a commit
that referenced
this pull request
Aug 23, 2018
…akis Merge `IdxSet` and `IdxSetBuf` Because it simplifies things. @r? nikomatsakis
bors
commented
Aug 23, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This was referenced Aug 23, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because it simplifies things.
@r? nikomatsakis