Uh oh!
There was an error while loading. Please reload this page.
HybridIdxSet tweaks - #53656
Merged
Merged
Conversation
nikomatsakis
approved these changes
Aug 24, 2018
nikomatsakis
left a comment
Contributor
There was a problem hiding this comment.
Nice. r=me once travis is happy and post rebase.
Contributor
There was a problem hiding this comment.
didn't I already review this? Am I just getting confused...
nikomatsakis
commented
Aug 24, 2018
Contributor
@bors r=nnethercote |
bors
commented
Aug 24, 2018
Collaborator
📌 Commit f52c0b93e45def9e5c5010f3d90a9156afac4110 has been approved by |
nikomatsakis
commented
Aug 24, 2018
Contributor
@bors r- |
nikomatsakis
commented
Aug 24, 2018
Contributor
@bors delegate=nnethercote |
bors
commented
Aug 24, 2018
Collaborator
✌️ @nnethercote can now approve this pull request |
nnethercote
commented
Aug 24, 2018
ContributorAuthor
Oh, I mismanaged this branch... the first three commits already landed in #53520. It's just the last two commits that are new. Sorry for the confusion. |
Because `domain` is a more obvious term than `universe` for this concept.
They let `union()`, `union_sparse()` and `union_hybrid()` be merged. Likewise for subtract()`, `subtract_sparse()` and `subtract_hybrid()`.
nnethercoteforce-pushed
the
HybridIdxSet-tweaks
branch
from
August 24, 2018 09:51
f52c0b9 to
626b298Comparennethercote
commented
Aug 24, 2018
ContributorAuthor
@bors r=nikomatsakis |
bors
commented
Aug 24, 2018
Collaborator
📌 Commit 626b298 has been approved by |
bors
commented
Aug 27, 2018
Collaborator
bors added a commit
that referenced
this pull request
Aug 27, 2018
`HybridIdxSet` tweaks A couple of tweaks to `HybridIdxSet`. r? @nikomatsakis
bors
commented
Aug 27, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of tweaks to
HybridIdxSet.r? @nikomatsakis