Uh oh!
There was an error while loading. Please reload this page.
Update RELEASES.md to include clippy-preview - #53594
Merged
Merged
Conversation
phansch
reviewed
Aug 22, 2018
| will demote `deny` and `forbid` lints to `warn`. | ||
| - [`rustc` and `rustdoc` will now have the exit code of `1` if compilation | ||
| fails, and `101` if there is a panic.][52197] | ||
| - [Added a preview of clippy has been made available through rustup][51122] |
Contributor
There was a problem hiding this comment.
I think this was supposed start with "A preview of Clippy [...]"
Mark-Simulacrum
commented
Aug 22, 2018
Member
@bors r+ |
bors
commented
Aug 22, 2018
Collaborator
📌 Commit 200c6d9 has been approved by |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 22, 2018
…rk-Simulacrum Update RELEASES.md to include clippy-preview [Rendered](https://github.com/rust-lang/rust/blob/Aaronepower-patch-1/RELEASES.md#misc) r? @Mark-Simulacrum
kennytm
commented
Aug 23, 2018
Member
@bors rollup Beta-nominating as part of 1.29's release note. |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Aug 24, 2018
…rk-Simulacrum Update RELEASES.md to include clippy-preview [Rendered](https://github.com/rust-lang/rust/blob/Aaronepower-patch-1/RELEASES.md#misc) r? @Mark-Simulacrum
bors added a commit
that referenced
this pull request
Aug 24, 2018
Rollup of 16 pull requests Successful merges: - #53311 (Window Mutex: Document that we properly initialize the SRWLock) - #53503 (Discourage overuse of mem::forget) - #53545 (Fix#50865: ICE on impl-trait returning functions reaching private items) - #53559 (add macro check for lint) - #53562 (Lament the invincibility of the Turbofish) - #53563 (use String::new() instead of String::from(""), "".to_string(), "".to_owned() or "".into()) - #53592 (docs: minor stylistic changes to str/string docs) - #53594 (Update RELEASES.md to include clippy-preview) - #53600 (Fix a grammatical mistake in "expected generic arguments" errors) - #53614 (update nomicon and book) - #53617 (tidy: Stop requiring a license header) - #53618 (Add missing fmt examples) - #53636 (Prefer `.nth(n)` over `.skip(n).next()`.) - #53644 (Use SmallVec for SmallCStr) - #53664 (Remove unnecessary closure in rustc_mir/build/mod.rs) - #53666 (Added rustc_codegen_llvm to compiler documentation.)
bjorn3
commented
Sep 11, 2018
Member
@Aaronepower why did you create this branch on rust-lang/rust instead of your personal fork? (https://github.com/rust-lang/rust/tree/Aaronepower-patch-1) |
ContributorAuthor
@bjorn3 Whoops, that was not intentional I created the pull request through GitHub's UI which before I was a team member would put it on my personal fork, apparently that behaviour changed I've deleted the branch now. |
bjorn3
commented
Sep 11, 2018
Member
:) noticed it when I pulled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
r? @Mark-Simulacrum