Skip to content

Add missing fmt examples - #53618

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fmt-examples
Aug 24, 2018
Merged

Add missing fmt examples#53618
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fmt-examples

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2018
Comment threadsrc/libcore/fmt/mod.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be expressed as self.nb.abs().to_string().

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be better actually.

@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

Updated.

@QuietMisdreavus

Copy link
Copy Markdown
Contributor

@bors r+ (travis is actually green if you click through, github never updated with the result)

@bors

bors commented Aug 23, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 2cc2e01 has been approved by QuietMisdreavus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2018
@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

@bors: rollup

@kennytmkennytm mentioned this pull request Aug 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 24, 2018
bors added a commit that referenced this pull request Aug 24, 2018
Rollup of 16 pull requests
Successful merges:
- #53311 (Window Mutex: Document that we properly initialize the SRWLock)
- #53503 (Discourage overuse of mem::forget)
- #53545 (Fix#50865: ICE on impl-trait returning functions reaching private items)
- #53559 (add macro check for lint)
- #53562 (Lament the invincibility of the Turbofish)
- #53563 (use String::new() instead of String::from(""), "".to_string(), "".to_owned() or "".into())
- #53592 (docs: minor stylistic changes to str/string docs)
- #53594 (Update RELEASES.md to include clippy-preview)
- #53600 (Fix a grammatical mistake in "expected generic arguments" errors)
- #53614 (update nomicon and book)
- #53617 (tidy: Stop requiring a license header)
- #53618 (Add missing fmt examples)
- #53636 (Prefer `.nth(n)` over `.skip(n).next()`.)
- #53644 (Use SmallVec for SmallCStr)
- #53664 (Remove unnecessary closure in rustc_mir/build/mod.rs)
- #53666 (Added rustc_codegen_llvm to compiler documentation.)
@bors
bors merged commit 2cc2e01 into rust-lang:masterAug 24, 2018
@GuillaumeGomez
GuillaumeGomez deleted the fmt-examples branch August 24, 2018 19:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@QuietMisdreavus@bors@rust-highfive