Skip to content

Document .0 to unpack integer from Wrapping - #53703

Merged
bors merged 1 commit into
rust-lang:masterfrom
sourcefrog:doc-wrapping
Sep 12, 2018
Merged

Document .0 to unpack integer from Wrapping#53703
bors merged 1 commit into
rust-lang:masterfrom
sourcefrog:doc-wrapping

Conversation

@sourcefrog

@sourcefrogsourcefrog commented Aug 25, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Aug 25, 2018

Copy link
Copy Markdown
Contributor

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2018
frewsxcv
frewsxcv reviewed Aug 26, 2018
View reviewed changes
Comment threadsrc/libcore/num/mod.rs Outdated

@frewsxcvfrewsxcvAug 25, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping isn't exclusively for integers – one can do Wrapping(0.0f32) if they want. So we may want this to say something like:

The underling value can be...

or

The enclosed number can be...

@sourcefrogsourcefrogAug 26, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks, fixed.

@frewsxcv

frewsxcv commented Aug 26, 2018

Copy link
Copy Markdown
Contributor

Thanks!

@bors r+ rollup

@bors

bors commented Aug 26, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 775f707669817f439c095ace0897c6ee8ba239fc has been approved by frewsxcv

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2018
@mzji

mzji commented Aug 27, 2018

Copy link
Copy Markdown

Seems like two submodules (binaryen and hoedown) are added... Do we really need those? I don't think a fix about documents requires two huge submodules to be added.

@frewsxcv

frewsxcv commented Aug 27, 2018

Copy link
Copy Markdown
Contributor

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 27, 2018
@frewsxcv

frewsxcv commented Aug 27, 2018

Copy link
Copy Markdown
Contributor

Good catch @mzji

@sourcefrog

sourcefrog commented Aug 27, 2018

Copy link
Copy Markdown
ContributorAuthor

Sorry, I'm confused by git submodules, and that was not intentional. I'll work out how to get them out.

@frewsxcv

frewsxcv commented Aug 29, 2018

Copy link
Copy Markdown
Contributor

You may be able to revert the submodule updates via git checkout master src/rt/hoedown sec/binaryen

@TimNN

TimNN commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

Ping from triage, @sourcefrog: Do you think you'll be able to make the requested changes? If you prefer, members of the Rust team can also push the requested updates to your branch. (Let me know if that is the case, and I can do it).

@sourcefrog

sourcefrog commented Sep 8, 2018

Copy link
Copy Markdown
ContributorAuthor

@TimNN yes, doing that now.

I tried git checkout on the submodules but it seems more like I need to rm -r them to get git to forget about them. I'll push a new commit soon.

@sourcefrog

sourcefrog commented Sep 8, 2018

Copy link
Copy Markdown
ContributorAuthor

OK should be clean now, please take another look.

@frewsxcv

frewsxcv commented Sep 9, 2018

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 9, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 597c065 has been approved by frewsxcv

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Sep 12, 2018
@kennytm
Rollup merge ofrust-lang#53703- sourcefrog:doc-wrapping, r=frewsxcv
605948f
Document .0 to unpack integer from Wrapping
@kennytmkennytm mentioned this pull request Sep 12, 2018
Merged
bors added a commit that referenced this pull request Sep 12, 2018
@bors
Auto merge of#54146- kennytm:rollup, r=kennytm
8586ec6
Rollup of 15 pull requests
Successful merges:
- #52514 (Fix a few AMDGPU related issues)
- #53703 (Document .0 to unpack integer from Wrapping)
- #53777 (Implemented map_or_else for Result<T, E>)
- #54031 (A few cleanups and minor improvements to rustc_passes)
- #54046 (Update documentation for fill_buf in std::io::BufRead)
- #54064 (`&CStr`, not `CStr`, is the counterpart of `&str`)
- #54072 (Stabilization change for mod.rs)
- #54073 (docs: Use dollar sign for all bash prompts)
- #54074 (simplify ordering for Kind)
- #54085 (Remove documentation about proc_macro being bare-bones)
- #54087 (rustdoc: Remove generated blanket impls from trait pages)
- #54106 (Reexport CheckLintNameResult)
- #54107 (Fix typos in libstd hash map)
- #54136 (Update LLVM to fix GlobalISel dbg.declare)
- #54142 (Recover proper regression test for issue #16278.)
Failed merges:
r? @ghost
@bors
bors merged commit 597c065 into rust-lang:masterSep 12, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@frewsxcvfrewsxcvfrewsxcv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@KodrAusKodrAus

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sourcefrog@rust-highfive@frewsxcv@bors@mzji@TimNN@KodrAus