Uh oh!
There was an error while loading. Please reload this page.
A few cleanups and minor improvements to rustc_passes - #54031
Merged
Conversation
rust-highfive
commented
Sep 7, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
oli-obk
commented
Sep 7, 2018
Contributor
@bors r+ rollup |
petrochenkov
commented
Sep 8, 2018
Contributor
@bors r=oli-obk |
bors
commented
Sep 8, 2018
Collaborator
📌 Commit 8bbe178 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Sep 12, 2018
A few cleanups and minor improvements to rustc_passes - prefer `if let` to `match` when only one branch matters - prefer equality checks to pattern matching - prefer `is_empty` to `len() == 0` - collapse a couple of `if` expressions - rename `label` to `destination` when destructuring `hir::ExprKind::Continue` - `derive Copy` for `Promotability` - `impl BitAndAssign` for `Promotability` - a few formatting fixes - a few other minor cleanups
bors added a commit
that referenced
this pull request
Sep 12, 2018
Rollup of 15 pull requests Successful merges: - #52514 (Fix a few AMDGPU related issues) - #53703 (Document .0 to unpack integer from Wrapping) - #53777 (Implemented map_or_else for Result<T, E>) - #54031 (A few cleanups and minor improvements to rustc_passes) - #54046 (Update documentation for fill_buf in std::io::BufRead) - #54064 (`&CStr`, not `CStr`, is the counterpart of `&str`) - #54072 (Stabilization change for mod.rs) - #54073 (docs: Use dollar sign for all bash prompts) - #54074 (simplify ordering for Kind) - #54085 (Remove documentation about proc_macro being bare-bones) - #54087 (rustdoc: Remove generated blanket impls from trait pages) - #54106 (Reexport CheckLintNameResult) - #54107 (Fix typos in libstd hash map) - #54136 (Update LLVM to fix GlobalISel dbg.declare) - #54142 (Recover proper regression test for issue #16278.) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if lettomatchwhen only one branch mattersis_emptytolen() == 0ifexpressionslabeltodestinationwhen destructuringhir::ExprKind::Continuederive CopyforPromotabilityimpl BitAndAssignforPromotability