Add slice::rchunks(), rchunks_mut(), rchunks_exact() and rchunks_exact_mut() by sdroege · Pull Request #54580 · rust-lang/rust

sdroege · 2018-09-25T22:39:09Z

These work exactly like the normal chunks iterators but start creating
chunks from the end of the slice.

The new iterators were motivated by a comment by @DutchGhost.


Also the stabilization tracking issue is just some number right now. I'll create the corresponding issue once this is reviewed and otherwise mergeable.
cc @DutchGhost

rust-highfive · 2018-09-25T22:39:19Z

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

dtolnay · 2018-09-28T06:28:53Z

Simon would you be able to take this review? I haven't gotten a chance to look at the code but this sounds like a natural extension of #47115.

r? @SimonSapin

bors · 2018-09-29T12:41:43Z

☔ The latest upstream changes (presumably #54554) made this pull request unmergeable. Please resolve the merge conflicts.

sdroege · 2018-09-29T13:18:35Z

umbrella The latest upstream changes (presumably #54554) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased

bors · 2018-10-12T04:54:02Z

☔ The latest upstream changes (presumably #54924) made this pull request unmergeable. Please resolve the merge conflicts.

sdroege · 2018-10-12T07:07:17Z

umbrella The latest upstream changes (presumably #54924) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased again

SimonSapin · 2018-10-18T07:31:02Z

Looks great, thanks! Sorry for the repeated conflicts and rebasing. r=me with the tracking issue changed to #55177

sdroege · 2018-10-18T07:37:47Z

Updated the tracking issue in the commit, thanks for the review and also thanks for creating the tracking issue :)

…t_mut() These work exactly like the normal chunks iterators but start creating chunks from the end of the slice. See rust-lang#55177 for the tracking issue

sdroege · 2018-10-18T09:58:39Z

travis is green again

SimonSapin · 2018-10-18T10:43:41Z

@bors r+

bors · 2018-10-18T10:43:42Z

📌 Commit 80a8e5c has been approved by SimonSapin

bors · 2018-10-18T12:47:38Z

⌛ Testing commit 80a8e5c with merge 121320d...

@DutchGhost

Add slice::rchunks(), rchunks_mut(), rchunks_exact() and rchunks_exact_mut() These work exactly like the normal chunks iterators but start creating chunks from the end of the slice. ---- The new iterators were motivated by a [comment](#47115 (comment)) by @DutchGhost. ~~~This currently includes the commits from #54537 to not have to rename things twice or have merge conflicts. I'll force-push a new version of the branch ones those are in master.~~~ Also the stabilization tracking issue is just some number right now. I'll create the corresponding issue once this is reviewed and otherwise mergeable. cc @DutchGhost

bors · 2018-10-18T15:34:20Z

☀️ Test successful - status-appveyor, status-travis
Approved by: SimonSapin
Pushing 121320d to master...

rust-highfive assigned dtolnay Sep 25, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2018

sdroege force-pushed the rchunks branch from f3d4575 to 9ee34eeCompare September 26, 2018 06:59

sdroege mentioned this pull request Sep 26, 2018
Tracking issue for chunks_exact/_mut; slice chunks with exact size #47115
Closed
1 task

kennytm added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 26, 2018

rust-highfive assigned SimonSapin and unassigned dtolnay Sep 28, 2018

sdroege force-pushed the rchunks branch from 9ee34ee to f725ec9Compare September 29, 2018 13:18

sdroege force-pushed the rchunks branch from f725ec9 to b04760cCompare October 12, 2018 07:07

SimonSapin mentioned this pull request Oct 18, 2018
Tracking issue for [T]::rchunks, rchunks_mut, rchunks_exact, rchunks_exact_mut #55177
Closed

sdroege force-pushed the rchunks branch from b04760c to c607034Compare October 18, 2018 07:37

Add slice::rchunks(), rchunks_mut(), rchunks_exact() and rchunks_exac…
80a8e5c
…t_mut() These work exactly like the normal chunks iterators but start creating chunks from the end of the slice. See rust-lang#55177 for the tracking issue

sdroege force-pushed the rchunks branch from c607034 to 80a8e5cCompare October 18, 2018 07:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2018

sdroege mentioned this pull request Oct 18, 2018
Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut() #55178
Merged

bors merged commit 80a8e5c into rust-lang:masterOct 18, 2018

Uh oh!

Uh oh!

Conversation

sdroege commented Sep 25, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Sep 25, 2018

Uh oh!

dtolnay commented Sep 28, 2018

Uh oh!

bors commented Sep 29, 2018

Uh oh!

sdroege commented Sep 29, 2018

Uh oh!

bors commented Oct 12, 2018

Uh oh!

sdroege commented Oct 12, 2018

Uh oh!

SimonSapin commented Oct 18, 2018

Uh oh!

sdroege commented Oct 18, 2018

Uh oh!

sdroege commented Oct 18, 2018

Uh oh!

SimonSapin commented Oct 18, 2018

Uh oh!

bors commented Oct 18, 2018

Uh oh!

bors commented Oct 18, 2018

Uh oh!

bors commented Oct 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sdroege commented Sep 25, 2018•
edited
Loading