Skip to content

Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut() - #55178

Merged
bors merged 2 commits into
rust-lang:masterfrom
sdroege:stabilize-chunks-exact
Oct 19, 2018
Merged

Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut()#55178
bors merged 2 commits into
rust-lang:masterfrom
sdroege:stabilize-chunks-exact

Conversation

@sdroege

@sdroegesdroege commented Oct 18, 2018•
edited by kennytm
Loading

Copy link
Copy Markdown
Contributor

Fixes#47115, fixes#55177

@rust-highfive

rust-highfive commented Oct 18, 2018

Copy link
Copy Markdown
Contributor

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2018
@sdroegesdroege mentioned this pull request Oct 18, 2018
Closed
1 task
@alexcrichton

alexcrichton commented Oct 18, 2018

Copy link
Copy Markdown
Member

If you'd like to throw in the rchunks_* style APIs I think that'd be a good idea as well! They're clearly consistent with other APIs we have an the purpose of FCP for the inclusion at all and semantics is taken care of now!

@sdroege

sdroege commented Oct 18, 2018

Copy link
Copy Markdown
ContributorAuthor

If you'd like to throw in the rchunks_* style APIs I think that'd be a good idea as well! They're clearly consistent with other APIs we have an the purpose of FCP for the inclusion at all and semantics is taken care of now!

Great, I'll add it once #54580 is in master :)

@bors

bors commented Oct 18, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #54580) made this pull request unmergeable. Please resolve the merge conflicts.

@sdroege
sdroegeforce-pushed the stabilize-chunks-exact branch 2 times, most recently from a83d82c to cdd7ccdCompareOctober 18, 2018 15:50
@sdroegesdroege mentioned this pull request Oct 18, 2018
Closed
@sdroege
sdroegeforce-pushed the stabilize-chunks-exact branch from cdd7ccd to 52cc6fdCompareOctober 18, 2018 15:52
@sdroegesdroege changed the title Stabilize slice::chunks_exact() and slice::chunks_exact_mut()Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut()Oct 18, 2018
@sdroege

sdroege commented Oct 18, 2018

Copy link
Copy Markdown
ContributorAuthor

Great, I'll add it once #54580 is in master :)

Done, also needed a rebase anyway

@alexcrichton

alexcrichton commented Oct 18, 2018

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Oct 18, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 52cc6fd has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2018
@kennytmkennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 19, 2018
@kennytmkennytm mentioned this pull request Oct 19, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Oct 19, 2018
@kennytm
Rollup merge ofrust-lang#55178- sdroege:stabilize-chunks-exact, r=a…
4763c22
…lexcrichton
Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut()
Fixesrust-lang#47115, rust-lang#55177
bors added a commit that referenced this pull request Oct 19, 2018
@bors
Auto merge of#55194- kennytm:rollup, r=kennytm
74ff7dc
Rollup of 7 pull requests
Successful merges:
- #54300 (Updated RELEASES.md for 1.30.0)
- #55013 ([NLL] Propagate bounds from generators)
- #55071 (Fix ICE and report a human readable error)
- #55144 (Cleanup resolve)
- #55166 (Don't warn about parentheses on `match (return)`)
- #55169 (Add a `copysign` function to f32 and f64)
- #55178 (Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut())
@bors
bors merged commit 52cc6fd into rust-lang:masterOct 19, 2018
@SimonSapinSimonSapin mentioned this pull request Oct 22, 2018
Closed
@CentrilCentril added the T-libs-api [DEPRECATED; DO NOT USE] label Apr 27, 2019
@CentrilCentril added this to the 1.31 milestone Apr 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@shepmastershepmaster

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.31

Development

Successfully merging this pull request may close these issues.

Tracking issue for [T]::rchunks, rchunks_mut, rchunks_exact, rchunks_exact_mut Tracking issue for chunks_exact/_mut; slice chunks with exact size

7 participants

@sdroege@rust-highfive@alexcrichton@bors@kennytm@shepmaster@Centril